Add support for IntelLLVM compiler#1276
Conversation
|
Thank you @DusanJovic-NOAA, I will start reviewing this. |
|
When I build ufs-weather-model with WW3 component I noticed the following compiler warning: I traced to source of this warning WW3 cmake where compiler flags are set to ww3_lib target as PUBLIC. I think these flags should be set as PRIVATE. @aerorahul I can make this change in this PR if it's acceptable. |
|
@MatthewMasarik-NOAA Can you review this pr? We are going to start testing at ufs-community/ufs-weather-model#2224 |
@jkbk2004, yes will do. I can complete it by later today or early tomorrow |
There was a problem hiding this comment.
Code review
Pass
Testing
Pass
- Machine: Hera
- Description: WW3 standalone was cmake configured and built using Intel-LLVM stack.
Selection of LLVM for C and Fortran compilers confirmed in cmake config output:
-- The C compiler identification is IntelLLVM 2023.2.0
-- The Fortran compiler identification is IntelLLVM 2023.2.0
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Check for working C compiler: /apps/oneapi/compiler/2023.2.0/linux/bin/icx - skipped
-- Detecting C compile features
-- Detecting C compile features - done
-- Detecting Fortran compiler ABI info
-- Detecting Fortran compiler ABI info - done
-- Check for working Fortran compiler: /apps/oneapi/compiler/2023.2.0/linux/bin/ifx - skipped
-- Checking whether /apps/oneapi/compiler/2023.2.0/linux/bin/ifx supports Fortran 90
-- Checking whether /apps/oneapi/compiler/2023.2.0/linux/bin/ifx supports Fortran 90 - yes
Full logs:
|
@jkbk2004 @DusanJovic-NOAA, sorry for the delay, this is cleared from my end. |
|
@MatthewMasarik-NOAA all tests are done ufs-community/ufs-weather-model#2224. Please, go ahead to merge this pr. |
Will do @jkbk2004. I'll let you know shortly |
|
@jkbk2004, done. |
|
@DusanJovic-NOAA, thanks for spearheading this. |
Pull Request Summary
This PR adds support for Intel LLVM compiler.
Description
model/src/CMakeLists.txthas been updated to recognize 'IntelLLVM as a valid compiler id and to define compiler flags for Intel LLVM compiler.Issue(s) addressed
Commit Message
Add support for IntelLLVM compiler
Check list
Testing