Add timers and overwrite capability for mod_def timesteps to meshcap #1164
Closed
DeniseWorthen wants to merge 4 commits into
Closed
Add timers and overwrite capability for mod_def timesteps to meshcap #1164DeniseWorthen wants to merge 4 commits into
DeniseWorthen wants to merge 4 commits into
Conversation
* mod_def with slow timesteps overwritten verifies against run using mod_def containing the fast timesteps * mod_def with slow timesteps overwritten reproduces on restart
* unlike CICE, there is no CESM specific shr code used in WW3
41 tasks
Contributor
|
I will get these started as well! |
MatthewMasarik-NOAA
approved these changes
Jan 12, 2024
Contributor
MatthewMasarik-NOAA
left a comment
There was a problem hiding this comment.
The code changes are only in the meshcap code, so standalone testing is not necessary. UFS-WM testing has confirmed that no RT baselines change.
Approved.
Contributor
Author
|
Combined with #1163; Closing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Summary
Adds run timers to the meshcap
Description
Adds generation of a timer log in the meshcap, which will report, for example, the time spent in
modelAdvanceas well as the time spent before starting the next Advance. The capability is added using a wrapper mod (mimicking the CICE wrapper mod) so that no additional ifdefs are required in the cap. The output generated inlog.ww3.timerisAlso adds capability to over-write timesteps from the mod_def file with other values. See associated UWM ufs-community/ufs-weather-model#2086 for description of how this works.
Issue(s) addressed
Commit Message
add timer log functionality to meshcap
Check list
Testing
Testing in UWM ufs-community/ufs-weather-model#2086 has no impact on baselines.