Remove dependency on sfcio and use sigio only when nemsio is enabled by DusanJovic-NOAA · Pull Request #930 · NOAA-EMC/UPP

DusanJovic-NOAA · 2024-04-16T21:03:05Z

The sfcio library is not needed anymore, so we can remove the dependency on it. The sigio library is needed only in part of the code that reads nemsio files, so it should be required only when nemsio is enabled.

WenMeng-NOAA · 2024-04-19T02:33:16Z

@DusanJovic-NOAA Can you update modulefiles/wcoss2.lua to remove sfcio lib?

DusanJovic-NOAA · 2024-04-19T12:25:55Z

@DusanJovic-NOAA Can you update modulefiles/wcoss2.lua to remove sfcio lib?

Done

WenMeng-NOAA · 2024-04-19T12:37:25Z

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

WenMeng-NOAA · 2024-04-19T12:43:14Z

@gspetro-NOAA The sfcio lib dependency will be completely retired from UPP. You might update the UPP documentation accordingly.

WenMeng-NOAA · 2024-04-19T13:38:11Z

@DusanJovic-NOAA I tested the option to build UPP executable without nemsio and got failure as:

> cd UPP/tests
> ./compile_upp.sh -n
Scanning dependencies of target upp.x
[ 95%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/intio_tags.f.o
[ 95%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/wrf_io_flags.f.o
[ 95%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/GFSPOSTSIG.F.o
[ 95%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/INITPOST_NETCDF.f.o
[ 97%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/WRFPOST.F.o
[ 97%] Building Fortran object sorc/ncep_post.fd/CMakeFiles/upp.x.dir/getlvls.f.o
/u/wen.meng/ptmp/dusan/UPP/sorc/ncep_post.fd/GFSPOSTSIG.F(97): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [SIGIO_MODULE]
  use sigio_module,   only : sigio_intkind, sigio_head
------^
/u/wen.meng/ptmp/dusan/UPP/sorc/ncep_post.fd/GFSPOSTSIG.F(98): error #7002: Error in opening the compiled module file.  Check INCLUDE paths.   [SIGIO_R_MODULE]
  use sigio_r_module, only : sigio_dati, sigio_rrdati
------^
/u/wen.meng/ptmp/dusan/UPP/sorc/ncep_post.fd/GFSPOSTSIG.F(102): error #6683: A kind type parameter must be a compile-time constant.   [SIGIO_INTKIND]
  integer(sigio_intkind),intent(in)    :: lusig
----------^
/u/wen.meng/ptmp/dusan/UPP/sorc/ncep_post.fd/GFSPOSTSIG.F(103): error #6457: This derived type name has not been declared.   [SIGIO_HEAD]
  type(sigio_head),      intent(in)    :: head
-------^
/u/wen.meng/ptmp/dusan/UPP/sorc/ncep_post.fd/GFSPOSTSIG.F(112): error #6683: A kind type parameter must be a compile-time constant.   [SIGIO_INTKIND]
  integer(sigio_intkind):: irets
...

DusanJovic-NOAA · 2024-04-19T13:56:53Z

I forgot to move GFSPOSTSIG.F to if (BUILD_WITH_NEMSIO) block. Please try again.

WenMeng-NOAA · 2024-04-19T14:57:13Z

I forgot to move GFSPOSTSIG.F to if (BUILD_WITH_NEMSIO) block. Please try again.

@DusanJovic-NOAA Now it works well.

WenMeng-NOAA · 2024-04-19T14:58:39Z

The UPP RTs have been completed on WCOSS2. The UPP building without nemsio lib was tested.

FernandoAndrade-NOAA · 2024-04-19T15:55:31Z

@FernandoAndrade-NOAA You may start the UPP RTs on Hera and Orion. No baseline update is expected.

RTs completed on Hera, Hercules, and Orion with no changes to results.

WenMeng-NOAA · 2024-04-19T18:16:42Z

This PR is ready for merging.

commit 13d5b6d Author: EricJames-NOAA <eric.james@noaa.gov> Date: Mon Apr 29 15:28:47 2024 -0600 RRFS updates (NOAA-EMC#938) * Initial commit to rename RRFS fix files, update EBB to be vertically integrated from 3D ebu_smoke, and switch to use 1-h average HWP. * Getting rid of vertically integrated hydrometeor fields. * Updating postxconfig-NT-rrfs.txt commit 88493f3 Author: Wei Huang <wei.huang@noaa.gov> Date: Fri Apr 26 21:29:51 2024 -0600 add module for AWS (NOAA-EMC#934) * add module for AWS * comment that this is for NOAA Cloud commit be0410e Author: hsinmulin-NOAA <48441737+hsinmulin-NOAA@users.noreply.github.com> Date: Tue Apr 23 15:46:47 2024 -0400 Add files via upload (NOAA-EMC#937) add 1. 80 m for SPFH_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT 2. 80 m for PRES_ON_SPEC_HGT_LVL_ABOVE_GRND_FDHGT commit 79d74d9 Author: Edward Hartnett <38856240+edwardhartnett@users.noreply.github.com> Date: Mon Apr 22 13:34:39 2024 -0600 turn on doxygen build in CI (NOAA-EMC#932) * turn on doxygen build in CI * turn on doxygen build in CI * turn on doxygen build in CI * turn on doxygen build in CI * fixed cmake file * fixed doc directory commit 5d6d179 Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Date: Fri Apr 19 14:17:10 2024 -0400 Remove dependency on sfcio and use sigio only when nemsio is enabled (NOAA-EMC#930) * Remove sfcio and use sigio only when numsio is enabled * Remove sfcio from modulefiles/wcoss2.lua * Compile GFSPOSTSIG.F only if nemsio is enabled commit 91921f4 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Mon Apr 15 21:04:39 2024 -0400 Bump idna from 3.6 to 3.7 in /doc/UserGuide (NOAA-EMC#928) Bumps [idna](https://github.com/kjd/idna) from 3.6 to 3.7. - [Release notes](https://github.com/kjd/idna/releases) - [Changelog](https://github.com/kjd/idna/blob/master/HISTORY.rst) - [Commits](kjd/idna@v3.6...v3.7) --- updated-dependencies: - dependency-name: idna dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wen Meng <Wen.Meng@noaa.gov> commit 8bc3fc9 Author: EricJames-NOAA <eric.james@noaa.gov> Date: Fri Apr 12 16:06:36 2024 -0600 Bug fix for blowing snow effect on visibility (NOAA-EMC#915) * Correcting bug in CALVIS_GSD.f * Introducing roughness length impact on BLSN (no BLSN effect at z0>0.7). * Removing some gridpoint print statements for testing. * Checking change to compile_upp.sh * Reverting change. commit fd93933 Author: YaliMao-NOAA <53870326+YaliMao-NOAA@users.noreply.github.com> Date: Thu Apr 11 17:14:24 2024 +0000 For RRFS, change the mnemonics of column max of EDPARM from EDPARM on 0m level to MXEDPRM of the entire atmosphere. (NOAA-EMC#926) For this purpose, MXEDPRM is added to both post_avblflds.xml and control file fv3lam_rrfs.xml commit 5faac75 Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Date: Tue Apr 9 18:25:18 2024 -0400 Correct total soil moisture from SOIMOI to CISOIM (NOAA-EMC#922) * Correct total soil moisture from SOIMOI to CISOIM * Update shortname of UPP ID 36 * update CMake debug mode commit 83e83a9 Author: Innocent Souopgui <162634017+InnocentSouopgui-NOAA@users.noreply.github.com> Date: Fri Apr 5 15:10:14 2024 -0500 Remove the detection of Jet/Centos7 nodes (NOAA-EMC#920) * Remove the detection of Jet/Centos7 nodes and removes the associated module file jet_c.lua * Update detect_machine.sh remove hera 12 --------- Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com> commit 1d1e58a Author: Dusan Jovic <48258889+DusanJovic-NOAA@users.noreply.github.com> Date: Fri Apr 5 13:10:20 2024 -0400 Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio (NOAA-EMC#911) * Add BUILD_WITH_NEMSIO build option to allow building UPP without nemsio * Specify w3emc and bacio as dependencies of nemsio library * Add compile_upp.sh option to build without nemsio (-n) commit 7d39b5c Author: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Date: Thu Apr 4 17:07:14 2024 -0400 Add LTNG in PRSLEV dataset of RRFS (NOAA-EMC#918) commit 62ecf8a Author: AndrewBenjamin-NOAA <103067657+AndrewBenjamin-NOAA@users.noreply.github.com> Date: Thu Apr 4 14:50:08 2024 -0400 RRFSv1.0 Product cleanup: removal of retired products from fv3lam_rrfs.xml (NOAA-EMC#909) * removed <table_info>NCEP</table_info> for ULWRF to use the official WMO ID rather than the dupilcate NCEP local use ID * removed <table_info>NCEP</table_info> from REFZR, REFZI, BMIXL, and CNWAT to use WMO grib2 ids * removed <table_info>NCEP</table_info> from SNOWC, SFEXC, SSRUN, BGRUN, FRICV, CD, SNOHF, PEVAP, TCOLI in order to use WMO id over NCEP local use ID. * removed <table_info>NCEP<table_info> from SNFALB, CDLYR, USWRF, DSWRF, DLWRF, VWSH, TCOLR, TCOLS, UPHL * removed <table_info>NCEP<table_info> from MSTAV in post_avblflds.xml to use WMO grib2 id for RRFS * removed duplicate CNWAT NATLEV entry in fv3lam_rrfs.xml. * updated fv3lam_rrfs.xml and parm/postxconfig-NT-fv3lam_rrfs.txt to remove products no longer needed in the RRFS. * changed precision in SSRUN * fixed SSRUN precision in flat file * removed LSPA and SNOWC from NATLEV commit df9b16b Author: EricJames-NOAA <eric.james@noaa.gov> Date: Mon Apr 1 15:51:56 2024 -0600 Add surface albedo, accumulated snow melt, and total soil moisture output in RRFS (NOAA-EMC#908) * Updating CLDRAD and INITPOST_NETCDF * Reverting change in CLDRAD.f * Changes to output CISOILM and SNOM. * Cleaning up syntax. * Adding change logs. * Small updates. * Removing extcof55 from visibility calculation (it's all zeroes). * Reverting change in INITPOST_NETCDF.f setting smstot to spval * Using a single level "0 m underground" for CISOILM commit 92b080d Author: KarinaAsmar-NOAA <148993962+KarinaAsmar-NOAA@users.noreply.github.com> Date: Sat Mar 30 20:03:49 2024 -0400 Add additional SFS variables and isobaric levels (NOAA-EMC#903) * added additional isobaric levels * adding HLCY, SSRUN, VBDSF * added HLCY, SSRUN, VBDSF * replacing id 772 with 401 and 403 (vbdsf and nbdsf) * vbdsf and nbdsf with info from avblflds * removed id 772 and added 401 and 403 (vbdsf and nbdsf) * vbdsf and nbdsf copied from gfs flux * vbdsf and nbdsf copied from gfs flux

…3 for SRW3.0 release (NOAA-EMC#930) * update the ufs-community:ufs/dev branch of ccpp-physics from the NCAR:main * update GF/C3 for SRW3.0 release --------- Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>

DusanJovic-NOAA and others added 2 commits April 15, 2024 21:15

Remove sfcio and use sigio only when numsio is enabled

6aa5952

Merge branch 'NOAA-EMC:develop' into remove_sfcio

89cff7f

DusanJovic-NOAA requested a review from WenMeng-NOAA as a code owner April 16, 2024 21:03

WenMeng-NOAA linked an issue Apr 19, 2024 that may be closed by this pull request

Remove dependency on sfcio and use sigio only when nemsio is enabled #935

Closed

WenMeng-NOAA added enhancement New feature or request Ready for Review This PR is ready for code review. labels Apr 19, 2024

Remove sfcio from modulefiles/wcoss2.lua

8849061

WenMeng-NOAA requested a review from FernandoAndrade-NOAA April 19, 2024 12:36

Compile GFSPOSTSIG.F only if nemsio is enabled

733f9cf

WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Apr 19, 2024

FernandoAndrade-NOAA approved these changes Apr 19, 2024

View reviewed changes

WenMeng-NOAA approved these changes Apr 19, 2024

View reviewed changes

WenMeng-NOAA merged commit 5d6d179 into NOAA-EMC:develop Apr 19, 2024

WenMeng-NOAA mentioned this pull request Apr 19, 2024

Updates in develop branch since 06/2023 #715

Closed

DusanJovic-NOAA deleted the remove_sfcio branch April 23, 2024 13:42

WenMeng-NOAA mentioned this pull request Apr 26, 2024

add module for AWS #934

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove dependency on sfcio and use sigio only when nemsio is enabled#930

Remove dependency on sfcio and use sigio only when nemsio is enabled#930
WenMeng-NOAA merged 4 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:remove_sfcio

DusanJovic-NOAA commented Apr 16, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

DusanJovic-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

DusanJovic-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

FernandoAndrade-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

DusanJovic-NOAA commented Apr 16, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

DusanJovic-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

DusanJovic-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

FernandoAndrade-NOAA commented Apr 19, 2024

Uh oh!

WenMeng-NOAA commented Apr 19, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants