Skip to content

Changes needed for ufs-weather-model IFI regression tests on Acorn#655

Merged
WenMeng-NOAA merged 3 commits into
NOAA-EMC:developfrom
SamuelTrahanNOAA:ifi_acorn
Mar 10, 2023
Merged

Changes needed for ufs-weather-model IFI regression tests on Acorn#655
WenMeng-NOAA merged 3 commits into
NOAA-EMC:developfrom
SamuelTrahanNOAA:ifi_acorn

Conversation

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor

@SamuelTrahanNOAA SamuelTrahanNOAA commented Mar 9, 2023

In its pull request to ufs-weather-model, the IFI is getting regression tests on Acorn. These are two related problems in UPP

  1. The standalone UPP build system has the wrong path for libifi on acorn.
  2. The fv3lam.xml and associated txt do not request the IFI fields.

Issue is here:

#656

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA Can you open an UPP issue for this PR? Thanks!

@WenMeng-NOAA WenMeng-NOAA linked an issue Mar 9, 2023 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@SamuelTrahanNOAA Can you sync your branch with the top of the UPP develop?

@SamuelTrahanNOAA
Copy link
Copy Markdown
Contributor Author

I just synced it.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The testing of building UPP excitable with IFI lib on WCOSS2_Acorn looks good.

@WenMeng-NOAA WenMeng-NOAA added Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. labels Mar 10, 2023
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. The new baseline for rrfs will be recreated with this PR. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit a30a8ae into NOAA-EMC:develop Mar 10, 2023
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
* Bugfixes for RRTMGP
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Updates needed for IFI on Acorn & inline post

2 participants