Update documentation for variables in CALGUST.f and CALHEL.f#630
Merged
Conversation
fossell
approved these changes
Feb 13, 2023
Contributor
fossell
left a comment
fossell
left a comment
There was a problem hiding this comment.
Changes look good to me. Documentation updates only, no change to code.
Contributor
|
@gspetro-NOAA - Looks good to me. Please wait for @WenMeng-NOAA to review and approve and give the ago ahead for merging. |
Collaborator
|
@gspetro-NOAA Your PR will be the next one being processed. Can you make it up to date with develop branch? The syncing procedures can be found at |
Collaborator
Author
|
Done! :) Let me know if you need anything else.
I believe I will need to issue a PR to the gh-pages branch with the updated
html files once this is merged, so keep an eye out for that.
Best,
Gillian
…On Tue, Feb 14, 2023 at 8:35 AM WenMeng-NOAA ***@***.***> wrote:
@gspetro-NOAA <https://github.com/gspetro-NOAA> Your PR will be the next
one being processed. Can you make it up to date with develop branch? The
syncing procedures can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository
—
Reply to this email directly, view it on GitHub
<#630 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AXDGAE3533AEKLDWIKXVAE3WXOCYHANCNFSM6AAAAAAUYCF374>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
WenMeng-NOAA
added
documentation
WenMeng-NOAA
approved these changes
Feb 14, 2023
Collaborator
|
The UPP RT tests were completed on WCOSS2. No baseline change is needed with this PR. This PR is ready for merging. |
zhanglikate
pushed a commit
to zhanglikate/UPP
that referenced
this pull request
Oct 10, 2025
* MYNN update * "merge RRFS-SD from the GSL repo to the Community repo" * "include MYNN-EDMF updates from PR NOAA-EMC#630" Co-authored-by: joeolson42 <Joseph.B.Olson@noaa.gov> Co-authored-by: Haiqin.Li <Haiqin.Li@noaa.gov>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides a definition for the LPBL and ZPBL variables in CALGUST.f
It also corrects a typo in CALHEL.f that generated a warning (DPTH --> should be DEPTH).
This partially addresses Issue #392 .