Skip to content

Small changes to exp2 ceiling and SLP output#629

Merged
WenMeng-NOAA merged 6 commits into
NOAA-EMC:developfrom
EricJames-NOAA:exp2_final
Feb 14, 2023
Merged

Small changes to exp2 ceiling and SLP output#629
WenMeng-NOAA merged 6 commits into
NOAA-EMC:developfrom
EricJames-NOAA:exp2_final

Conversation

@EricJames-NOAA
Copy link
Copy Markdown
Contributor

This PR includes a small revision to the RAP/HRRR exp2 ceiling diagnostic to improve performance for the RRFS. It also removes MLSMA (MAPS SLP reduction) output, based on conversations with Jacob Carley and Andrew Benjamin (NCEP) and Curtis Alexander (GSL). It also corrects the GRIB2 name for the MAPS SLP (should be MSLMA instead of PRMSL based on https://www.nco.ncep.noaa.gov/pmb/docs/grib2/grib2_doc/grib2_table4-2-0-3.shtml) in post_avblflds.xml.

The changes were tested for RRFS_B (CONUS 3km) on Jet; the only change to output was removal of the MAPS SLP, and changes in the exp2 ceiling field.

…ng from RRFS postxconfig file, and a slight change to exp2 ceiling diagnostic.
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Could you sync your branch with the latest commit of the develop branch from the authoritative UPP repos.?

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EdwardColon-NOAA Please let me know if you have comments on grib2 name change of MAPS SLP reduction in 3drtma control file.

@EdwardColon-NOAA
Copy link
Copy Markdown
Contributor

The change in the ceiling diagnostic seems reasonable. As long as the update is reflected in the 3drtma control file, there should not be a downstream issue with the analysis.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Could you add change logs in the source code you modify?

@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 13, 2023 that may be closed by this pull request
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Feb 13, 2023
Comment thread parm/post_avblflds.xml
Comment thread parm/postxconfig-NT-3drtma.txt Outdated
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

There are following changed results from RT tests from hrrr/rap:

rap:
[Wen.Meng@hfe04 ~/stmp2]$ cat rap_2020072316/WRFNAT.GrbF16.diff
1070:282595626:HGT:cloud base:rpn_corr=0.808426:rpn_rms=5241.32
1071:283798237:PRES:cloud base:rpn_corr=0.830284:rpn_rms=24110.9

hrrr:
[Wen.Meng@hfe04 ~/stmp2]$ cat hrrr_2020060118/WRFTWO.GrbF04.diff
121:85620587:HGT:cloud base:rpn_corr=0.896319:rpn_rms=3621.46
122:88016324:PRES:cloud base:rpn_corr=0.895746:rpn_rms=15131.5

@EricJames-NOAA Can you confirm the above changes are expected? Thanks!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The grib2 name of MAPS SLP reduction in 3drtma will be changed from PRMSL to MSLMA.

@WenMeng-NOAA WenMeng-NOAA added the Baseline Change The baselines of the UPP regression tests are changed. label Feb 13, 2023
@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

There are following changed results from RT tests from hrrr/rap:

rap:
[Wen.Meng@hfe04 ~/stmp2]$ cat rap_2020072316/WRFNAT.GrbF16.diff
1070:282595626:HGT:cloud base:rpn_corr=0.808426:rpn_rms=5241.32
1071:283798237:PRES:cloud base:rpn_corr=0.830284:rpn_rms=24110.9

hrrr:
[Wen.Meng@hfe04 ~/stmp2]$ cat hrrr_2020060118/WRFTWO.GrbF04.diff
121:85620587:HGT:cloud base:rpn_corr=0.896319:rpn_rms=3621.46
122:88016324:PRES:cloud base:rpn_corr=0.895746:rpn_rms=15131.5

@EricJames-NOAA Can you confirm the above changes are expected? Thanks!

@WenMeng-NOAA yes, that's consistent with my tests! The GSL exp2 ceiling diagnostic is labeled HGT/PRES on cloud base according to post_avblflds_raphrrr.xml. That is the only field I expect to change from this change. Thanks.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@EricJames-NOAA Can you update post_avblflds.xml based on my comments and sync your branch with latest commit from the develop branch? Thanks!

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA I think I just synced with the latest commit from the develop branch. I already added the NCEP table info line for post_avblflds.xml...please let me know if there are other changes needed for this file.

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA looks like one of the checks failed...maybe I did something wrong when syncing my branch with the latest EMC develop...let me know what you recommend...

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA I think I just synced with the latest commit from the develop branch. I already added the NCEP table info line for post_avblflds.xml...please let me know if there are other changes needed for this file.

@EricJames-NOAA I saw it. Thanks for clarifying.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA looks like one of the checks failed...maybe I did something wrong when syncing my branch with the latest EMC develop...let me know what you recommend...

@EricJames-NOAA I re-run the failed CI test. Now all CI tests look good. I would assume that's github issue. All your changes look good to me.

@EricJames-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA looks like one of the checks failed...maybe I did something wrong when syncing my branch with the latest EMC develop...let me know what you recommend...

@EricJames-NOAA I re-run the failed CI test. Now all CI tests look good. I would assume that's github issue. All your changes look good to me.

@WenMeng-NOAA thanks! Sounds good.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. The baselines for rap/hrrr and 3drtma will be updated with this PR.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 8c7ca6f into NOAA-EMC:develop Feb 14, 2023
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
* Add support for writing restart file on the write grid comp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3DRTMA Baseline Change The baselines of the UPP regression tests are changed. Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tiny change to GSL experimental ceiling diagnostic

3 participants