Skip to content

Solve conflicted UPP IDs #625

Merged
WenMeng-NOAA merged 1 commit into
NOAA-EMC:developfrom
WenMeng-NOAA:post_upp_id
Feb 6, 2023
Merged

Solve conflicted UPP IDs #625
WenMeng-NOAA merged 1 commit into
NOAA-EMC:developfrom
WenMeng-NOAA:post_upp_id

Conversation

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

Remove output of UPP ID 742 and 743 (rap/hrrr specified instant upward/downward clear-sky SW) in CLDRAD.f. These two IDs have conflicts with other two RRFS specified fields.

@WenMeng-NOAA WenMeng-NOAA added RRFS bug Something isn't working Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. labels Feb 3, 2023
@WenMeng-NOAA WenMeng-NOAA linked an issue Feb 3, 2023 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@EricJames-NOAA EricJames-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

The UPP RT tests were completed on WCOSS2, Hera and Orion. No baseline update is needed for this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit 14126a5 into NOAA-EMC:develop Feb 6, 2023
@WenMeng-NOAA WenMeng-NOAA deleted the post_upp_id branch June 26, 2023 11:47
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
* allow consisten restart file name with date

* remove intrm_rst and restart_endfcst in fcst finalize

* remove restart_endfcst from fcst grid comp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. RRFS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UPP ID conflict

2 participants