Skip to content

GSL UPP developments up to January 2023 #620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 7 commits into from
Jan 31, 2023
Merged

GSL UPP developments up to January 2023 #620

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
91f3711
GSL UPP developments up to January 2023
SamuelTrahanNOAA Jan 26, 2023
eb8f4e3
inline post bug fix: deallocate ifi arrays before next iteration of post
SamuelTrahanNOAA Jan 27, 2023
c6a5781
Merge remote-tracking branch 'sam/ifi-inline-post-fix' into merge_RRF…
SamuelTrahanNOAA Jan 27, 2023
418802c
Merge remote-tracking branch 'upstream/develop' into merge_RRFS_dev_t…
SamuelTrahanNOAA Jan 27, 2023
bb195dc
Update sorc/ncep_post.fd/IFI.F
SamuelTrahanNOAA Jan 27, 2023
94e7e15
automatically choose cldfra or cldfra_bl
SamuelTrahanNOAA Jan 30, 2023
a351111
update author info
SamuelTrahanNOAA Jan 31, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion parm/fv3lam_rrfs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1790,7 +1790,7 @@
<param>
<shortname>VIL_ON_ENTIRE_ATMOS</shortname>
<pname>VIL</pname>
<scale>4.0</scale>
<scale>7.0</scale>
</param>

<param>
Expand Down
2 changes: 1 addition & 1 deletion parm/postxconfig-NT-fv3lam_rrfs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9742,7 +9742,7 @@ entire_atmos_single_lyr
0
0.0
1
4.0
7.0
0
0
0
Expand Down
36 changes: 22 additions & 14 deletions sorc/ncep_post.fd/CLDRAD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2098,11 +2098,18 @@ SUBROUTINE CLDRAD
! However, for RAPv5/HRRRv4, paramater 711 will be supplied as
! the GSD cloud-base height, and parameter 798 will be the
! corresponding cloud-base pressure. (J. Kenyon, 4 Nov 2019)
! -- E. James, 15 Dec 2022
! The above experimental diagnostic, developed for the HRRR with
! lots of "add-ons" to correct for the HRRR's low bias in cloud
! cover, needs to be revised for the RRFS with its more extensive
! cloudiness. For an FAA deliverable due Feb 2023, the diagnostic
! is being modified to get rid of some of the add ons.

! Parameters 711/798: experimental ceiling diagnostic #2 (height and pressure, respectively)
IF ((IGET(711)>0) .OR. (IGET(798)>0)) THEN
! set minimum cloud fraction to represent a ceiling
ceiling_thresh_cldfra = 0.4
! ceiling_thresh_cldfra = 0.4
ceiling_thresh_cldfra = 0.5
! set some constants for ceiling adjustment in snow (retained from legacy algorithm, also in calvis.f)
rhoice = 970.
coeffp = 10.36
Expand Down Expand Up @@ -2192,23 +2199,24 @@ SUBROUTINE CLDRAD
end do
!-- end of search 2

zceil = min(zceil1,zceil2) ! choose lower of zceil1 and zceil2
! zceil = min(zceil1,zceil2) ! choose lower of zceil1 and zceil2
zceil = zceil1

!-- Search for "indefinite ceiling" (vertical visibility) conditions: consider
! lowering of apparent ceiling due to falling snow (retained from legacy
! diagnostic); this is extracted from calvis.f (visibility diagnostic)
if (QQS(i,j,LM)>1.e-10) then
TV=T(I,J,lm)*(H1+D608*Q(I,J,lm))
RHOAIR=PMID(I,J,lm)/(RD*TV)
vovermd = (1.+Q(i,j,LM))/rhoair + QQS(i,j,LM)/rhoice
concfp = QQS(i,j,LM)/vovermd*1000.
betav = coeffp*concfp**exponfp + 1.e-10
vertvis = 1000.*min(90., const1/betav)
if (vertvis < zceil-FIS(I,J)*GI ) then ! if vertvis is more restictive than zceil found above; set zceil to vertvis
! note that FIS is geopotential of the surface (ground), and GI is 1/g
zceil = FIS(I,J)*GI + vertvis
end if
end if
! if (QQS(i,j,LM)>1.e-10) then
! TV=T(I,J,lm)*(H1+D608*Q(I,J,lm))
! RHOAIR=PMID(I,J,lm)/(RD*TV)
! vovermd = (1.+Q(i,j,LM))/rhoair + QQS(i,j,LM)/rhoice
! concfp = QQS(i,j,LM)/vovermd*1000.
! betav = coeffp*concfp**exponfp + 1.e-10
! vertvis = 1000.*min(90., const1/betav)
! if (vertvis < zceil-FIS(I,J)*GI ) then ! if vertvis is more restictive than zceil found above; set zceil to vertvis
! ! note that FIS is geopotential of the surface (ground), and GI is 1/g
! zceil = FIS(I,J)*GI + vertvis
! end if
! end if

ceil(I,J) = zceil
ENDDO ! i loop
Expand Down
1 change: 1 addition & 0 deletions sorc/ncep_post.fd/IFI.F
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,6 +199,7 @@ subroutine make_communicators
! and for determining root ranks.
allocate(ista_grid(size))
allocate(jsta_grid(size))

Comment thread
SamuelTrahanNOAA marked this conversation as resolved.
Outdated
ista_grid=-1
jsta_grid=-1
call MPI_Allgather(ista,1,MPI_INTEGER,ista_grid,1,MPI_INTEGER,mpi_comm_comp,ierr)
Expand Down
2 changes: 1 addition & 1 deletion sorc/ncep_post.fd/INITPOST_NETCDF.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -889,7 +889,7 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
call read_netcdf_3d_para(ncid3d,im,jm,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,cfr(ista_2l,jsta_2l,1),lm)
else
VarName='cldfra'
VarName='cldfra_bl'
Comment thread
SamuelTrahanNOAA marked this conversation as resolved.
Outdated
call read_netcdf_3d_para(ncid2d,im,jm,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,cfr(ista_2l,jsta_2l,1),lm)
endif
Expand Down