Skip to content

remove MAX_PRATE_ON_SURFACE, add ACM_ACPCP_ON_SURFACE for hafs_nosat#604

Merged
WenMeng-NOAA merged 3 commits into
NOAA-EMC:developfrom
LinZhu-NOAA:upp_control
Dec 16, 2022
Merged

remove MAX_PRATE_ON_SURFACE, add ACM_ACPCP_ON_SURFACE for hafs_nosat#604
WenMeng-NOAA merged 3 commits into
NOAA-EMC:developfrom
LinZhu-NOAA:upp_control

Conversation

@LinZhu-NOAA
Copy link
Copy Markdown
Contributor

Remove the MAX_PRATE_ON_SURFACE and add the ACM_ACPCP_ON_SURFACE for hafs_nosat control file,

Files changed:
parm/postcntrl_hafs_nosat.xml
parm/postxconfig-NT-hafs_nosat.txt

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@LinZhu-NOAA Would you mind to combing another small update in your PR? Please update modulefiles/wcoss2.lua as:
change
g2tmpl_ver=os.getenv("g2tmpl_ver") or "1.10.0"
into
g2tmpl_ver=os.getenv("g2tmpl_ver") or "1.10.2"

Thanks!

@LinZhu-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA The modulefiles/wcoss2.lua is updated the g2tmpl_ver to 1.10.2. Thanks!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@LinZhu-NOAA Can you sync your branch with the latest changes from upstream/develop so I will process this PR? The procedure can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

@LinZhu-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA The upp_crontrl branch is synced with the latest changes from upstream/develop following the instruction. Please let me know if there is any problems. Thanks!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@LinZhu-NOAA The UPP standalone test case with model history files from you is at
/u/wen.meng/ptmp/fv3hafs_2022092800 on Cactus
With g2tmpl upgraded to 1.10.2, you may expect hafs's generating process id (135) encoded in grib2 file as:

wen.meng@clogin02 fv3hafs_2022092800$ wgrib2 HURPRS09.tm00 -processid|tail
679:765265688:background generating process=0 forecast generating process=135
680:767413180:background generating process=0 forecast generating process=135
681:768834179:background generating process=0 forecast generating process=135

https://www.nco.ncep.noaa.gov/pmb/docs/on388/tablea.html
Please verify this hafs grib2 file and let me know if you see any discrepancy from your test.

@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Dec 16, 2022
@LinZhu-NOAA
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA /u/wen.meng/ptmp/fv3hafs_2022092800/HURPRS09.tm00 looks okay to me. Thanks!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2, Hera and Orion. The baseline of hafs including in and out data will be created with this PR.

@WenMeng-NOAA WenMeng-NOAA merged commit 6212162 into NOAA-EMC:develop Dec 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Baseline Change The baselines of the UPP regression tests are changed. HAFS Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Upgrade g2tmpl to 1.10.2 on WCOSS2 update hafs control file for hafs_nosat

2 participants