Skip to content

Small updates for RRFS snow variables #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 6 commits into from
Dec 19, 2022
Merged

Small updates for RRFS snow variables #601

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3fb1d18
Bug fixes for RRFS snow accumulation variables.
EricJames-NOAA Dec 2, 2022
b3f3349
Adding check to only divide var density snow by 1000 if we are dealin…
EricJames-NOAA Dec 5, 2022
b8d5bd9
Bug fix for missing endif
EricJames-NOAA Dec 5, 2022
8df3d87
Updating RRFS control files to make MAXUVV and MAXDVV GRIB2 labeling …
EricJames-NOAA Dec 16, 2022
2c708c2
Correcting missed MAXUVV / MAXDVV fields in NATLEV files.
EricJames-NOAA Dec 16, 2022
91df5f2
Merge remote-tracking branch 'origin/develop' into rrfs_snow_vars
EricJames-NOAA Dec 16, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions parm/fv3lam.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1703,7 +1703,7 @@
</param>

<param>
<shortname>MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXUVV</pname>
<table_info>NCEP</table_info>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
Expand All @@ -1712,7 +1712,7 @@
</param>

<param>
<shortname>MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXDVV</pname>
<table_info>NCEP</table_info>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
Expand Down Expand Up @@ -2074,7 +2074,7 @@
</param>

<param>
<shortname>MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXUVV</pname>
<table_info>NCEP</table_info>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
Expand All @@ -2083,7 +2083,7 @@
</param>

<param>
<shortname>MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXDVV</pname>
<table_info>NCEP</table_info>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
Expand Down
13 changes: 9 additions & 4 deletions parm/fv3lam_rrfs.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -534,6 +534,11 @@
<scale>6.0</scale>
</param>

<param>
<shortname>GSD_ACM_SNOD_ON_SURFACE</shortname>
<scale>5.0</scale>
</param>

<param>
<shortname>SMDRY_ON_SURFACE</shortname>
<pname>SMDRY</pname>
Expand Down Expand Up @@ -1720,14 +1725,14 @@
</param>

<param>
<shortname>MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXUVV</pname>
<table_info>NCEP</table_info>
<scale>-3.0</scale>
</param>

<param>
<shortname>MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXDVV</pname>
<table_info>NCEP</table_info>
<scale>-3.0</scale>
Expand Down Expand Up @@ -2161,14 +2166,14 @@
</param>

<param>
<shortname>MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXUVV</pname>
<table_info>NCEP</table_info>
<scale>-3.0</scale>
</param>

<param>
<shortname>MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<pname>MAXDVV</pname>
<table_info>NCEP</table_info>
<scale>-3.0</scale>
Expand Down
12 changes: 6 additions & 6 deletions parm/post_avblflds.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3678,30 +3678,30 @@

<param>
<post_avblfldidx>423</post_avblfldidx>
<shortname>MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<longname>hourly maximum Upward Vertical Velocity between 100-1000hpa</longname>
<pdstmpl>tmpl4_8</pdstmpl>
<pname>MAXUVV</pname>
<table_info>NCEP</table_info>
<stats_proc>MAX</stats_proc>
<fixed_sfc1_type>spec_pres_above_grnd</fixed_sfc1_type>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
<level>10000.</level>
<fixed_sfc2_type>spec_pres_above_grnd</fixed_sfc2_type>
<fixed_sfc2_type>isobaric_sfc</fixed_sfc2_type>
<level2>100000.</level2>
<scale>-3.0</scale>
</param>

<param>
<post_avblfldidx>424</post_avblfldidx>
<shortname>MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa</shortname>
<shortname>MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa</shortname>
<longname>hourly maximum Downward Vertical Velocity between 100-1000hpa</longname>
<pdstmpl>tmpl4_8</pdstmpl>
<pname>MAXDVV</pname>
<stats_proc>MAX</stats_proc>
<table_info>NCEP</table_info>
<fixed_sfc1_type>spec_pres_above_grnd</fixed_sfc1_type>
<fixed_sfc1_type>isobaric_sfc</fixed_sfc1_type>
<level>10000.</level>
<fixed_sfc2_type>spec_pres_above_grnd</fixed_sfc2_type>
<fixed_sfc2_type>isobaric_sfc</fixed_sfc2_type>
<level2>100000.</level2>
<scale>-3.0</scale>
</param>
Expand Down
8 changes: 4 additions & 4 deletions parm/postxconfig-NT-fv3lam.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9009,7 +9009,7 @@ spec_hgt_lvl_above_grnd
?
?
423
MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Upward Vertical Velocity between 100-1000hpa
1
tmpl4_8
Expand Down Expand Up @@ -9046,7 +9046,7 @@ isobaric_sfc
?
?
424
MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Downward Vertical Velocity between 100-1000hpa
1
tmpl4_8
Expand Down Expand Up @@ -10801,7 +10801,7 @@ surface
?
?
423
MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Upward Vertical Velocity between 100-1000hpa
1
tmpl4_8
Expand Down Expand Up @@ -10838,7 +10838,7 @@ isobaric_sfc
?
?
424
MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Downward Vertical Velocity between 100-1000hpa
1
tmpl4_8
Expand Down
63 changes: 50 additions & 13 deletions parm/postxconfig-NT-fv3lam_rrfs.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
2
241
283
284
PRSLEV
32769
ncep_nco
Expand Down Expand Up @@ -2681,6 +2681,43 @@ surface
?
?
?
725
GSD_ACM_SNOD_ON_SURFACE
?
1
tmpl4_8
ASNOW
?
ACM
surface
0
?
0
?
?
0
?
0
?
?
?
0
0.0
0
0.0
?
0
0.0
0
0.0
1
5.0
0
0
0
?
?
?
232
SMDRY_ON_SURFACE
?
Expand Down Expand Up @@ -9305,19 +9342,19 @@ spec_hgt_lvl_above_grnd
?
?
423
MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Upward Vertical Velocity between 100-1000hpa
1
tmpl4_8
MAXUVV
NCEP
MAX
spec_pres_above_grnd
isobaric_sfc
0
?
1
10000.
spec_pres_above_grnd
isobaric_sfc
0
?
1
Expand All @@ -9342,19 +9379,19 @@ spec_pres_above_grnd
?
?
424
MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Downward Vertical Velocity between 100-1000hpa
1
tmpl4_8
MAXDVV
NCEP
MAX
spec_pres_above_grnd
isobaric_sfc
0
?
1
10000.
spec_pres_above_grnd
isobaric_sfc
0
?
1
Expand Down Expand Up @@ -11689,19 +11726,19 @@ surface
?
?
423
MAX_MAXUVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXUVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Upward Vertical Velocity between 100-1000hpa
1
tmpl4_8
MAXUVV
NCEP
MAX
spec_pres_above_grnd
isobaric_sfc
0
?
1
10000.
spec_pres_above_grnd
isobaric_sfc
0
?
1
Expand All @@ -11726,19 +11763,19 @@ spec_pres_above_grnd
?
?
424
MAX_MAXDVV_ON_SPEC_PRES_LVL_ABOVE_GRND_100-1000hpa
MAX_MAXDVV_ON_ISOBARIC_SFC_100-1000hpa
hourly maximum Downward Vertical Velocity between 100-1000hpa
1
tmpl4_8
MAXDVV
NCEP
MAX
spec_pres_above_grnd
isobaric_sfc
0
?
1
10000.
spec_pres_above_grnd
isobaric_sfc
0
?
1
Expand Down
28 changes: 26 additions & 2 deletions sorc/ncep_post.fd/INITPOST_NETCDF.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
wh, qqg, ref_10cm, qqnifa, qqnwfa, avgpmtf, avgozcon, aextc55, taod5503d

use vrbls2d, only: f, pd, fis, pblh, ustar, z0, ths, qs, twbs, qwbs, avgcprate, &
cprate, avgprec, prec, lspa, sno, si, cldefi, th10, q10, tshltr, pshltr, &
cprate, avgprec, prec, lspa, sno, sndepac, si, cldefi, th10, q10, tshltr, pshltr, &
tshltr, albase, avgalbedo, avgtcdc, czen, czmean, mxsnal, landfrac, radot, sigt4, &
cfrach, cfracl, cfracm, avgcfrach, qshltr, avgcfracl, avgcfracm, cnvcfr, &
islope, cmc, grnflx, vegfrc, acfrcv, ncfrcv, acfrst, ncfrst, ssroff, &
Expand Down Expand Up @@ -165,6 +165,7 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
real*8, allocatable :: pm2d(:,:), pi2d(:,:)
real, allocatable :: tmp(:)
real :: buf(ista_2l:iend_2u,jsta_2l:jend_2u)
real :: buf2(ista_2l:iend_2u,jsta_2l:jend_2u)
real :: buf3d(ista_2l:iend_2u,jsta_2l:jend_2u,lm)
real :: chem_2d(ista_2l:iend_2u,jsta_2l:jend_2u)
real :: chemT(ista_2l:iend_2u,jsta_2l:jend_2u,lm)
Expand Down Expand Up @@ -2783,13 +2784,36 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
smstav(i,j) = buf(i,j)
enddo
enddo
VarName='accswe_land'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,buf)
VarName='accswe_ice'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,buf2)
!$omp parallel do private(i,j)
do j = jsta_2l, jend_2u
do i=ista,iend
acsnow(i,j) = buf(i,j) + buf2(i,j)
enddo
enddo
VarName='snacc_land'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,buf)
VarName='snacc_ice'
call read_netcdf_2d_para(ncid2d,ista,ista_2l,iend,iend_2u,jsta,jsta_2l,jend,jend_2u, &
spval,VarName,buf2)
!$omp parallel do private(i,j)
do j = jsta_2l, jend_2u
do i=ista,iend
sndepac(i,j) = buf(i,j) + buf2(i,j)
enddo
enddo
!$omp parallel do private(i,j)
do j=jsta_2l,jend_2u
do i=ista_2l,iend_2u
! smstav(i,j) = spval ! GFS does not have soil moisture availability
! smstot(i,j) = spval ! GFS does not have total soil moisture
sfcevp(i,j) = spval ! GFS does not have accumulated surface evaporation
acsnow(i,j) = spval ! GFS does not have averaged accumulated snow
acsnom(i,j) = spval ! GFS does not have snow melt
! sst(i,j) = spval ! GFS does not have sst????
thz0(i,j) = ths(i,j) ! GFS does not have THZ0, use THS to substitute
Expand Down
14 changes: 11 additions & 3 deletions sorc/ncep_post.fd/SURFCE.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,13 +469,21 @@ SUBROUTINE SURFCE
cfld=cfld+1
fld_info(cfld)%ifld=IAVBLFLD(IGET(725))
fld_info(cfld)%ntrange=1
fld_info(cfld)%tinvstat=IFHR-ID(18)
fld_info(cfld)%tinvstat=IFHR
!$omp parallel do private(i,j,ii,jj)
do j=1,jend-jsta+1
jj = jsta+j-1
do i=1,iend-ista+1
ii = ista+i-1
datapd(i,j,cfld) = SNDEPAC(ii,jj)
if(SNDEPAC(ii,jj)<spval) then
if(MODELNAME=='FV3R') then
datapd(i,j,cfld) = SNDEPAC(ii,jj)/(1E3)
else
datapd(i,j,cfld) = SNDEPAC(ii,jj)
endif
else
datapd(i,j,cfld) = spval
endif
enddo
enddo
endif
Expand Down Expand Up @@ -3359,7 +3367,7 @@ SUBROUTINE SURFCE
cfld=cfld+1
fld_info(cfld)%ifld=IAVBLFLD(IGET(035))
fld_info(cfld)%ntrange=1
fld_info(cfld)%tinvstat=IFHR-ID(18)
fld_info(cfld)%tinvstat=IFHR
!$omp parallel do private(i,j,ii,jj)
do j=1,jend-jsta+1
jj = jsta+j-1
Expand Down