Skip to content

Output hourly PM2.5 and O3 for AQM#591

Merged
WenMeng-NOAA merged 18 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:post_aqm
Dec 14, 2022
Merged

Output hourly PM2.5 and O3 for AQM#591
WenMeng-NOAA merged 18 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:post_aqm

Conversation

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Nov 14, 2022

The main changes are:

  • Output hourly averaged PM 2.5 and O3 concentration
  • Remove instant PM2.5 calculation
  • Add new aqm control files for processing AQM model
  • Remove fv3lam_cmaq control files
  • Add new UPP variable entire atmosphere AOD
  • Add AQM control file which include hourly averaged PM 2.5, O3 concentration, HPBL and entire atmosphere AOD
  • Add modification of spack CI test from Alex Richert

@WenMeng-NOAA WenMeng-NOAA linked an issue Nov 15, 2022 that may be closed by this pull request
Comment thread sorc/ncep_post.fd/MDLFLD.f Outdated
Copy link
Copy Markdown

@KaiWang-NOAA KaiWang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Wen, I only have a minor change request for MDLFLD.f. We don't need to do the unit conversion for AVGPMTF.

Merge remote-tracking branch 'upstream/develop' into post_aqm
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@JianpingHuang-NOAA @KaiWang-NOAA @Ho-ChunHuang-NOAA
I add some changes for outputting two additional new variables as:

549:171723272:d=2022112706:AOTK:entire atmosphere (considered as a single layer):60 hour fcst:aerosol=Ozone:aerosol_size <0:
551:172312604:d=2022112706:HPBL:surface:60 hour fcst:

The test results are at /u/wen.meng/ptmp/post_aqm_2022112706. Can you verify them?

@JianpingHuang-NOAA
Copy link
Copy Markdown

JianpingHuang-NOAA commented Dec 8, 2022 via email

@Ho-ChunHuang-NOAA
Copy link
Copy Markdown

@JianpingHuang-NOAA

I do not understand the task you want me to perform. Please clarify;

Do you want me to test read on the
aqm.t06z.pm25.f##.793.grib2
aqm.t06z.awpozcon.f##793.grib2
aqm.t06z.max_8hr_o3.793.grib2
aqm.t06z.ave_24hr_pm25.793.grib

of /lfs/h2/emc/ptmp/jianping.huang/emc.para/com/aqm/v7.0/aqm.v7.0.c22.20221206/06 ?

The timestamp marked is around Dec 8 04:55.

@JianpingHuang-NOAA
Copy link
Copy Markdown

JianpingHuang-NOAA commented Dec 8, 2022 via email

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@JianpingHuang-NOAA @Ho-ChunHuang-NOAA
The new test from c22 model files is at /u/wen.meng/ptmp/post_aqm_2022120606-c22 on cactus

I rename c20 test as /u/wen.meng/ptmp/post_aqm_2022112706-c20 on cactus

@Ho-ChunHuang-NOAA
Copy link
Copy Markdown

Ho-ChunHuang-NOAA commented Dec 8, 2022 via email

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@Ho-ChunHuang-NOAA Please check the following two directories:

The new test from c22 model files is at /u/wen.meng/ptmp/post_aqm_2022120606-c22 on cactus
I rename c20 test as /u/wen.meng/ptmp/post_aqm_2022112706-c20 on cactus

@Ho-ChunHuang-NOAA
Copy link
Copy Markdown

Ho-ChunHuang-NOAA commented Dec 8, 2022 via email

and HPBL in aqm control files; 3)remove fv3lam_cmaq control files.
@WenMeng-NOAA WenMeng-NOAA added the Ready for Review This PR is ready for code review. label Dec 12, 2022
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@JianpingHuang-NOAA @KaiWang-NOAA
The changes for aod and HPBL were committed. Please review the whole PR so I can proceed the merging process.
The UPP test case can be found at /u/wen.meng/ptmp/post_aqm_2022112706 on dogwood.
Thanks!

Comment thread parm/post_avblflds.xml Outdated
Comment thread sorc/ncep_post.fd/MDLFLD.f Outdated
Copy link
Copy Markdown

@KaiWang-NOAA KaiWang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WenMeng-NOAA In addition to the two minor comments I had earlier. There seems to be some issue with the sample output in /u/wen.meng/ptmp/post_aqm_2022112706/CMAQ60.tm00 for HPBL.

The degrib2 CMAQ60.tm00 shows "PARAMETER = UNKNOWN 0 3 18" for the variable name while the variable name (i.e., HPBL) seems to be ok when using wgrib2 to display the file. The values for HPBL are reasonable, i.e.,
"MIN= 18.29436111 AVE= 676.61242676 MAX= 3434.37426758"

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@WenMeng-NOAA In addition to the two minor comments I had earlier. There seems to be some issue with the sample output in /u/wen.meng/ptmp/post_aqm_2022112706/CMAQ60.tm00 for HPBL.

The degrib2 CMAQ60.tm00 shows "PARAMETER = UNKNOWN 0 3 18" for the variable name while the variable name (i.e., HPBL) seems to be ok when using wgrib2 to display the file. The values for HPBL are reasonable, i.e., "MIN= 18.29436111 AVE= 676.61242676 MAX= 3434.37426758"

@KaiWang-NOAA Thanks for catching this. There are two HPBL in grib2 table. The degrib2 can't display the one with 18. We might consider to unify them in the future. For this case, I updated AQM control files via using NCEP local number 196. The new test case can be found at /u/wen.meng/ptmp/post_aqm_2022112706 on dogwood. Please verify it.

Comment thread parm/post_avblflds.xml Outdated
@KaiWang-NOAA
Copy link
Copy Markdown

@WenMeng-NOAA In addition to the two minor comments I had earlier. There seems to be some issue with the sample output in /u/wen.meng/ptmp/post_aqm_2022112706/CMAQ60.tm00 for HPBL.
The degrib2 CMAQ60.tm00 shows "PARAMETER = UNKNOWN 0 3 18" for the variable name while the variable name (i.e., HPBL) seems to be ok when using wgrib2 to display the file. The values for HPBL are reasonable, i.e., "MIN= 18.29436111 AVE= 676.61242676 MAX= 3434.37426758"

@KaiWang-NOAA Thanks for catching this. There are two HPBL in grib2 table. The degrib2 can't display the one with 18. We might consider to unify them in the future. For this case, I updated AQM control files via using NCEP local number 196. The new test case can be found at /u/wen.meng/ptmp/post_aqm_2022112706 on dogwood. Please verify it.

Thanks for fixing the issue! The new output looks good to me now.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@KaiWang-NOAA I added the changes based your comments about the aod ouput. The new test case is at
/u/wen.meng/ptmp/post_aqm_2022112706
Please verify it.

@KaiWang-NOAA
Copy link
Copy Markdown

@KaiWang-NOAA I added the changes based your comments about the aod ouput. The new test case is at /u/wen.meng/ptmp/post_aqm_2022112706 Please verify it.

@WenMeng-NOAA Thank you for adding the changes quickly! The new output looks good to me now.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

@JianpingHuang-NOAA and @KaiWang-NOAA I will start the PR testing and merging process soon. Please let me know if you will additional comments.

@WenMeng-NOAA WenMeng-NOAA linked an issue Dec 13, 2022 that may be closed by this pull request
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

The UPP RT tests were completed on WCOSS2. No changed results.

Copy link
Copy Markdown
Contributor

@AlexanderRichert-NOAA AlexanderRichert-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI looks good.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Dec 14, 2022
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

The UPP RT tests were completed on Hera and Orion. No baseline changes are needed.

Comment thread sorc/ncep_post.fd/MDLFLD.f
Copy link
Copy Markdown
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest adding one line comment in MDLFLD.f that new AQ variables are computed as hourly average only.

Great job cleaning up 3D local variables in INITPOST_NETCDF.f

@WenMeng-NOAA WenMeng-NOAA merged commit 792a398 into NOAA-EMC:develop Dec 14, 2022
@WenMeng-NOAA WenMeng-NOAA deleted the post_aqm branch June 26, 2023 11:47
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
* fixes for land coupling
* work to support external land component side-by-side config
* fix issue with ort dbg test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AQM No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CI tests failed on github Hourly-averaged chemical fields for UFS-AQM

6 participants