Miscellaneous GSL updates by EricJames-NOAA · Pull Request #582 · NOAA-EMC/UPP

EricJames-NOAA · 2022-10-26T20:57:41Z

This PR includes assorted changes from NOAA-GSL RRFS_dev branch. The changes include:

(1) Enabling of QPF comparisons with average recurrence intervals (ARIs) in RRFS
(2) Bug fix for calculation of storm-relative helicity from Edward Colon
(3) Addition of a missing value check for updraft helicity
(4) Enabling soil moisture availability output in RRFS (wet1)
(5) Fixing GRIB2 encoding for some time-average variables which were causing errors for some wgrib2 versions

Regression tests were carried out on Hera; the only differences seen are those expected from the SRH bug fix from Edward Colon, which also affects some RTMA diagnostics variables.

WenMeng-NOAA · 2022-10-28T14:30:56Z

@EricJames-NOAA Can you add change logs in all source code files you modified under sorc/ncep_post.fd/?

WenMeng-NOAA · 2022-10-28T15:26:47Z

@EricJames-NOAA Do you have any new RRFS model output files in netcdf for my UPP standalone test?

EricJames-NOAA · 2022-10-28T15:43:51Z

@WenMeng-NOAA yes on Jet...I can provide the path. If you can't access Jet I can copy to Hera.

/lfs4/BMC/wrfruc/ejames/RRFS/stmp/tmpnwprd/RRFS_conus_3km/2022102713/fcst_fv3lam

WenMeng-NOAA · 2022-10-28T18:12:53Z

@WenMeng-NOAA yes on Jet...I can provide the path. If you can't access Jet I can copy to Hera.

/lfs4/BMC/wrfruc/ejames/RRFS/stmp/tmpnwprd/RRFS_conus_3km/2022102713/fcst_fv3lam

@EricJames-NOAA Got it. Thanks!

WenMeng-NOAA · 2022-10-31T14:14:30Z

@EricJames-NOAA Are ffg_*grib2 files required for generating GWLOWS products 912-922? If yes, can you provide the location?

EricJames-NOAA · 2022-10-31T17:13:34Z

@EricJames-NOAA Are ffg_*grib2 files required for generating GWLOWS products 912-922? If yes, can you provide the location?

@WenMeng-NOAA yes they are. We have the FFG GRIB2 files on Jet for all of our realtime systems in NOAA GSL:

/public/data/grids/ncep/ffg/grib2

I'm not sure if they are available on other machines...but the code is set up to skip these fields if the FFG files are not available.

WenMeng-NOAA · 2022-10-31T19:18:15Z

@EricJames-NOAA I conducted the UPP standalone test with new model history files you provided. My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. There are only 801 records in PRSLEV dataset. I also saw the error message in PRSLEV file dump as:
** ERROR bad grib message: Statistical Processing bad n=0 **
Can you take a look at that?

EricJames-NOAA · 2022-10-31T20:06:44Z

@EricJames-NOAA I conducted the UPP standalone test with new model history files you provided. My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. There are only 801 records in PRSLEV dataset. I also saw the error message in PRSLEV file dump as: ** ERROR bad grib message: Statistical Processing bad n=0 ** Can you take a look at that?

@WenMeng-NOAA thanks for your test. I don't see that error using wgrib2 version 0.1.9.6a. Let me see if I can get rid of that error message.

EricJames-NOAA · 2022-10-31T20:22:07Z

@EricJames-NOAA I conducted the UPP standalone test with new model history files you provided. My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. There are only 801 records in PRSLEV dataset. I also saw the error message in PRSLEV file dump as: ** ERROR bad grib message: Statistical Processing bad n=0 ** Can you take a look at that?

@WenMeng-NOAA thanks for your test. I don't see that error using wgrib2 version 0.1.9.6a. Let me see if I can get rid of that error message.

@WenMeng-NOAA looks like there is a section of SURFCE.f which uses the same IGET value (922) as my new average recurrence interval exceedance (lines 5636-5647), but I didn't see that IGET value defined in any post_avblflds.xml prior to my code change. Do you have a recommendation for how to correct this issue?

WenMeng-NOAA · 2022-10-31T21:06:32Z

@EricJames-NOAA I conducted the UPP standalone test with new model history files you provided. My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. There are only 801 records in PRSLEV dataset. I also saw the error message in PRSLEV file dump as: ** ERROR bad grib message: Statistical Processing bad n=0 ** Can you take a look at that?

@WenMeng-NOAA thanks for your test. I don't see that error using wgrib2 version 0.1.9.6a. Let me see if I can get rid of that error message.

@WenMeng-NOAA looks like there is a section of SURFCE.f which uses the same IGET value (922) as my new average recurrence interval exceedance (lines 5636-5647), but I didn't see that IGET value defined in any post_avblflds.xml prior to my code change. Do you have a recommendation for how to correct this issue?

@EricJames-NOAA Thanks for catching this undefined UPP ID issue. It seems the CD10 and CH10 are not generated in any NCEP products right now. You may change 922 to 924 in the section starting at line 5636.

…in SURFCE.

EricJames-NOAA · 2022-10-31T21:24:45Z

@EricJames-NOAA I conducted the UPP standalone test with new model history files you provided. My test is at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. There are only 801 records in PRSLEV dataset. I also saw the error message in PRSLEV file dump as: ** ERROR bad grib message: Statistical Processing bad n=0 ** Can you take a look at that?

@WenMeng-NOAA thanks for your test. I don't see that error using wgrib2 version 0.1.9.6a. Let me see if I can get rid of that error message.

@WenMeng-NOAA looks like there is a section of SURFCE.f which uses the same IGET value (922) as my new average recurrence interval exceedance (lines 5636-5647), but I didn't see that IGET value defined in any post_avblflds.xml prior to my code change. Do you have a recommendation for how to correct this issue?

@EricJames-NOAA Thanks for catching this undefined UPP ID issue. It seems the CD10 and CH10 are not generated in any NCEP products right now. You may change 922 to 924 in the section starting at line 5636.

@WenMeng-NOAA thanks. I think my latest commit with this change gets rid of the error.

WenMeng-NOAA · 2022-10-31T22:20:40Z

@EricJames-NOAA Great! I updated my UPP version and reran the test at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. Now PRSLEV dataset looks good to me. Can you take a look my test and let me know if there are any unexpected results.

EricJames-NOAA · 2022-10-31T22:41:59Z

@EricJames-NOAA Great! I updated my UPP version and reran the test at /scratch1/NCEPDEV/stmp2/Wen.Meng/rrfs_2022102713. Now PRSLEV dataset looks good to me. Can you take a look my test and let me know if there are any unexpected results.

@WenMeng-NOAA it looks good to me! Thanks!

WenMeng-NOAA · 2022-11-01T14:09:11Z

The UPP RT tests were conducted on Hera. The changed results for RTMA are:

[Wen.Meng@hfe03 ~/stmp2]$ cat rtma_2020113000/WRFTWO.GrbF00.diff
163:128780657:E3KH:level of free convection:rpn_corr=0.999997:rpn_rms=25.1385
164:128988849:STPC:level of free convection:rpn_corr=0.95108:rpn_rms=0.0200462

@EricJames-NOAA and @EdwardColon-NOAA I would think the above changes come from the bug fix in storm-relative helicity. Could you confirm that?

EricJames-NOAA · 2022-11-01T19:27:52Z

The UPP RT tests were conducted on Hera. The changed results for RTMA are:
[Wen.Meng@hfe03 ~/stmp2]$ cat rtma_2020113000/WRFTWO.GrbF00.diff
163:128780657:E3KH:level of free convection:rpn_corr=0.999997:rpn_rms=25.1385
164:128988849:STPC:level of free convection:rpn_corr=0.95108:rpn_rms=0.0200462
@EricJames-NOAA and @EdwardColon-NOAA I would think the above changes come from the bug fix in storm-relative helicity. Could you confirm that?

@WenMeng-NOAA I confirm it! Yes, those are the fields we expect to be affected by the storm relative helicity bug fix.

…est RRFS

WenMeng-NOAA · 2022-11-03T14:06:07Z

@EricJames-NOAA Can you sync your branch with upstream/develop? The procedure can be found at https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

WenMeng-NOAA · 2022-11-03T22:01:59Z

The UPP RT tests were completed on WCOSS2, Hera and Orion. The baseline for RTMA will be recreated with this PR.

EricJames-NOAA added 5 commits October 20, 2022 20:42

Miscellaneous GSL changes / bug fixes.

8548751

Including postxconfig file

29246f4

Bug fix for if statement

05c5e32

Reverting change to max precip rate encoding.

2caab74

Minor bug fix.

54ecccf

EricJames-NOAA requested a review from WenMeng-NOAA as a code owner October 26, 2022 20:57

Merge remote-tracking branch 'origin/develop' into gsl_misc

b7b61da

WenMeng-NOAA linked an issue Oct 27, 2022 that may be closed by this pull request

Miscellaneous UPP updates from GSL #576

Closed

WenMeng-NOAA added the RRFS label Oct 27, 2022

WenMeng-NOAA requested a review from EdwardColon-NOAA October 28, 2022 14:24

WenMeng-NOAA requested a review from ericaligo-NOAA October 28, 2022 15:00

Adding change log entries for code modifications from GSL RRFS_dev

ea8b65d

WenMeng-NOAA reviewed Oct 31, 2022

View reviewed changes

Comment thread parm/post_avblflds.xml

Fixing error with multiple variables using the same IGET value (922) …

a25ab21

…in SURFCE.

WenMeng-NOAA reviewed Nov 1, 2022

View reviewed changes

Comment thread sorc/ncep_post.fd/INITPOST_NETCDF.f Outdated

EricJames-NOAA added 3 commits November 1, 2022 20:24

Getting rid of unnecessary IF statement

d1fffeb

Commenting out setting smstav to missing

e0e6a3d

Changing name of soil moisture availability to be consistent with lat…

90947f3

…est RRFS

WenMeng-NOAA reviewed Nov 2, 2022

View reviewed changes

Comment thread sorc/ncep_post.fd/SURFCE.f Outdated

Adding check for model type before multiplying MSTAV by 100

42c3b1f

WenMeng-NOAA reviewed Nov 2, 2022

View reviewed changes

Comment thread sorc/ncep_post.fd/SURFCE.f

WenMeng-NOAA reviewed Nov 3, 2022

View reviewed changes

Comment thread sorc/ncep_post.fd/SURFCE.f

WenMeng-NOAA added 3DRTMA Ready for Review This PR is ready for code review. Baseline Change The baselines of the UPP regression tests are changed. labels Nov 3, 2022

EricJames-NOAA added 2 commits November 3, 2022 15:30

Adding definition for ITSRFC in GRIB2 bug fix sections.

b1b2b33

Merge remote-tracking branch 'upstream/develop' into gsl_misc

0ee5b60

WenMeng-NOAA approved these changes Nov 3, 2022

View reviewed changes

WenMeng-NOAA merged commit 5cba986 into NOAA-EMC:develop Nov 3, 2022

WenMeng-NOAA mentioned this pull request Nov 3, 2022

Updates in develop branch since 06/2022 #518

Closed

WenMeng-NOAA mentioned this pull request Nov 28, 2022

Enable output of smoke and dust variables from RRFS #593

Merged

Conversation

EricJames-NOAA commented Oct 26, 2022

Uh oh!

WenMeng-NOAA commented Oct 28, 2022

Uh oh!

WenMeng-NOAA commented Oct 28, 2022

Uh oh!

EricJames-NOAA commented Oct 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

WenMeng-NOAA commented Oct 28, 2022

Uh oh!

WenMeng-NOAA commented Oct 31, 2022

Uh oh!

EricJames-NOAA commented Oct 31, 2022

Uh oh!

Uh oh!

WenMeng-NOAA commented Oct 31, 2022

Uh oh!

EricJames-NOAA commented Oct 31, 2022

Uh oh!

EricJames-NOAA commented Oct 31, 2022

Uh oh!

WenMeng-NOAA commented Oct 31, 2022

Uh oh!

EricJames-NOAA commented Oct 31, 2022

Uh oh!

WenMeng-NOAA commented Oct 31, 2022

Uh oh!

EricJames-NOAA commented Oct 31, 2022

Uh oh!

WenMeng-NOAA commented Nov 1, 2022

Uh oh!

Uh oh!

EricJames-NOAA commented Nov 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

WenMeng-NOAA commented Nov 3, 2022

Uh oh!

WenMeng-NOAA commented Nov 3, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

EricJames-NOAA commented Oct 28, 2022 •

edited

Loading