Skip to content

Add nitrate AOD look-up table and AOD calculation for UFS-Aerosols model#579

Merged
WenMeng-NOAA merged 5 commits into
NOAA-EMC:developfrom
zhanglikate:ufs-aerosols-nitrate
Oct 27, 2022
Merged

Add nitrate AOD look-up table and AOD calculation for UFS-Aerosols model#579
WenMeng-NOAA merged 5 commits into
NOAA-EMC:developfrom
zhanglikate:ufs-aerosols-nitrate

Conversation

@zhanglikate
Copy link
Copy Markdown
Contributor

1)Add nitrate look-up table based on NASA optics_NI.v2_5.nc.
2)Implement the nitrate AOD calculation for UFS-Aerosols model, which is also included into the total AOD.

2)Implement the nitrate AOD calculation for UFS-Aerosols model, which is also included into the total AOD.
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@zhanglikate Can you sync your branch with the latest commit in UPP develop branch? The procedure can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

@zhanglikate
Copy link
Copy Markdown
Contributor Author

@zhanglikate Can you sync your branch with the latest commit in UPP develop branch? The procedure can be found at
https://github.com/NOAA-EMC/UPP/wiki/UPP-Code-Development#update-your-branch-at-your-fork-with-branch-develop-at-authoritative-repository

@WenMeng-NOAA Finished. Thanks.

Comment thread parm/post_avblflds.xml
@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. GFSV17 labels Oct 26, 2022
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@zhanglikate I conducted the UPP standalone test with model history files provided by you. The results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_gfs_2016071500. Can you verify my test? Thanks!

@zhanglikate
Copy link
Copy Markdown
Contributor Author

@zhanglikate I conducted the UPP standalone test with model history files provided by you. The results are at /scratch1/NCEPDEV/stmp2/Wen.Meng/post_gfs_2016071500. Can you verify my test? Thanks!

@WenMeng-NOAA They are bit for bit identical. Thanks.

@WenMeng-NOAA WenMeng-NOAA added the No Baseline Change No baseline of the UPP regression tests are made. label Oct 26, 2022
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on WCOSS2 and Hera. No baseline update is needed for this PR.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on Orion.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@zhanglikate Can you sync your branch with upstream/develop one more time? Thanks!

@zhanglikate
Copy link
Copy Markdown
Contributor Author

@zhanglikate Can you sync your branch with upstream/develop one more time? Thanks!

@WenMeng-NOAA Finished. Thanks.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP RT tests were completed on Hera.

@WenMeng-NOAA WenMeng-NOAA merged commit b81de7f into NOAA-EMC:develop Oct 27, 2022
Copy link
Copy Markdown
Contributor

@lipan-NOAA lipan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Copy link
Copy Markdown
Contributor

@lipan-NOAA lipan-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

GFSV17 No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants