Skip to content

Fix an out-of-bounds access in CALCAPE2 #555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
WenMeng-NOAA merged 2 commits into from
Aug 26, 2022
Merged

Fix an out-of-bounds access in CALCAPE2 #555

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
870b932
Eliminate out-of-bounds access in CALCAPE2 with extreme atmospheric c…
SamuelTrahanNOAA Aug 25, 2022
7dd48dc
Author note update for CALCAPE2
SamuelTrahanNOAA Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions sorc/ncep_post.fd/UPP_PHYSICS.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -998,6 +998,7 @@ END SUBROUTINE CALCAPE
!> 2015-??-?? | S Moorthi | Optimization and threading
!> 2021-09-03 | J Meng | Modified to add 0-3km CAPE/CINS, LFC, effective helicity, downdraft CAPE, dendritic growth layer depth, ESP
!> 2021-09-01 | E Colon | Equivalent level height index for RTMA
!> 2022-08-27 | S Trahan | Fixed bug in CALCAPE2 where extreme atmospheric conditions cause an out-of-bounds access
!>
!> @author Russ Treadon W/NP2 @date 1993-02-10
SUBROUTINE CALCAPE2(ITYPE,DPBND,P1D,T1D,Q1D,L1D, &
Expand Down Expand Up @@ -1399,6 +1400,10 @@ SUBROUTINE CALCAPE2(ITYPE,DPBND,P1D,T1D,Q1D,L1D, &
ENDDO
ENDDO
!
!Ensure later calculations do not access LM+1
Comment thread
SamuelTrahanNOAA marked this conversation as resolved.
!
LEND=MIN(LEND,LM-1)
!
!reverse L order from bottom up for ESRH calculation
!
ESRHH = LCL
Expand Down