Skip to content

Move package config to top-level CMakeLists.txt#412

Merged
WenMeng-NOAA merged 2 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:upp_submodule
Nov 10, 2021
Merged

Move package config to top-level CMakeLists.txt#412
WenMeng-NOAA merged 2 commits into
NOAA-EMC:developfrom
DusanJovic-NOAA:upp_submodule

Conversation

@DusanJovic-NOAA
Copy link
Copy Markdown
Contributor

@DusanJovic-NOAA DusanJovic-NOAA commented Nov 5, 2021

Fixes #375.

@DusanJovic-NOAA DusanJovic-NOAA mentioned this pull request Nov 9, 2021
Merged
@WenMeng-NOAA WenMeng-NOAA added Ready for Review This PR is ready for code review. No Baseline Change No baseline of the UPP regression tests are made. enhancement New feature or request labels Nov 9, 2021
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Nov 10, 2021

@DusanJovic-NOAA Thanks for bringing the new feature to enhance inline post. Do you have suggestions on checking out
UPP branch or tag in FV3? Not all of commits in UPP develop branch are for inline post.

@WenMeng-NOAA WenMeng-NOAA requested a review from fossell November 10, 2021 13:37
@DusanJovic-NOAA
Copy link
Copy Markdown
Contributor Author

DusanJovic-NOAA commented Nov 10, 2021

@DusanJovic-NOAA Thanks for bringing the new feature to enhance inline post. Do you have suggestions on checking out UPP branch or tag in FV3? Not all of commits in UPP develop branch are for inline post.

We will update upp submodule in FV3 only when there's a bugfix or a new functionality that inline post in FV3 needs. Definitely not after every UPP commit.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Nov 10, 2021

@DusanJovic-NOAA Could you update VERSION to 10.0.11? I would like to recognize this PR as a new progress in UPP enhancement. Thanks!

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Nov 10, 2021

The UPP regression tests were successfully completed on WCOSS-Dell, WCOSS-Cray and Hera. No changed results were found. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit c939eae into NOAA-EMC:develop Nov 10, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Nov 10, 2021
Closed
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@jwolff-ncar
Add submission scripts for python scripts for hera specifically (NOAA…
adea9b4 
…-EMC#412)

* Add submission scripts for python scripts for hera specifically

* Updated scripts to remove hard coded paths and incorporate better practices and helpful usage statements

* Typo in usage statement - there are six command line arguements
@DusanJovic-NOAA DusanJovic-NOAA deleted the upp_submodule branch March 21, 2023 12:42
@DusanJovic-NOAA DusanJovic-NOAA restored the upp_submodule branch March 21, 2023 12:42
@DusanJovic-NOAA DusanJovic-NOAA deleted the upp_submodule branch September 15, 2023 11:58
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
@bensonr
updating atmos_cubed_sphere to 02c3bac on 20211015 (NOAA-EMC#412)
3772829
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

+1 more reviewer

@fossell fossell fossell approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

enhancement New feature or request No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Move cmake 'Package config' code to the top-level CMakeLists.txt

3 participants

@DusanJovic-NOAA @WenMeng-NOAA @fossell