Skip to content

Created formal fortran namelist for itag.#402

Merged
WenMeng-NOAA merged 13 commits into
NOAA-EMC:developfrom
kayeekayee:itag
Oct 27, 2021
Merged

Created formal fortran namelist for itag.#402
WenMeng-NOAA merged 13 commits into
NOAA-EMC:developfrom
kayeekayee:itag

Conversation

@kayeekayee
Copy link
Copy Markdown
Contributor

@kayeekayee kayeekayee commented Oct 4, 2021

This code changes have been test on Cheyenne and Hera.
It is bitwise for both EMC and DTC regression test.

Latest code has been tested on 2 locations:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/ (Hera)
/glade/scratch/kayee/UPP/itag/UFFDA (cheyenne)

These are the files being changed:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/UPP_itag
modified: scripts/run_upp
modified: sorc/ncep_post.fd/WRFPOST.f
modified: ush/gfs_nceppost.sh

The EMC regression test scripts are also modified for this code on Hera:
/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/EMC_RT_itag/jobs
run_post_fv3gfsv16_pe_test_HERA.sh
run_post_fv3gfsv16_HERA.sh
run_post_fv3gfs_pe_test_HERA.sh
run_post_fv3gfs_HERA.sh
run_post_rap_HERA.sh
run_post_rap_pe_test_HERA.sh
run_post_hrrr_HERA.sh
run_post_hrrr_pe_test_HERA.sh
run_post_nmmb_Grib2_HERA.sh
run_post_nmmb_Grib2_pe_test_HERA.sh
run_post_fv3r_HERA.sh
run_post_fv3r_pe_test_HERA.sh
run_post_fv3gefs_HERA.sh
run_post_fv3gefs_pe_test_HERA.sh
run_post_fv3hafs_HERA.sh
run_post_fv3hafs_pe_test_HERA.sh
run_post_3drtma_HERA.sh
run_post_3drtma_pe_test_HERA.sh

/scratch2/BMC/det/KaYee/UPP/UFFDA/itag/EMC_RT_itag/gfs/ush
gfs_nceppost.sh

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@kayeekayee Can you create a new issue regarding this PR?

@fossell
Copy link
Copy Markdown
Contributor

fossell commented Oct 5, 2021

@kayeekayee Can you create a new issue regarding this PR?

There is an existing issue already. I'll link it to this PR.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@kayeekayee and @fossell I did tests on WCOSS-Dell. The results look good. There will be coordination with model developers for this itag update. I would expect three more weeks for final merge.

Comment thread ush/global_nceppost.sh Outdated
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@kayeekayee Could you sync your branch with upstream/develop? Thanks!

@WenMeng-NOAA WenMeng-NOAA added No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review. labels Oct 20, 2021
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
@fossell
Copy link
Copy Markdown
Contributor

fossell commented Oct 21, 2021

@kayeekayee - Can you please change this PR to active by clicking "ready for review"? It's currently still a Draft PR.

@kayeekayee kayeekayee marked this pull request as ready for review October 21, 2021 14:56
@kayeekayee kayeekayee requested a review from hertneky as a code owner October 21, 2021 14:56
Comment thread sorc/ncep_post.fd/WRFPOST.f
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Comment thread ush/gfs_nceppost.sh Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The UPP regression tests were successfully passed on WCOSS-Dell, WCOSS-Cray and Hera. This PR is ready for merging.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@fossell and @hertneky Do you have more comments on this PR?

@kayeekayee
Copy link
Copy Markdown
Contributor Author

The UPP regression tests were successfully passed on WCOSS-Dell, WCOSS-Cray and Hera. This PR is ready for merging.

Thank you so much for your confirmation, Wen.

Copy link
Copy Markdown
Contributor

@fossell fossell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional comments from me.

Comment thread scripts/run_upp Outdated
Comment thread ush/gfs_nceppost.sh Outdated
Comment thread sorc/ncep_post.fd/WRFPOST.f Outdated
Copy link
Copy Markdown
Contributor

@hertneky hertneky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have no other comments

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

The tests on Hera were passed. This PR is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit a774356 into NOAA-EMC:develop Oct 27, 2021
@kayeekayee kayeekayee deleted the itag branch October 28, 2021 19:37
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
* Add RRFSE local config changes

* Add archiving of ensprod
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
…OAA-EMC#402)

Substantial changes in UGWPv1 to fix problem of lack of reproducibility when changing the domain decomposition layout.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

No Baseline Change No baseline of the UPP regression tests are made. Ready for Review This PR is ready for code review.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make itag fortran namelist

4 participants