switched to local copy of FindNetCDF.cmake#385
Merged
Conversation
kgerheiser
approved these changes
Sep 23, 2021
WenMeng-NOAA
added
enhancement
Collaborator
|
The UPP regression tests were successfully completed on WCOSS-Dell, WCOSS-Cray and Hera. No baseline changes. |
WenMeng-NOAA
approved these changes
Sep 24, 2021
Contributor
|
Proposed changes look ok to me, testing build and quick case now for community standalone apps. Will also need to update documentation accordingly to address removal of submodules and change to clone commands (no need for recurse submodules). |
fossell
approved these changes
Sep 24, 2021
Contributor
|
Please feel free to merge, I'll create a separate issue for updating documentation to reflect these mods. |
3 tasks
Collaborator
|
With this PR merging, I will update the UPP build procedure on WCOSS-Dell, WCOSS-Cray, Hera, Jet and Orion. |
Collaborator
EricJames-NOAA
pushed a commit
to EricJames-NOAA/UPP
that referenced
this pull request
Dec 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #384
switched to local copy of FindNetCDF.cmake