Skip to content

Restrict undefined grids from UPP computation Part 3#348

Merged
WenMeng-NOAA merged 14 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:post_bndlyr
Aug 23, 2021
Merged

Restrict undefined grids from UPP computation Part 3#348
WenMeng-NOAA merged 14 commits into
NOAA-EMC:developfrom
WenMeng-NOAA:post_bndlyr

Conversation

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

@WenMeng-NOAA WenMeng-NOAA commented Jul 16, 2021 •
edited
Loading

The main changes are:

  • Modify boundary layer computation BNDLYR.f which causes ufs-weather-model global inline post debug mode failure.
  • Enhancement of undefined grids involved UPP computation which cause regional inline post debug mode failure.
  • Remove the legacy sigma level temperature from RRFS products.
  • Solve the extreme values in MCONV issue of RRFS products with output domain larger than computation domain.
  • Increase VERSION to 10.0.9.

@WenMeng-NOAA WenMeng-NOAA linked an issue Jul 16, 2021 that may be closed by this pull request
Runtime error when running a regression test in debug mode #347
Closed
junwang-noaa
junwang-noaa reviewed Jul 30, 2021
View reviewed changes
Comment thread sorc/ncep_post.fd/ALLOCATE_ALL.f
@WenMeng-NOAA WenMeng-NOAA changed the title Modify boundary layer computation Restrict undefined grids from UPP computation Part 3 Aug 5, 2021
HuiyaChuang-NOAA
HuiyaChuang-NOAA reviewed Aug 11, 2021
View reviewed changes
Comment thread sorc/ncep_post.fd/SLP_new.f Outdated
HuiyaChuang-NOAA
HuiyaChuang-NOAA reviewed Aug 11, 2021
View reviewed changes
Comment thread sorc/ncep_post.fd/CALLCL.f Outdated
HuiyaChuang-NOAA
HuiyaChuang-NOAA reviewed Aug 11, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Made a few comments, let me know what you think

Comment thread sorc/ncep_post.fd/CLDRAD.f
Comment thread sorc/ncep_post.fd/FRZLVL2.f
Comment thread sorc/ncep_post.fd/MIXLEN.f
!$omp parallel do private(i,j,elst,elvgd,ensq,q2kl,ziag)
DO J=JSTA_M,JEND_M
DO I=2,IM-1
IF(T(I,J,L)<spval)THEN
Copy link
Copy Markdown
Contributor

@HuiyaChuang-NOAA HuiyaChuang-NOAA Aug 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest you add PMID

Comment thread sorc/ncep_post.fd/WETBULB.f
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator Author

WenMeng-NOAA commented Aug 23, 2021

The ufs-weather-model tests for global inline post, global inline post in debug mode, regional inline post and regional inline post in debug mode were conducted on WCOSS-Dell and Hera. All tests can be successfully run though.

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With the PR merged, the baselines for
hafs, fv3r will be recreated.

@HuiyaChuang-NOAA
Copy link
Copy Markdown
Contributor

HuiyaChuang-NOAA commented Aug 23, 2021

The ufs-weather-model tests for global inline post, global inline post in debug mode, regional inline post and regional inline post in debug mode were conducted on WCOSS-Dell and Hera. All tests can be successfully run though.

The UPP regression tests were conducted on WCOSS-Dell, WCOSS-Cray and Hera. With the PR merged, the baselines for
hafs, fv3r will be recreated.

Great news! Thank you for your effort.

@WenMeng-NOAA WenMeng-NOAA merged commit a49af05 into NOAA-EMC:develop Aug 23, 2021
@WenMeng-NOAA WenMeng-NOAA mentioned this pull request Aug 23, 2021
Closed
@WenMeng-NOAA WenMeng-NOAA deleted the post_bndlyr branch March 2, 2022 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@DusanJovic-NOAA DusanJovic-NOAA Awaiting requested review from DusanJovic-NOAA

3 more reviewers

@junwang-noaa junwang-noaa junwang-noaa left review comments

@EricRogers-NOAA EricRogers-NOAA EricRogers-NOAA approved these changes

@HuiyaChuang-NOAA HuiyaChuang-NOAA HuiyaChuang-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Runtime error when running a regression test in debug mode

4 participants

@WenMeng-NOAA @HuiyaChuang-NOAA @junwang-noaa @EricRogers-NOAA