Skip to content

Sync with community code in prep for new build structure#16

Merged
WenMeng-NOAA merged 17 commits into
NOAA-EMC:developfrom
fossell:dtc_sync
Nov 6, 2019
Merged

Sync with community code in prep for new build structure#16
WenMeng-NOAA merged 17 commits into
NOAA-EMC:developfrom
fossell:dtc_sync

Conversation

@fossell
Copy link
Copy Markdown
Contributor

@fossell fossell commented Oct 28, 2019

This PR contains cherry-picked commits from our DTC_post branch that include:

  • Bug fixes from our recent bug fix release version v4.0.1
  • Adding some community control files to the parm/ directory
  • Bug fix suggestions from recent merge with develop.

Merging these mods to develop will sync up the community and emc source codes and allow us to make the final switch and hand off for the new build structure.
Comments on specific code sections can be found in files changed.

Comment thread sorc/ncep_post.fd/CLDRAD.f Outdated
Comment thread sorc/ncep_post.fd/RQSTFLD.f Outdated
Comment thread sorc/ncep_post.fd/RQSTFLD.f Outdated
@fossell fossell requested a review from WenMeng-NOAA October 28, 2019 18:07
Comment thread sorc/ncep_post.fd/RQSTFLD.f Outdated
Comment thread sorc/ncep_post.fd/RQSTFLD.f
@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

Kate,

Can you sync the recent changes from develop at original repos. so that I can run regression tests.
Thanks,

Comment thread parm/post_avblflds.xml
@fossell
Copy link
Copy Markdown
Contributor Author

fossell commented Nov 1, 2019

Wen,
I addressed your comments and pushed the requested mods. I did not modify the post_avblflds.xml MXUPHL file yet, but did comment, waiting for your response and final guidance.
I merged the top of develop into this PR as well so you can run regression tests.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

Kate,
I conducted the UPP regression tests on Dell. The results look good for me. No changes were found.
We will have a UPP branch develop commit next week for RAP/HRRR implementation. I will schedule
your branch merging after it. You might manually pick up some changes from RAP/HRRR
implementation in RQSTFLD.F.

@fossell
Copy link
Copy Markdown
Contributor Author

fossell commented Nov 4, 2019

Wen,
Great news, thanks! We will look for RAP/HRRR merge and take those changes into our DTC_post branch when available.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

Conducted regression tests on Dell, Cray and Hera. No changed results were found. This pull request is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 6378bf7 into NOAA-EMC:develop Nov 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants