Skip to content

Sync the GFS-related fixes #1413

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
BenjaminBlake-NOAA merged 1 commit into from
Jan 21, 2026
Merged

Sync the GFS-related fixes #1413

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions sorc/ncep_post.fd/CLDRAD.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,6 +89,7 @@
!> | logic, rather than a dedicated parameter number.
!> 2025-05-05 | Ben Blake | Add sanity checks for RRFSv1 implementation
!> 2025-05-08 | Jaymes Kenyon | For FV3 and MPAS applications, prevent cloud base from being diagnosed as below ground
!> 2026-01-14 | Nick Szapiro | Fixes for thread safe
!>
!> @author Russ Treadon W/NP2 @date 1993-08-30
!---------------------------------------------------------------------------------
Expand Down Expand Up @@ -3813,7 +3814,7 @@ SUBROUTINE CLDRAD
! CURRENT OUTGOING SW RADIATION AT THE SURFACE.
IF (IGET(141)>0) THEN
GRID1 = spval
!$omp parallel do private(i,j)
!$omp parallel do private(i,j,FACTRS)
DO J=JSTA,JEND
DO I=ISTA,IEND
IF(RSWOUT(I,J)<SPVAL) THEN
Expand Down Expand Up @@ -3936,7 +3937,7 @@ SUBROUTINE CLDRAD
! CURRENT (instantaneous) INCOMING CLEARSKY SW RADIATION AT THE SURFACE.
IF (IGET(262)>0) THEN
GRID1 = spval
!$omp parallel do private(i,j)
!$omp parallel do private(i,j,FACTRS)
DO J=JSTA,JEND
DO I=ISTA,IEND
IF(RSWINC(I,J)<SPVAL) THEN
Expand Down
3 changes: 2 additions & 1 deletion sorc/ncep_post.fd/UPP_PHYSICS.f
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5016,6 +5016,7 @@ end subroutine calchipsi
!> 2024-11-15 | Jesse Meng | Initial
!> 2025-04-23 | Jesse Meng | Bug fix zmid calculation in very thin layers
!> 2025-06-12 | Jesse Meng | Bug fix RH converted from decimal to percent. SLR masking procedure modified
!> 2026-01-14 | Nick Szapiro | fix for thread safe
!>
!> @author Jesse Meng @date 2024-11-15

Expand Down Expand Up @@ -5154,7 +5155,7 @@ subroutine calslr_uutah2(slr)

slr = spval

!$omp parallel do private(i,j)
!$omp parallel do private(i,j,swnd)
do j=jsta,jend
do i=ista,iend
if(zsfc(i,j)<spval) then
Expand Down