Skip to content

cmake build capability#140

Merged
WenMeng-NOAA merged 17 commits into
NOAA-EMC:developfrom
aerorahul:feature/cmake
Jun 25, 2020
Merged

cmake build capability#140
WenMeng-NOAA merged 17 commits into
NOAA-EMC:developfrom
aerorahul:feature/cmake

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul commented Jun 18, 2020 •
edited
Loading

This PR:

  • updates the cmake build capability using imported targets provided from NCEPLIBS
  • makes no changes to the existing source code
  • removes files that are placed in the library into the executable. IO files don't belong in the post library.
  • adds PackageConfig.cmake.in file that generates a package configuration file that can be used in external projects e.g. UFS that rely on nceppost library.
  • adds option to build nceppost.x executable.
  • adds option to build with/without WRF library. No wrf library code is added or attached. This is just future compatibility and is only compiled if BUILD_WITH_WRFLIB cmake option is turned OFF (default: OFF).
  • adds a git submodule CMakeModules. This sub-module provides FindPackage.cmake capability to locate packages such as NetCDF, that CMake does not intrinsically provide search capability for.

@fossell @WenMeng-NOAA please add reviewers as appropriate

kgerheiser
kgerheiser reviewed Jun 18, 2020
View reviewed changes
Comment thread sorc/ncep_post.fd/CMakeLists.txt
@fossell
Copy link
Copy Markdown
Contributor

fossell commented Jun 18, 2020

@aerorahul - We're completing reg tests on Hera as we speak for the merge of release/public-v1. Some of the tests are held up in queue, but slowly starting to run. I think it might be best to allow these to finish and complete that merge, then have you update your PR to make any changes to that version. We can start reg tests on this PR, since it is the protocol to run reg tests on PR into develop, but we may be waiting on system queue anyway. I understand that this PR in particular only adds new files and does not modify anything existing, but to bypass reg test testing I will be @WenMeng-NOAA's approval.

fossell
fossell reviewed Jun 18, 2020
View reviewed changes
Comment thread VERSION Outdated
@aerorahul
Copy link
Copy Markdown
Contributor Author

aerorahul commented Jun 18, 2020

@aerorahul - We're completing reg tests on Hera as we speak for the merge of release/public-v1. Some of the tests are held up in queue, but slowly starting to run. I think it might be best to allow these to finish and complete that merge, then have you update your PR to make any changes to that version. We can start reg tests on this PR, since it is the protocol to run reg tests on PR into develop, but we may be waiting on system queue anyway. I understand that this PR in particular only adds new files and does not modify anything existing, but to bypass reg test testing I will be @WenMeng-NOAA's approval.

@fossell I don't see a PR to merge release/public-v1 into develop

@fossell
Copy link
Copy Markdown
Contributor

fossell commented Jun 18, 2020

@fossell I don't see a PR to merge release/public-v1 into develop

@aerorahul - It has not been published yet. @mkavulich has started it and is patiently waiting completion of Hera reg tests. We can go ahead and publish the PR if that is helpful?

@aerorahul
Copy link
Copy Markdown
Contributor Author

aerorahul commented Jun 18, 2020

@fossell I don't see a PR to merge release/public-v1 into develop

@aerorahul - It has not been published yet. @mkavulich has started it and is patiently waiting completion of Hera reg tests. We can go ahead and publish the PR if that is helpful?

Yes. That is generally helpful so developers across the community know if there is something in the pipeline and do not end up duplicating effort. At the very least, a draft PR is recommended.

@fossell fossell mentioned this pull request Jun 18, 2020
Merged
DusanJovic-NOAA
DusanJovic-NOAA reviewed Jun 20, 2020
View reviewed changes
Comment thread cmake/PackageConfig.cmake.in
aerorahul added 3 commits June 20, 2020 16:35
@aerorahul
clean up nceppost library dependencies.
92e1d4d 
Change-Id: I9cbda1b897a12c329afbc17213ea8705253aa4c1
@aerorahul
CMakeModules was updated. Update pointer to CMakeModules submoule and…
a2ec884 
… in .gitmodules

Change-Id: I489d2da5b2bb7b5c28c8b06d685b665e9f86695f
@aerorahul
report location and version information from the library if found
a55f080 
Change-Id: I3b2cb47344b82c6efb1a70814c9b48b9249ba3d2
@fossell
Copy link
Copy Markdown
Contributor

fossell commented Jun 24, 2020

@aerorahul - Can you please update your branch with develop now that release/public-v1 has been merged? And add the version patch as well if you have not already. Thanks!

aerorahul added 4 commits June 24, 2020 12:06
@aerorahul
Merge branch 'develop' into feature/cmake
fd95839 
resolve conflicts.

Change-Id: I1727941175562bf62dfc55d040a37fd35fbbe8e0
@aerorahul
add missing files, change permissions on wrongly made executable files
3b89c47 
Change-Id: I2ffac132e943486b6ae4d6e6b9be3f8fd1f3e507
@aerorahul
replace VERSION number with something outrageous because they cannot …
2fa16db 
…decide on an appropriate versioning.

Until then, stay outrageous.

Change-Id: I6642fa1a0ff889e49333d478b9b0e429f7a683d4
@aerorahul
This commit:
318fb06 
- names the executable consistent with the project and the library
- differentiates the executable name from the library name.
- ensures Fortran component of NetCDF is found.

Change-Id: If39f21e5bce6f12ac8053ea5a44aa6f0210c0f23
@aerorahul
clean-up top-level cmakelists of any downstream activity
7a8d7d1 
Change-Id: Ifbd6da655b3c32ce151994082274f993fa1c5d79
@aerorahul
Copy link
Copy Markdown
Contributor Author

aerorahul commented Jun 24, 2020

@aerorahul - Can you please update your branch with develop now that release/public-v1 has been merged? And add the version patch as well if you have not already. Thanks!

@fossell done.

@WenMeng-NOAA
Copy link
Copy Markdown
Collaborator

WenMeng-NOAA commented Jun 25, 2020

The regression tests were conducted on Dell, Cray and Hera. No changed results. This branch is ready for merging.

@WenMeng-NOAA WenMeng-NOAA merged commit 11ca204 into NOAA-EMC:develop Jun 25, 2020
@aerorahul aerorahul deleted the feature/cmake branch June 29, 2020 00:13
@fossell fossell mentioned this pull request Jun 29, 2020
Closed
guoqing-noaa added a commit to guoqing-noaa/UPP that referenced this pull request Apr 28, 2022
@guoqing-noaa
update Externals.rtma (NOAA-EMC#140)
c6d43ec
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@jwolff-ncar
Merge pull request NOAA-EMC#140 from gsketefian/feature/cleanup_input…
f261069 
…_nml

Clean up template namelist files for the forecast model (for various CCPP physics suites).
EricJames-NOAA pushed a commit to EricJames-NOAA/UPP that referenced this pull request Dec 14, 2022
@hu5970
RRFS dev1: changes to run RRFS on Orin and Hera (NOAA-EMC#140)
baff70a 
1 changes to run RRFS on Orion and Hera
2 bug fix in GSI run script when GFS ensemble are missing
3 use real-time mesonet uselist
4 add CONUS 13km as practical and test system.
zhanglikate pushed a commit to zhanglikate/UPP that referenced this pull request Oct 10, 2025
@climbfuji
Cleanup work: CCPP metadata units and more (NOAA-EMC#140)
f053db2 
This PR contains cleanup work to address wrong units and some issues raised in recently merged PRs:
- correct units for latitude, longitude, and pi
- correct standard name air_temperature_save_from_cumulus_paramterization to air_temperature_save_from_convective_parameterization
- remove unused variables in two routines in `GFS_typedefs.F90`
- remove recently introduced variable `cycling` (part of GFS_control DDT), now a local variable in `physics/module_MYNNPBL_wrapper.F90`
- change order of interstitial schemes in `ccpp/suites/suite_FV3_GFS_2017_fv3wam.xml` to match other SDFs

Fixes NOAA-EMC#138 and parts of NOAA-EMC#137.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@WenMeng-NOAA WenMeng-NOAA WenMeng-NOAA approved these changes

@kgerheiser kgerheiser Awaiting requested review from kgerheiser

+2 more reviewers

@fossell fossell fossell approved these changes

@DusanJovic-NOAA DusanJovic-NOAA DusanJovic-NOAA approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aerorahul @fossell @WenMeng-NOAA @kgerheiser @DusanJovic-NOAA