Modules fix explicit interface compiler warnings in post

sorc/ncep_post.fd/ALLOCATE_ALL.f

@@ -1,7 +1,6 @@
 !> @file
-!
-!> SET UP MESSGAE PASSING INFO
-!! @author TUCCILLO ORG: IBM
+!> @brief allocate_all() allocates variables and sets up message passing info
+!> @author TUCCILLO @date 2000-01-06
 !!
 !! PROGRAM HISTORY LOG:
 !! -  00-01-06  TUCCILLO - ORIGINAL
@@ -39,6 +38,14 @@
 !!   LIBRARY:
 !!     - COMMON - CTLBLK.comm
 !!
+      MODULE ALLOCATE_ALL_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+! -----------------------------------------------------------
+!> \brief Allocates necessary data structures for run
+! -----------------------------------------------------------
       SUBROUTINE ALLOCATE_ALL()
 !
       use upp_ifi_mod, only: set_ifi_dims
@@ -1471,3 +1478,5 @@ SUBROUTINE ALLOCATE_ALL()
       endif
 !
       end
+
+      END MODULE ALLOCATE_ALL_UPP_MOD

sorc/ncep_post.fd/AVIATION.f

@@ -266,14 +266,15 @@ SUBROUTINE CALCAT(U,V,H,U_OLD,V_OLD,H_OLD,CAT)
       use ctlblk_mod, only: spval, jsta_2l, jend_2u, jsta_m, jend_m, &
               im, jm, ista_2l, iend_2u, ista_m, iend_m, ista, iend
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 
 !     
 !     DECLARE VARIABLES.
 !     
-      REAL,DIMENSION(ista_2l:iend_2u,jsta_2l:jend_2u),INTENT(IN)    :: U,V,H, &
+      REAL,DIMENSION(ista_2l:iend_2u,jsta_2l:jend_2u),INTENT(INOUT) :: U,V,H, &
                                                 U_OLD,V_OLD,H_OLD
 !      INTEGER,INTENT(IN)                      :: L
       REAL,DIMENSION(ista_2l:iend_2u,jsta_2l:jend_2u),INTENT(INOUT) :: CAT

sorc/ncep_post.fd/BNDLYR.f

@@ -65,6 +65,7 @@ SUBROUTINE BNDLYR(PBND,TBND,QBND,RHBND,UBND,VBND,       &
       use physcons_post,   only: con_rd, con_rv, con_eps, con_epsm1
       use gridspec_mod, only: gridtype
       use upp_physics, only: FPVSNEW
+      use exch_upp_mod, only: exch
 !
       implicit none
 !

sorc/ncep_post.fd/CALGUST.f

@@ -33,6 +33,7 @@ SUBROUTINE CALGUST(LPBL,ZPBL,GUST)
       use ctlblk_mod, only: jsta, jend, spval, jsta_m, jend_m, num_procs, mpi_comm_comp, lm,&
               modelname, im, jm, jsta_2l, jend_2u, ista, iend, ista_m, iend_m, ista_2l, iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 
       implicit none
 

sorc/ncep_post.fd/CALHEL.f

@@ -55,6 +55,7 @@ SUBROUTINE CALHEL(DEPTH,UST,VST,HELI,USHR1,VSHR1,USHR6,VSHR6)
                             lm, im, jm, me, spval,  &
                             ista, iend, ista_m, iend_m, ista_2l, iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALHEL2.f

@@ -57,6 +57,7 @@ SUBROUTINE CALHEL2(LLOW,LUPP,DEPTH,UST,VST,HELI,CANGLE)
                             lm, im, jm, me, spval, &
                             ista, iend, ista_m, iend_m, ista_2l, iend_2u    
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALHEL3.f

@@ -58,6 +58,7 @@ SUBROUTINE CALHEL3(LLOW,LUPP,UST,VST,HELI)
                             lm, im, jm, me, spval, &
                             ista, iend, ista_m, iend_m, ista_2l, iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALMCVG.f

@@ -51,12 +51,13 @@ SUBROUTINE CALMCVG(Q1D,U1D,V1D,QCNVG)
                               jsta_m2, jend_m2, im, jm,                      &
                               ista_2l, iend_2u, ista_m, iend_m, ista_m2, iend_m2 
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     
 !     DECLARE VARIABLES.
 !     
-      REAL,dimension(ista_2l:iend_2u,jsta_2l:jend_2u),intent(in)    ::  Q1D, U1D, V1D
+      REAL,dimension(ista_2l:iend_2u,jsta_2l:jend_2u),intent(inout) ::  Q1D, U1D, V1D
       REAL,dimension(ista_2l:iend_2u,jsta_2l:jend_2u),intent(inout) ::  QCNVG
 
       REAL R2DY, R2DX

sorc/ncep_post.fd/CALPBL.f

@@ -44,6 +44,7 @@ SUBROUTINE CALPBL(PBLHGT,METHOD)
       use ctlblk_mod, only: lm, im, jsta, jend, spval, jsta_m, jsta_2l, jend_2u, jend_m, &
                             ista, iend, ista_m, ista_2l, iend_2u, iend_m  
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALPBLREGIME.f

@@ -40,6 +40,7 @@ SUBROUTINE CALPBLREGIME(PBLREGIME)
       use ctlblk_mod,   only: jsta, jend, spval, lm, jsta_m, jend_m, im,    &
                               jsta_2l, jend_2u, ista, iend, ista_m, iend_m,ista_2l,iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALRCH.f

@@ -38,6 +38,7 @@ SUBROUTINE CALRCH(EL,RICHNO)
                             jsta_2l, jend_2u, lm,                       &
                             ista, iend, ista_m, iend_m, ista_2l, iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/CALTAU.f

@@ -41,6 +41,7 @@ SUBROUTINE CALTAU(TAUX,TAUY)
       use ctlblk_mod,   only: jsta_2l, jend_2u, lm, jsta, jend, spval, jsta_m,&
                             jm, im, jend_m, ista, iend, ista_m, iend_m, ista_2l, iend_2u
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 
       implicit none
 !

sorc/ncep_post.fd/CALUPDHEL.f

@@ -34,6 +34,7 @@ SUBROUTINE CALUPDHEL(UPDHEL)
                               ista_2l, iend_2u, ista_m, iend_m
       use gridspec_mod, only: gridtype
       use upp_math,     only: DVDXDUDY, DDVDX, DDUDY
+      use exch_upp_mod, only: exch
 
       implicit none
 

sorc/ncep_post.fd/DEALLOCATE.f

@@ -17,6 +17,12 @@
 !> 2025-01-13 | Jaymes Kenyon| Add graupel number concentration (QQNG)
 !> 2025-01-13 | Jaymes Kenyon| Add HAIL_BUCKET
 
+      MODULE DE_ALLOCATE_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+
 !> @author Jim Tuccillo IBM @date 2000-01-06
       SUBROUTINE DE_ALLOCATE
 
@@ -597,3 +603,5 @@ SUBROUTINE DE_ALLOCATE
       endif
 
       end
+
+      END MODULE DE_ALLOCATE_UPP_MOD

sorc/ncep_post.fd/EXCH.f

@@ -16,6 +16,12 @@
 !> during compilation, even if it's specified as a compiler option in the
 !> makefile (Tuccillo, personal communication;  Ferrier, Feb '02).
 !>
+      MODULE EXCH_UPP_MOD
+
+      implicit none
+
+      contains
+
 !> @author Jim Tuccillo IBM @date 2000-01-06
 !----------------------------------------------------------------------
 !> @brief exch() Subroutine that exchanges one halo row. 
@@ -460,3 +466,5 @@ subroutine exch_f(a)
 !
       end
 
+      END MODULE EXCH_UPP_MOD
+

sorc/ncep_post.fd/FDLVL.f

@@ -69,6 +69,7 @@ SUBROUTINE FDLVL(ITYPE,TFD,QFD,UFD,VFD,PFD,ICINGFD)
                             JEND_M, HTFD, NFD, IM, JM, NBIN_DU,    &
                             MODELNAME, ISTA, IEND, ISTA_2L, IEND_2U, ISTA_M, IEND_M
       use gridspec_mod, only: GRIDTYPE
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !
@@ -491,6 +492,7 @@ SUBROUTINE FDLVL_UV(ITYPE,NFD,HTFD,UFD,VFD)
                             JEND_M, IM, JM, MODELNAME, &
                             ISTA, IEND, ISTA_2L, IEND_2U, ISTA_M, IEND_M
       use gridspec_mod, only: GRIDTYPE
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !

sorc/ncep_post.fd/INITPOST.F

@@ -70,6 +70,9 @@ SUBROUTINE INITPOST
       use gridspec_mod, only: gridtype, dxval, latstart, latlast, lonstart,        &
               lonlast, dyval, cenlat, cenlon, maptype, truelat1, truelat2,         &
               standlon, psmapf
+      use exch_upp_mod, only: exch
+      use table_upp_mod, only : table
+      use tableq_upp_mod, only : tableq
       use wrf_io_flags_mod, only:
 !- - - - - - - - - - - - - - - - - - -  - - - - - - - - - - - - - - - -
       implicit none

sorc/ncep_post.fd/INITPOST_GFS_NEMS_MPIIO.f

@@ -86,6 +86,9 @@ SUBROUTINE INITPOST_GFS_NEMS_MPIIO(iostatusAER)
               dxval, dyval, truelat2, truelat1, psmapf, cenlat
       use nemsio_module_mpi
       use upp_physics, only: fpvsnew, caldiv, calgradps
+      use exch_upp_mod, only: exch
+      use table_upp_mod, only : table
+      use tableq_upp_mod, only : tableq
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
       implicit none
 !

sorc/ncep_post.fd/INITPOST_MPAS.F

@@ -91,6 +91,8 @@ SUBROUTINE INITPOST_MPAS
       use gridspec_mod, only: gridtype, dxval, latstart, latlast, lonstart,        &
               lonlast, dyval, cenlat, cenlon, maptype, truelat1, truelat2,         &
               standlon, psmapf
+      use table_upp_mod, only : table
+      use tableq_upp_mod, only : tableq
       use wrf_io_flags_mod, only:
 !- - - - - - - - - - - - - - - - - - -  - - - - - - - - - - - - - - - -
       implicit none

sorc/ncep_post.fd/INITPOST_NEMS.f

@@ -59,6 +59,9 @@ SUBROUTINE INITPOST_NEMS(NREC,nfile)
               lonlastv, cenlonv
       use nemsio_module, only: nemsio_gfile, nemsio_getfilehead, nemsio_close, nemsio_getheadvar
       use upp_math, only: h2u
+      use exch_upp_mod, only: exch
+      use table_upp_mod, only : table
+      use tableq_upp_mod, only : tableq
 !
 !     INCLUDE/SET PARAMETERS.
       implicit none

sorc/ncep_post.fd/INITPOST_NETCDF.f

@@ -139,6 +139,9 @@ SUBROUTINE INITPOST_NETCDF(ncid2d,ncid3d)
               latstartv, latlastv,cenlatv,latstart_r,latlast_r,lonstart_r,lonlast_r, STANDLON,  &
               latse,lonse,latnw,lonnw
       use upp_physics, only: fpvsnew
+      use exch_upp_mod, only: exch
+      use table_upp_mod, only : table
+      use tableq_upp_mod, only : tableq
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
       implicit none
 !

sorc/ncep_post.fd/MDL2AGL.f

@@ -69,6 +69,7 @@ SUBROUTINE MDL2AGL
                             ista, iend, ista_2l, iend_2u, ista_m, iend_m
       use rqstfld_mod,  only: iget, lvls, iavblfld, lvlsxml, id
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
       INCLUDE "mpif.h"

sorc/ncep_post.fd/MDL2P.f

@@ -80,6 +80,7 @@ SUBROUTINE MDL2P(iostatusD3D)
       use gridspec_mod, only: GRIDTYPE, MAPTYPE, DXVAL
       use upp_physics, only: FPVSNEW, CALRH, CALVOR, CALSLR_ROEBBER, CALSLR_UUTAH, &
                              CALSLR_UUTAH2, CALCHIPSI
+      use exch_upp_mod, only: exch
 
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - 
 !

sorc/ncep_post.fd/MDL2SIGMA.f

@@ -67,6 +67,7 @@ SUBROUTINE MDL2SIGMA
                                jm, im_jm, ista, iend, ista_2l, iend_2u, ista_m, iend_m
       use rqstfld_mod,   only: iget, lvls, id, iavblfld, lvlsxml
       use gridspec_mod,  only :gridtype
+      use exch_upp_mod,  only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
        implicit none
 !     

sorc/ncep_post.fd/MDL2THANDPV.f

@@ -43,6 +43,7 @@ SUBROUTINE MDL2THANDPV(kth,kpv,th,pv)
       use gridspec_mod, only: gridtype,dyval
       use upp_physics, only: FPVSNEW
       use upp_math, only: DVDXDUDY, DDVDX, DDUDY, UUAVG, h2u
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !     

sorc/ncep_post.fd/MISCLN.f

@@ -74,6 +74,7 @@ SUBROUTINE MISCLN
       use grib2_module, only: pset
       use upp_physics, only: FPVSNEW,CALRH_PW,CALCAPE,CALCAPE2,TVIRTUAL
       use gridspec_mod, only: gridtype
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
        implicit none
 !

sorc/ncep_post.fd/PROCESS.f

@@ -26,6 +26,12 @@
 !> 2023-01-24 | Sam Trahan   | run IFI and compute its runtime
 !> 2023-08-24 | Yali Mao     | Remove running MDL2STD_P
 !>
+      MODULE PROCESS_UPP_MOD
+
+      implicit none
+
+      contains
+
 !> @author Russ Treadon W/NP2 @date 1992-12-21
 !----------------------------------------------------------------------------
 !> process() is a driver for major post routines.
@@ -144,3 +150,5 @@ SUBROUTINE PROCESS(kth,kpv,th,pv,iostatusD3D)
 !
       RETURN
       END
+
+      END MODULE PROCESS_UPP_MOD

sorc/ncep_post.fd/READ_xml.f

@@ -10,6 +10,12 @@
 !>   2015-03-10 | Lin Gan  | Replace XML file with flat file implementation with parameter marshalling
 !>   2016-07-08 | J. Carley | Clean up prints 
 
+      MODULE READ_XML_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+
       SUBROUTINE READ_xml()
 
        use xml_perl_data,only: post_avblflds,paramset,read_postxconfig
@@ -51,3 +57,5 @@ SUBROUTINE READ_xml()
       RETURN
       end subroutine read_xml
 
+      END MODULE READ_XML_UPP_MOD
+

sorc/ncep_post.fd/SET_OUTFLDS.f

@@ -14,6 +14,12 @@
 !> 2015-03-10 | Lin Gan  | Replace XML file with flat file implementation
 !> 2019-10-30 | Bo Cui   | Removw "GOTO" Statement
 !---------------------------------------------------------------------------
+      MODULE SET_OUTFLDS_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+
 !> @brief Reads post XML control file.
 !>
 !> @param[in] KTH total number of isentropic levels
@@ -172,3 +178,5 @@ SUBROUTINE SET_OUTFLDS(kth,th,kpv,pv)
 
       RETURN
       END
+
+      END MODULE SET_OUTFLDS_UPP_MOD

sorc/ncep_post.fd/SLP_new.f

@@ -56,6 +56,7 @@ SUBROUTINE MEMSLP(TPRES,QPRES,FIPRES)
       use ctlblk_mod, only: jend, jsta, spval, spl, num_procs, mpi_comm_comp, lsmp1, &
                             jsta_m, jend_m, lm, im, jsta_2l, jend_2u, lsm, jm,&
                             im_jm, iend, ista, ista_m, iend_m, ista_2l, iend_2u
+      use exch_upp_mod, only: exch
 !- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -
       implicit none
 !      

sorc/ncep_post.fd/TABLE.f

@@ -1,4 +1,10 @@
 !&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&
+      MODULE TABLE_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+
       SUBROUTINE TABLE(PTBL,TTBL,PT                                  &
      &,                RDQ,RDTH,RDP,RDTHE,PL,THL,QS0,SQS,STHE,THE0)
 !     ******************************************************************
@@ -162,3 +168,4 @@ SUBROUTINE TABLE(PTBL,TTBL,PT                                  &
 !
       RETURN
       END
+      END MODULE TABLE_UPP_MOD

sorc/ncep_post.fd/TABLEQ.f

@@ -1,4 +1,10 @@
 !&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&&
+      MODULE TABLEQ_UPP_MOD
+
+      IMPLICIT NONE
+
+      CONTAINS
+
       SUBROUTINE TABLEQ(TTBLQ,RDP,RDTHE,PL,THL,STHE,THE0)
 !     ******************************************************************
 !     *                                                                *
@@ -89,3 +95,4 @@ SUBROUTINE TABLEQ(TTBLQ,RDP,RDTHE,PL,THL,STHE,THE0)
 !
       RETURN
       END
+      END MODULE TABLEQ_UPP_MOD