Port UPP to Ursa (build only; no regtest)#1231
Conversation
SamuelTrahanNOAA
requested review from
BenjaminBlake-NOAA and
WenMeng-NOAA
as code owners
WenMeng-NOAA
added
enhancement
|
@SamuelTrahanNOAA The build test on Ursa works well. Could you update compile_upp.sh for setting interlllvm as default complier on Ursa? |
|
@SamuelTrahanNOAA Thank you for separating the build changes from the regression test changes - we will address those in the next PR. I tested the build on Ursa, WCOSS2, and Hera and they all work well for me. I agree with @WenMeng-NOAA about setting the default compiler to intelllvm on Ursa, otherwise I approve this PR. |
|
The default compiler on ursa is now intelllvm and other machines default to intel. The usage message will print the correct default on each machine. Also, I noticed two spots where "without" should be "with" in the usage: wrfio and nemsio. The flag is for turning them on (the default) not off. |
|
@SamuelTrahanNOAA Good catch on wrfio and nemsio since the default options are set as DBUILD_WITH_NEMSIO=ON and DBUILD_WITH_WRFIO=ON. The build step works well for me. |
|
@SamuelTrahanNOAA Do you have a pre-installed ifi library on Ursa? |
@WenMeng-NOAA - We don't have permission to use ifi on Ursa yet. A federal manager would need to ask NCAR for permission. I'm sure they'd say "yes," but nobody has requested it yet. Thus, IFI has to wait until a later PR. |
@SamuelTrahanNOAA Thanks for clarifying. Your plan sounds good to me. |
|
@SamuelTrahanNOAA I have run the UPP standalone tests on Ursa. Your updates look good to me. Thanks for your contribution! |
|
@gspetro-NOAA This PR is ready for the UPP RTs on R&D machines. There should be no baseline changes. |
gspetro-NOAA
left a comment
gspetro-NOAA
left a comment
There was a problem hiding this comment.
RTs pass on Hera, Orion, and Hercules without baseline changes.
|
Thanks @SamuelTrahanNOAA for your work on this, and @WenMeng-NOAA @gspetro-NOAA @DavidHuber-NOAA for testing/reviewing. |
* port to ursa intel llvm (called "intel" in modulefiles and scripts) * use the same KPO list for fv3gefs pe and non-pe tests on HERA * compiler is in all modulefile names and is an argument to rt.sh (mandatory on ursa) * longer wallclock for 3drtm * all ci jobs are exclusive on ursa * ursa older intel compiler modulefile * put $compiler in runtime.log in rt.sh * revert accidental change: upp_common.lua should have no _intel * put compiler name in rt.log filename * hera tests passed * ursa tests passed * revert to develop for ci * remove ursa tests * revert hera log * remove unneeded script * ursa default compiler = intelllvm; move defaults to top of file * restore defaults for usage message * default compiler is intel on ursa * hercules rt log * hera rt log * orion rt log * wcoss2 rt log --------- Co-authored-by: gspetro-NOAA <gillian.petro@noaa.gov> Co-authored-by: Wen Meng <wen.meng@noaa.gov>
5 participants
This is a subset of #1225 which only allows building UPP on Ursa. It doesn't include any regression test system changes. Please refer to the original PR for details: