Minor fix to avoid zmid=NaN in very thin layers.#1193
Merged
Conversation
Collaborator
|
@JesseMeng-NOAA Could you add change logs to the two routine files you updated? |
NickSzapiro-NOAA
approved these changes
Apr 22, 2025
Contributor
|
Thank you for resolving this together! Update to post_fv3.F90 interface maybe in ~10 days |
Contributor
Author
@WenMeng-NOAA Do you mean this? |
Collaborator
@JesseMeng-NOAA Yes, please add a change log with your name at the beginning section of each subroutine. |
Collaborator
|
@FernandoAndrade-NOAA This PR is ready for the UPP RTs on R&D machines. There should be no baseline changes. |
Collaborator
|
The UPP RTs have been completed on WCOSS2 without baseline changes. |
Contributor
FYI Orion/Hercules are down today for maintenance, there will be delays in merging. |
FernandoAndrade-NOAA
approved these changes
Apr 24, 2025
Contributor
FernandoAndrade-NOAA
left a comment
FernandoAndrade-NOAA
left a comment
There was a problem hiding this comment.
RTs completed across Hera, Hercules, and Orion. No changes in results.
WenMeng-NOAA
approved these changes
Apr 25, 2025
Collaborator
|
This PR is ready for merging. |
WenMeng-NOAA
pushed a commit
that referenced
this pull request
May 7, 2025
* 10 initial sanity checks added * Fix typo in SURFCE.f * Incorporate fixes to grib2_module.f from PR #974 to UPP develop * Fixes for cloud ceiling and 2-m potential temperature, and INITPOST changes from #1193 * Remove 2-m potential temperature from RRFS * Add change log info to updated files in sorc directory --------- Co-authored-by: benjamin blake <benjamin.blake@clogin07.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: benjamin blake <benjamin.blake@clogin01.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: benjamin blake <benjamin.blake@clogin08.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: benjamin blake <benjamin.blake@clogin02.cactus.wcoss2.ncep.noaa.gov> Co-authored-by: benjamin blake <benjamin.blake@clogin06.cactus.wcoss2.ncep.noaa.gov>
gspetro-NOAA
pushed a commit
to jaymes-kenyon/UPP
that referenced
this pull request
May 7, 2025
* 20250422 Jesse Meng minor fix to avoid zmid=NaN in very thin layers. * Bug fix zmid calculation in very thin layers * add hera RT log * add hercules RT log * add orion RT log --------- Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov>
WenMeng-NOAA
added a commit
that referenced
this pull request
May 8, 2025
…L diagnostic; other refinements (#1185) * - Clean-up / remove various outdated GSL diagnostics of cloud top and cloud base - For MPAS, enable output of maximum upward vertical velocity (MAXUVV) - For MPAS, change the prefixes on the GRIB2 file names that are initially generated * Reorganizing control files for MPAS applications * Updating control files for RAP and HRRR * Removing parameter 770 (GSD_RADARVIL_ON_ENTIRE_ATMOS) and its supporting code. A functionally identical diagnostic remains available via parameter 581 * Reduce RHmin in upper stratosphere and lower mesosphere to be below stratopause RH (#1186) * Reduce minimum RH above 3 mbar by a factor of ten. Old value led to q > 10 ppm near polar stratopause. This version keeps specific humidity near its values in the rest of the stratosphere. * DOC: Add changelog entry They may want an upper bound to the change at some point, but I don't know that we get far enough into the mesosphere for that to be an issue * BUG: Use floating-point literals to reduce stratopause RHmin * add hera RT log * add hercules RT log * add orion RT log and cmp path fix gfs * Update intel.yml update ubuntu version 22.04 --------- Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com> * Minor fix to avoid zmid=NaN in very thin layers. (#1193) * 20250422 Jesse Meng minor fix to avoid zmid=NaN in very thin layers. * Bug fix zmid calculation in very thin layers * add hera RT log * add hercules RT log * add orion RT log --------- Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> * Reorganizing control files for MPAS applications * Updating control files for RAP and HRRR * Removing parameter 770 (GSD_RADARVIL_ON_ENTIRE_ATMOS) and its supporting code. A functionally identical diagnostic remains available via parameter 581 * hera rt log * hercules rt log * orion rt log * hera rt log after retest --------- Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: DWesl <22566757+DWesl@users.noreply.github.com> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com> Co-authored-by: Jesse Meng <49207433+JesseMeng-NOAA@users.noreply.github.com> Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: gspetro-NOAA <gillian.petro@noaa.gov> Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
gspetro-NOAA
pushed a commit
to gspetro-NOAA/UPP
that referenced
this pull request
Jul 28, 2025
* 20250422 Jesse Meng minor fix to avoid zmid=NaN in very thin layers. * Bug fix zmid calculation in very thin layers * add hera RT log * add hercules RT log * add orion RT log --------- Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov>
gspetro-NOAA
added a commit
to gspetro-NOAA/UPP
that referenced
this pull request
Jul 28, 2025
…L diagnostic; other refinements (NOAA-EMC#1185) * - Clean-up / remove various outdated GSL diagnostics of cloud top and cloud base - For MPAS, enable output of maximum upward vertical velocity (MAXUVV) - For MPAS, change the prefixes on the GRIB2 file names that are initially generated * Reorganizing control files for MPAS applications * Updating control files for RAP and HRRR * Removing parameter 770 (GSD_RADARVIL_ON_ENTIRE_ATMOS) and its supporting code. A functionally identical diagnostic remains available via parameter 581 * Reduce RHmin in upper stratosphere and lower mesosphere to be below stratopause RH (NOAA-EMC#1186) * Reduce minimum RH above 3 mbar by a factor of ten. Old value led to q > 10 ppm near polar stratopause. This version keeps specific humidity near its values in the rest of the stratosphere. * DOC: Add changelog entry They may want an upper bound to the change at some point, but I don't know that we get far enough into the mesosphere for that to be an issue * BUG: Use floating-point literals to reduce stratopause RHmin * add hera RT log * add hercules RT log * add orion RT log and cmp path fix gfs * Update intel.yml update ubuntu version 22.04 --------- Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com> * Minor fix to avoid zmid=NaN in very thin layers. (NOAA-EMC#1193) * 20250422 Jesse Meng minor fix to avoid zmid=NaN in very thin layers. * Bug fix zmid calculation in very thin layers * add hera RT log * add hercules RT log * add orion RT log --------- Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> * Reorganizing control files for MPAS applications * Updating control files for RAP and HRRR * Removing parameter 770 (GSD_RADARVIL_ON_ENTIRE_ATMOS) and its supporting code. A functionally identical diagnostic remains available via parameter 581 * hera rt log * hercules rt log * orion rt log * hera rt log after retest --------- Co-authored-by: WenMeng-NOAA <48260754+WenMeng-NOAA@users.noreply.github.com> Co-authored-by: DWesl <22566757+DWesl@users.noreply.github.com> Co-authored-by: FernandoAndrade-NOAA <fernando.andrade-maldonado@noaa.gov> Co-authored-by: Fernando Andrade - NOAA <121964418+FernandoAndrade-NOAA@users.noreply.github.com> Co-authored-by: Jesse Meng <49207433+JesseMeng-NOAA@users.noreply.github.com> Co-authored-by: shrinivas.moorthi <shrinivas.moorthi@noaa.gov> Co-authored-by: gspetro-NOAA <gillian.petro@noaa.gov> Co-authored-by: Gillian Petro <96886803+gspetro-NOAA@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To fix UPP issue 1174 #1174
ufs-weather-model inline post crashed due to zmid=NaN in very thin layers where dpres-->0.