Skip to content

add cmake build to Data Atmosphere#17

Merged
binli2337 merged 1 commit into
NOAA-EMC:developfrom
aerorahul:feature/cmake
Oct 21, 2020
Merged

add cmake build to Data Atmosphere#17
binli2337 merged 1 commit into
NOAA-EMC:developfrom
aerorahul:feature/cmake

Conversation

@aerorahul
Copy link
Copy Markdown
Contributor

This PR:

  • build's data atmosphere component with cmake.
  • fixes a GNU error in datm.F90, where a non-negative integer needs to be provided. This is a similar error we saw in MOM6 nuopc cap.

There is no change in results.

Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we'll want to carry the tools directory forward. That is the tool I initially created to convert the nemsio to netcdf for the datm input. But Hyun-Chul developed a different tool so I believe the tools/ is no longer needed. His scripts were located in the utilities directory of the app.

@binli2337
Copy link
Copy Markdown

I think the files in tools might be useful in the future.

@binli2337 binli2337 merged commit 84e9a1f into NOAA-EMC:develop Oct 21, 2020
@aerorahul
Copy link
Copy Markdown
Contributor Author

I'm not sure we'll want to carry the tools directory forward. That is the tool I initially created to convert the nemsio to netcdf for the datm input. But Hyun-Chul developed a different tool so I believe the tools/ is no longer needed. His scripts were located in the utilities directory of the app.

@DeniseWorthen is correct.
Should we bring the utilities directory from the App into this repo? I can anticipate use for the IDL and @hyunchul386 forcing creator still be useful. Thoughts?

@aerorahul aerorahul deleted the feature/cmake branch October 21, 2020 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants