Updates for JEDI linking/control#85
Merged
Merged
Conversation
| rc=RC) | ||
| ESMF_ERR_RETURN(RC,RC_REG) | ||
|
|
||
| #ifdef NEMS_DRIVER |
Collaborator
There was a problem hiding this comment.
Mark, to avoid the code changes in ufs-weather-model side, can you change to:
ifndef JEDI_DRIVER
I assume JEDI would be the driver if the model runs within JEDI, by default, NEMS will be the driver.
This was referenced Dec 10, 2020
Contributor
|
Please convert this PR to "ready for review". |
junwang-noaa
approved these changes
Dec 11, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is part of the changes required to enable JEDI to link to and control the UFS for data assimilation. This change adds a compiler directive around a section of code in module_EARTH_GRID_COMP that assumes the NEMS earth component is the top level driver for the model. With the directive enabled, the clock can then be controlled from a higher level (JEDI) driver.
Is part of NOAA-EMC/ufsatm/pull/201.