Fixing a runtime error for GNU compiler on Cheyenne#8
Closed
climbfuji wants to merge 1 commit into
Closed
Conversation
…iginal code is standard Fortran and works on macOS with gcc-8.3.0 and gcc-9.1.0, it leads to a model crash on Cheyenne with gcc-8.3.0; revert to the failsafe version that has worked ever since
Contributor
Author
|
This was a red herring, I am closing this PR. The proposed change doesn't fix the problem, it rather seems to be related to the ESMF library used on Cheyenne/GNU (8.0.0bs40). |
MinsukJi-NOAA
pushed a commit
to MinsukJi-NOAA/NEMS
that referenced
this pull request
May 8, 2020
debug mode for NEMS, additional minor changes in component mk files (…
hyunchul386
pushed a commit
to hyunchul386/NEMS
that referenced
this pull request
Jul 24, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue with a code change introduced in #7 (src/module_MEDIATOR.F90).
While the original code changes in #7
are valid and standard Fortran and work on macOS with gcc-8.3.0 and gcc-9.1.0, they lead to a model crash on Cheyenne with gcc-8.3.0:
The solution is to revert to the failsafe version that we have used successfully in the past for both Intel and GNU.
I tested those changes to work for both Intel and GNU on Cheyenne and I would advocate for merging them as soon as we can (possibly before kicking off the final round of tests for https://vlab.ncep.noaa.gov/code-review/#/c/19568).