Bugfix for issue "NEMS hash 044400a8eea19d1ce991a2adaa0b369ed0e067c7 and head of develop broken for GNU compilers"#42
Merged
MinsukJi-NOAA merged 2 commits intoMar 11, 2020
Conversation
…trings have to match
Collaborator
RatkoVasic-NOAA
left a comment
RatkoVasic-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me.
Minsuk Ji should approve this PR.
Contributor
Author
|
Thanks! Fixing the bug in ufs-weather-model after merging this PR will require updating the hash to the top of develop in ufs-weather-model (I am currently updating the PR and testing it with ufs-weather-model). |
Collaborator
Let me know how the testing goes. I will merge the PR. Thanks! |
Contributor
Author
|
I updated this PR and merged the develop branch in, then ran the tests on hera for the ufs-weather-model ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
src/module_EARTH_GRID_COMP.F90: bugfix for GNU compiler, lengths of strings have to match
see #41
This compiles with gcc/gfortran on macOS.
Note: this PR was created on top of hash 044400a, which is used by the ufs-weather-model; the head of develop seem to have advanced beyond this.