Skip to content

Update README.md#66

Merged
climbfuji merged 4 commits into
NOAA-EMC:release/public-v1from
climbfuji:update_readme_20200309
Mar 9, 2020
Merged

Update README.md#66
climbfuji merged 4 commits into
NOAA-EMC:release/public-v1from
climbfuji:update_readme_20200309

Conversation

@climbfuji
Copy link
Copy Markdown
Contributor

@climbfuji climbfuji commented Mar 9, 2020

Comment thread README.md
@arunchawla-NOAA
Copy link
Copy Markdown

arunchawla-NOAA commented Mar 9, 2020 via email

@climbfuji
Copy link
Copy Markdown
Contributor Author

@WenMeng-NOAA @GeorgeGayno-NOAA can you please help clarify which version numbers we should use for the UFS public release? The VERSION files in EMC_post and UFS_UTILS say 8.0.0 and 1.1.1, but apparently those should both be 1.0.0?

heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat NCEPLIBS-post/VERSION
8.0.0
heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat UFS_UTILS/VERSION
1.1.1

Thanks!

@GeorgeGayno-NOAA
Copy link
Copy Markdown

@WenMeng-NOAA @GeorgeGayno-NOAA can you please help clarify which version numbers we should use for the UFS public release? The VERSION files in EMC_post and UFS_UTILS say 8.0.0 and 1.1.1, but apparently those should both be 1.0.0?

heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat NCEPLIBS-post/VERSION
8.0.0
heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat UFS_UTILS/VERSION
1.1.1

Thanks!

@aerorahul You added the version file. What is that file documenting?

@WenMeng-NOAA
Copy link
Copy Markdown

@climbfuji For EMC_post repos, use ufs-v1.0.0. I added @fossell for double confirming.

@WenMeng-NOAA
Copy link
Copy Markdown

@aerorahul Will you update the VERSION file at EMC_post with 1.0.0?

@climbfuji
Copy link
Copy Markdown
Contributor Author

I can make those updates for both EMC_post and UFS_UTILS.

@fossell
Copy link
Copy Markdown

fossell commented Mar 9, 2020

@climbfuji @GeorgeGayno-NOAA - Confirming @WenMeng-NOAA comment, UPP has decided to use tag "ufs-v1.0.0" of EMC_post for UFS release. So version number is 1.0.0.

@climbfuji
Copy link
Copy Markdown
Contributor Author

Associated PRs (need to be merged first, then need to update submodule pointers here):

NOAA-EMC/UPP#106
ufs-community/UFS_UTILS#88

@aerorahul
Copy link
Copy Markdown
Contributor

@WenMeng-NOAA @GeorgeGayno-NOAA can you please help clarify which version numbers we should use for the UFS public release? The VERSION files in EMC_post and UFS_UTILS say 8.0.0 and 1.1.1, but apparently those should both be 1.0.0?

heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat NCEPLIBS-post/VERSION
8.0.0
heinzeller-lt:NCEPLIBS-ufs-v1.0.0 dom.heinzeller$ cat UFS_UTILS/VERSION
1.1.1

Thanks!

@aerorahul You added the version file. What is that file documenting?

@GeorgeGayno-NOAA The fileVERSION contains a string documenting the version of the package in the following syntax MAJOR.MINOR.PATCH.TWEAK. This is standard package versioning practice. The VERSION file removes the hard-wired version number from CMakeLists.txt. This is the modern cmake practice. Variants are seen where this file is also named VERSION.cmake or placed in a cmake sub-directory and accessed via include commands in the CMakeLists.txt file.

@climbfuji climbfuji merged commit a080a64 into NOAA-EMC:release/public-v1 Mar 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants