Reduce line length for MASTERTABLE replacements#321
Merged
jbathegit merged 2 commits intoFeb 15, 2023
Conversation
Collaborator
|
Thanks Dom for proactively suggesting a fix for this - much appreciated! I was also thinking to just shorten that _lenslmax setting, but I don't know enough about spack-stack to know what would have been a suitable number, so I'm glad you found one that would work for you. And I'm also glad you didn't try to completely remove the macro in favor of some solution specific to spack-stack, because not everyone who builds the library uses spack-stack to do so. |
jbathegit
approved these changes
Feb 15, 2023
Contributor
Author
|
Thanks so much, @jbathegit! This will be in 11.7.2 then. I am going to add a filter_file macro for versions up to 11.7.1 to spack. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #320