Skip to content

add statediagnose feature#31

Merged
DeniseWorthen merged 7 commits into
NOAA-EMC:dev/emcfrom
DeniseWorthen:feature/statediagnose
Aug 6, 2020
Merged

add statediagnose feature#31
DeniseWorthen merged 7 commits into
NOAA-EMC:dev/emcfrom
DeniseWorthen:feature/statediagnose

Conversation

@DeniseWorthen
Copy link
Copy Markdown
Collaborator

@DeniseWorthen DeniseWorthen commented Aug 6, 2020

Fix for issue #30

  • Adds an optional state_diagnose feature to mom6 nuopc cap to write the min,max and sum of the import and export fields. This feature is controlled by a debug flag which can be set at run time using a new setting in the nems.configure. If the flag does not exist in the nems.configure, no error will result and the debug flag will be set to the default value of 0 (no diagnose output will be generated.

  • A small change is introduced to read the restart setting from input.nml. This replicates current behavior but is now explicit.

  • No change to current baselines. Logs are posted at S2S-PR #155

co-author: @mvertens (state_diagnose code pulled from CICE6 nuopc/cmeps cap)

@jiandewang
Copy link
Copy Markdown
Collaborator

look good, do you have a run where I can take a look for the file which contains "min,max and sum of the import and export fields" information ?

Copy link
Copy Markdown
Collaborator

@JessicaMeixner-NOAA JessicaMeixner-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Admittedly I have not tested or run with this but the changes themselves look good.

@jiandewang
Copy link
Copy Markdown
Collaborator

this is a nice feature which will provide useful information when debugging. Since your runs passed all RT, I am going to approve it.

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

@jiandewang : Look at PET240 in this run on orion:

/work/noaa/stmp/dworthen/stmp/dworthen/S2S_RT/rt_108228/cpld_fv3_ccpp_mom6_cice_cmeps_2d_atm_flux

Import state variables are given by the ":IS:" lines and export state by the ":ES:" lines.

@jiandewang
Copy link
Copy Markdown
Collaborator

look nice, what does "12960" mean here ?
ES: sea_surface_temperature 0.000000 281.3567 204936.7 12960

@DeniseWorthen
Copy link
Copy Markdown
Collaborator Author

That is the number of values. I'm not sure why it is useful.

@DeniseWorthen DeniseWorthen merged commit 7e1188c into NOAA-EMC:dev/emc Aug 6, 2020
@DeniseWorthen DeniseWorthen deleted the feature/statediagnose branch January 15, 2021 16:38
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Jun 17, 2021
Merge in latest dev/gfdl updates
jiandewang pushed a commit to jiandewang/MOM6 that referenced this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants