Skip to content

cap update: supporting traditional and ESMF-managed threading#100

Closed
junwang-noaa wants to merge 1 commit into
NOAA-EMC:dev/emcfrom
junwang-noaa:esmfthrds
Closed

cap update: supporting traditional and ESMF-managed threading#100
junwang-noaa wants to merge 1 commit into
NOAA-EMC:dev/emcfrom
junwang-noaa:esmfthrds

Conversation

@junwang-noaa
Copy link
Copy Markdown

Code changes are made by Gerhard. The changes are to resolve an inconsistency between traditional and ESMF-managed threading under MOM6. Basically the original threading code tries to do some threading management locally in the cap, and through this essentially turns it off for the traditional approach. ESMF-managed does not suffer from it, because it manages threading on a lower level, and is unaffected by this code. But it does lead to the weird inconsistency that no matter what OMP_NUM_THREADS is set for traditional, MOM6 will always run single threaded. The local threading management code is removed in this PR.

Co-authored-by: Gerhard Theurich gerhard.j.theurich@noaa.gov

…anaged threading.

>
>
Co-authored-by: Gerhard Theurich <gerhard.j.theurich@noaa.gov>
@junwang-noaa
Copy link
Copy Markdown
Author

@theurich @jiandewang FYI.

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #100 (9cd55ac) into dev/emc (ec1d17e) will not change coverage.
The diff coverage is n/a.

❗ Current head 9cd55ac differs from pull request most recent head 5449ee7. Consider uploading reports for the commit 5449ee7 to get more accurate results

@@           Coverage Diff            @@
##           dev/emc     #100   +/-   ##
========================================
  Coverage    28.62%   28.62%           
========================================
  Files          252      252           
  Lines        73515    73515           
========================================
  Hits         21040    21040           
  Misses       52475    52475           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@jiandewang
Copy link
Copy Markdown
Collaborator

@junwang-noaa @theurich What I can see is that you removed those open-mp block in cap code, I will ask NCAR to do a pre-test to make sure the change will not break their system.
Your branch is based on 20220603 MOM6 main repo updating while there is another MOM6 main updating (20220729) which is in UFS commit queue. So I am going to make a branch based on 20220729 but adding your cap code change, in this way NCAR side can tell exactly what's being changed as dev/ncar is in parallel with 20220729 updating.

@junwang-noaa
Copy link
Copy Markdown
Author

@jiandewang Thank you for coordinating the code commit!

@jiandewang
Copy link
Copy Markdown
Collaborator

jiandewang commented Aug 9, 2022

@junwang-noaa we got greenlight from NCAR, so I am going to add your cap change in my pending MOM6 PR #99, and UFS PR ufs-community/ufs-weather-model#1358

@jiandewang
Copy link
Copy Markdown
Collaborator

this is done through #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants