Skip to content

Restore GDAS-validation functionality#118

Merged
RussTreadon-NOAA merged 2 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/jcb
May 10, 2024
Merged

Restore GDAS-validation functionality#118
RussTreadon-NOAA merged 2 commits into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/jcb

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented May 10, 2024

Incorporation of the JEDI Configuration Builder (JCB) tool via GDASApp PR #1033 and g-w PR #2477 broke the GDAS-validation tool. This PR restores GDAS-validation functionality.

Resolves #117

@RussTreadon-NOAA RussTreadon-NOAA self-assigned this May 10, 2024
@BrettHoover-NOAA
Copy link
Copy Markdown

Working on getting a run to complete with my leogeo satwind code. I am noticing some changes to YAML headers and some name-convention changes, such as a move from using satwind_ as a prefix to satwnd.. Once I can get leogeo to work and can review, I can go back through satwinds and make the necessary header and name-convention changes for all satwind types in a single PR, and I will include bringing our use of QI variable-names into compliance with JCSDA ObsSpace.yaml at the same time.

Copy link
Copy Markdown

@BrettHoover-NOAA BrettHoover-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code checks out for leogeo satwinds, I get identical results. Approving

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @BrettHoover-NOAA!

@RussTreadon-NOAA RussTreadon-NOAA merged commit 28803e8 into NOAA-EMC:develop May 10, 2024
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/jcb branch May 10, 2024 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update JEDI-T2O to work with JCB

2 participants