HYCOM initialization fixes for UFS debugging#2
Merged
Conversation
Issue HYCOM#15 noted cases where array1(:,:) = array2(:,:) trips a run time NaN check when the active array size (ii,jj) is smaller than the actual array size (idm,jdm). To avoid this, two arrays have been reinitialized.
aerorahul
force-pushed
the
emc/develop
branch
from
09bdf00 to
8d24702
Compare
BinLiu-NOAA
pushed a commit
that referenced
this pull request
Sep 13, 2022
Remove model_flag from NUOPC cap
BinLiu-NOAA
force-pushed
the
emc/develop
branch
from
8d24702 to
09bdf00
Compare
|
@MariaAristizabal-NOAA, @hyunsookkim-NOAA, and @BijuThomas-NOAA, please help to review the PR. This change is needed for HAFSv1 code freeze. Thanks! |
16 tasks
Collaborator
@BinLiu-NOAA The changes look good to me for adding debug option for HyCOM |
BinLiu-NOAA
approved these changes
Jan 12, 2023
BinLiu-NOAA
left a comment
BinLiu-NOAA
left a comment
There was a problem hiding this comment.
@BijuThomas-NOAA has tested and reviewed/approved these changes.
Looks good to me as well.
|
@BinLiu-NOAA ufs-community/ufs-weather-model#1544 is ready. So, go ahead to merge in this pr, please. |
|
sorry merged already! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinitialize arrays to avoid debugging NaN checks and allows for
-check allduringCMAKE_Fortran_FLAGS_DEBUGIssues Fixed
Cases where array1(:,:) = array2(:,:) trips a run time NaN check when the active array size (ii,jj) is smaller than the actual array size (idm,jdm). To avoid this, two arrays are reinitialized to non NaN values.
These changes were completed in collaboration with the NAVY HYCOM team.