Feature/add abi g19#869
Conversation
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
The changes in this PR look straightforward. Note that the GSI regression test cases are historical and, therefore, do not contain abi_g19. We will need to update at least some of the GSI regression test cases in order to routinely test abi_g19 with GSI ctests.
Some questions:
- Have we confirmed that the changes work as intended when abi_g19 data is available? I ask this question because of 2, 3, and 4 below.
global_satinfo.txtin NOAA-EMC/GSI-fixdevelopdoes not containabi_g19. Do we want to include an updatedfixsubmodule in this PR?global_scaninfo.txtin NOAA-EMC/GSI-fixdevelopdoes not containabi_g19. Same question as 2 - do we want to updatefixin this PR?- I do not see abi_g19 CRTM coefficients in the WCOSS2 fix directory for crtm/2.4.0.1
|
@HaixiaLiu-NOAA , I see in your PR description that you answer my question 1. Changes are being tested in a Hera parallel. What is the plan to get abi_g19 CRTM coefficients installed on WCOSS2 (question 4)? |
|
@RussTreadon-NOAA I asked @HaixiaLiu-NOAA to ensure the code changes are in at this stage. Turning on the observations in satinfo will be done in a later PR. We could add the scaninfo at this stage, but maybe we should do them together. I am working separately on getting the CRTM coefficients added. |
|
Thank you @ADCollard for sharing the plan moving forward. |
|
WCOSS2 ctests Install |
|
Sorry for the delay. Thanks @ADCollard for answering Russ's questions. I have modified both global_satinfo.txt and global_scaninfo.txt to include abi_g19 entries. The changes are in the update-fix-abi_g19 branch of my GSI-fix fork, with abi_g19 currently set to be monitored. Should I go ahead to create a PR in GSI-Fix repo? Thanks |
Thank you @HaixiaLiu-NOAA for updating satinfo and scaninfo. I agree. You can open a GSI-fix PR for these changes. Once the updated fix files are in GSI-fix |
Thank you @RussTreadon-NOAA . A GSI-fix PR #36 was opened for the fix file changes. |
Description
GOES-19 ABI Clear-Sky Radiance (CSR) products have been operationally available since April 7, 2025. Since then, the global dump gsrcsr has included radiances from both GOES-18 (GOES-West) and GOES-19 (GOES-East).
This PR updates two GSI read subroutines to include the satellite ID for GOES-19. It also makes corresponding changes to the regression test scripts by adding GOES-19 (G19) to the Obs_input list. These updates enable GSI to process GOES-19 ABI CSR data.
The associated issue is: #850
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
The regression tests have been conducted on Hera and all passed. Please Note: The default test data directory (/scratch1/NCEPDEV/da/Russ.Treadon/CASES/) does not contain GOES-19 CSR data, so identical results were expected between the control and experiment runs.
6 Test project /scratch1/NCEPDEV/stmp2/Haixia.Liu/GSI_abi_g19/build
Start 1: global_4denvar
Start 2: rtma
Start 3: rrfs_3denvar_rdasens
Start 4: hafs_4denvar_glbens
Start 5: hafs_3denvar_hybens
Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens ............. Passed 805.04 sec
2/6 Test #2: rtma ............................. Passed 1755.07 sec
3/6 Test #4: hafs_4denvar_glbens .............. Passed 1780.99 sec
4/6 Test #5: hafs_3denvar_hybens .............. Passed 1781.08 sec
5/6 Test #6: global_enkf ...................... Passed 1927.87 sec
6/6 Test #1: global_4denvar ................... Passed 2218.32 sec
100% tests passed, 0 tests failed out of 6
Total Test time (real) = 2218.34 sec
Meanwhile, I have already had a parallel experiment set up and running on Hera with these changes incorporated. The analysis results are as expected when the G19 CSR is either monitored or assimilated. The gsistat files from my control and experiment can be found on Hera:
G19 CSR is turned on starting with the 2025040906 cycle.
G19 CRTM coefficient files can be found at: /scratch1/NCEPDEV/da/Andrew.Collard/CRTM/fix_REL-3.1.1.3/fix
Checklist