Skip to content

Feature/add abi g19#869

Merged
RussTreadon-NOAA merged 3 commits into
NOAA-EMC:developfrom
HaixiaLiu-NOAA:feature/add_abi_G19
May 1, 2025
Merged

Feature/add abi g19#869
RussTreadon-NOAA merged 3 commits into
NOAA-EMC:developfrom
HaixiaLiu-NOAA:feature/add_abi_G19

Conversation

@HaixiaLiu-NOAA
Copy link
Copy Markdown
Contributor

@HaixiaLiu-NOAA HaixiaLiu-NOAA commented Apr 29, 2025

Description
GOES-19 ABI Clear-Sky Radiance (CSR) products have been operationally available since April 7, 2025. Since then, the global dump gsrcsr has included radiances from both GOES-18 (GOES-West) and GOES-19 (GOES-East).

This PR updates two GSI read subroutines to include the satellite ID for GOES-19. It also makes corresponding changes to the regression test scripts by adding GOES-19 (G19) to the Obs_input list. These updates enable GSI to process GOES-19 ABI CSR data.

The associated issue is: #850

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?
The regression tests have been conducted on Hera and all passed. Please Note: The default test data directory (/scratch1/NCEPDEV/da/Russ.Treadon/CASES/) does not contain GOES-19 CSR data, so identical results were expected between the control and experiment runs.

6 Test project /scratch1/NCEPDEV/stmp2/Haixia.Liu/GSI_abi_g19/build
Start 1: global_4denvar
Start 2: rtma
Start 3: rrfs_3denvar_rdasens
Start 4: hafs_4denvar_glbens
Start 5: hafs_3denvar_hybens
Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens ............. Passed 805.04 sec
2/6 Test #2: rtma ............................. Passed 1755.07 sec
3/6 Test #4: hafs_4denvar_glbens .............. Passed 1780.99 sec
4/6 Test #5: hafs_3denvar_hybens .............. Passed 1781.08 sec
5/6 Test #6: global_enkf ...................... Passed 1927.87 sec
6/6 Test #1: global_4denvar ................... Passed 2218.32 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 2218.34 sec

Meanwhile, I have already had a parallel experiment set up and running on Hera with these changes incorporated. The analysis results are as expected when the G19 CSR is either monitored or assimilated. The gsistat files from my control and experiment can be found on Hera:

  • control: /scratch1/NCEPDEV/da/Haixia.Liu/archive/g19csrc
  • experiment: /scratch1/NCEPDEV/da/Haixia.Liu/archive/g19csre

G19 CSR is turned on starting with the 2025040906 cycle.

G19 CRTM coefficient files can be found at: /scratch1/NCEPDEV/da/Andrew.Collard/CRTM/fix_REL-3.1.1.3/fix

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • New and existing tests pass with my changes
  • Any dependent changes have been merged and published

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review April 29, 2025 19:42
@RussTreadon-NOAA RussTreadon-NOAA linked an issue Apr 29, 2025 that may be closed by this pull request
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes in this PR look straightforward. Note that the GSI regression test cases are historical and, therefore, do not contain abi_g19. We will need to update at least some of the GSI regression test cases in order to routinely test abi_g19 with GSI ctests.

Some questions:

  1. Have we confirmed that the changes work as intended when abi_g19 data is available? I ask this question because of 2, 3, and 4 below.
  2. global_satinfo.txt in NOAA-EMC/GSI-fix develop does not contain abi_g19. Do we want to include an updated fix submodule in this PR?
  3. global_scaninfo.txt in NOAA-EMC/GSI-fix develop does not contain abi_g19. Same question as 2 - do we want to update fix in this PR?
  4. I do not see abi_g19 CRTM coefficients in the WCOSS2 fix directory for crtm/2.4.0.1

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@HaixiaLiu-NOAA , I see in your PR description that you answer my question 1. Changes are being tested in a Hera parallel. What is the plan to get abi_g19 CRTM coefficients installed on WCOSS2 (question 4)?

@ADCollard
Copy link
Copy Markdown
Collaborator

@RussTreadon-NOAA I asked @HaixiaLiu-NOAA to ensure the code changes are in at this stage. Turning on the observations in satinfo will be done in a later PR. We could add the scaninfo at this stage, but maybe we should do them together.

I am working separately on getting the CRTM coefficients added.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Thank you @ADCollard for sharing the plan moving forward.

@RussTreadon-NOAA RussTreadon-NOAA self-requested a review May 1, 2025 14:29
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve.

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

WCOSS2 ctests

Install HaixiaLiu-NOAA:feature/add_abi_G19 at b7bf2c1 along with develop at d635cb9

Test project /lfs/h2/emc/da/noscrub/russ.treadon/git/gsi/pr869/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  674.15 sec
2/6 Test #6: global_enkf ......................   Passed  858.40 sec
3/6 Test #2: rtma .............................   Passed  977.16 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  985.89 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  1225.12 sec
6/6 Test #1: global_4denvar ...................   Passed  1684.09 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 1684.10 sec

@HaixiaLiu-NOAA
Copy link
Copy Markdown
Contributor Author

Sorry for the delay. Thanks @ADCollard for answering Russ's questions. I have modified both global_satinfo.txt and global_scaninfo.txt to include abi_g19 entries. The changes are in the update-fix-abi_g19 branch of my GSI-fix fork, with abi_g19 currently set to be monitored. Should I go ahead to create a PR in GSI-Fix repo? Thanks

@RussTreadon-NOAA RussTreadon-NOAA merged commit aea2e2d into NOAA-EMC:develop May 1, 2025
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

Sorry for the delay. Thanks @ADCollard for answering Russ's questions. I have modified both global_satinfo.txt and global_scaninfo.txt to include abi_g19 entries. The changes are in the update-fix-abi_g19 branch of my GSI-fix fork, with abi_g19 currently set to be monitored. Should I go ahead to create a PR in GSI-Fix repo? Thanks

Thank you @HaixiaLiu-NOAA for updating satinfo and scaninfo. I agree. You can open a GSI-fix PR for these changes. Once the updated fix files are in GSI-fix develop a GSI PR can be opened to update the fix submodule.

@HaixiaLiu-NOAA
Copy link
Copy Markdown
Contributor Author

Sorry for the delay. Thanks @ADCollard for answering Russ's questions. I have modified both global_satinfo.txt and global_scaninfo.txt to include abi_g19 entries. The changes are in the update-fix-abi_g19 branch of my GSI-fix fork, with abi_g19 currently set to be monitored. Should I go ahead to create a PR in GSI-Fix repo? Thanks

Thank you @HaixiaLiu-NOAA for updating satinfo and scaninfo. I agree. You can open a GSI-fix PR for these changes. Once the updated fix files are in GSI-fix develop a GSI PR can be opened to update the fix submodule.

Thank you @RussTreadon-NOAA . A GSI-fix PR #36 was opened for the fix file changes.

xyzemc pushed a commit to xyzemc/GSI_develop-v16-tms that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add abi_g19 CSR

4 participants