Skip to content

add option to ignore qm=9 for T2m and q2m in prepbufr files. #866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
RussTreadon-NOAA merged 5 commits into from
Apr 22, 2025
Merged

add option to ignore qm=9 for T2m and q2m in prepbufr files. #866

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
eb59d57
add option to ignore qm=9 for T2m and q2m in prepbufr files.
ClaraDraper-NOAA Apr 16, 2025
14cf117
Output ignore_2mQM and hofx_2m_sfcfile to stdout.
ClaraDraper-NOAA Apr 17, 2025
19211dd
Update fix hash.
ClaraDraper-NOAA Apr 18, 2025
6d24286
Removed ovs type 183 from global_2m_land
ClaraDraper-NOAA Apr 18, 2025
05b07b8
Updated fix hash to include reject list.
ClaraDraper-NOAA Apr 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/gsi/gsimod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,7 +107,7 @@ module gsimod
factv,factl,factp,factg,factw10m,facthowv,factcldch,niter,niter_no_qc,biascor,&
init_jfunc,qoption,cwoption,switch_on_derivatives,tendsflag,jiterstart,jiterend,R_option,&
bcoption,diurnalbc,print_diag_pcg,tsensible,diag_precon,step_start,pseudo_q2,&
clip_supersaturation,cnvw_option,hofx_2m_sfcfile
clip_supersaturation,cnvw_option,hofx_2m_sfcfile, ignore_2mQM
use state_vectors, only: init_anasv,final_anasv
use control_vectors, only: init_anacv,final_anacv,nrf,nvars,nrf_3d,cvars3d,cvars2d,&
nrf_var,lcalc_gfdl_cfrac,incvars_to_zero,incvars_zero_strat,incvars_efold
Expand Down Expand Up @@ -1087,9 +1087,16 @@ module gsimod
! time_window_rad - upper limit on time window for certain radiance input data
! ext_sonde - logical for extended forward model on sonde data
! l_foreaft_thin - separate TDR fore/aft scan for thinning
! hofx_2m_sfcfile - Calculate h(x) for q2m and T2m from
Comment thread
RussTreadon-NOAA marked this conversation as resolved.
! same fields in sfc_data.tile files
! (for use in global 2m DA)
! ignore_2mQM - ignore quality mark of 9 (no obs errors)
! for T2m and q2m in prepbufr file, and
! insert hard-coded obs errors (for reanalysis,
! allows use of archived prepbufr files)

namelist/obs_input/dmesh,time_window_max,time_window_rad, &
ext_sonde,l_foreaft_thin,hofx_2m_sfcfile
ext_sonde,l_foreaft_thin,hofx_2m_sfcfile, ignore_2mQM

! SINGLEOB_TEST (one observation test case setup):
! maginnov - magnitude of innovation for one ob
Expand Down
5 changes: 5 additions & 0 deletions src/gsi/jfunc.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,11 +137,13 @@ module jfunc
public :: varq
public :: cnvw_option
public :: hofx_2m_sfcfile
public :: ignore_2mQM

logical first,last,switch_on_derivatives,tendsflag,print_diag_pcg,tsensible,diag_precon
logical clip_supersaturation,R_option
logical pseudo_q2,limitqobs
logical hofx_2m_sfcfile
logical ignore_2mQM
logical cnvw_option
integer(i_kind) iout_iter,miter,iguess,nclen,qoption,cwoption
integer(i_kind) jiter,jiterstart,jiterend,iter
Expand Down Expand Up @@ -254,6 +256,9 @@ subroutine init_jfunc
! option to calculate hofx for T2m and q2m by interpolating from 2m vars in sfc file
hofx_2m_sfcfile=.false.

! option to ignore qm=9 in prepbufr file for T2m and q2m
ignore_2mQM=.false.

return
end subroutine init_jfunc

Expand Down
8 changes: 4 additions & 4 deletions src/gsi/read_prepbufr.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,7 +219,7 @@ subroutine read_prepbufr(nread,ndata,nodata,infile,obstype,lunout,twindin,sis,&
apply_hilbertcurve,destroy_hilbertcurve
use ndfdgrids,only: init_ndfdgrid,destroy_ndfdgrid,relocsfcob,adjust_error
use ndfdgrids,only: valley_adjustment
use jfunc, only: tsensible, hofx_2m_sfcfile
use jfunc, only: tsensible, hofx_2m_sfcfile, ignore_2mQM
use deter_sfc_mod, only: deter_sfc_type,deter_sfc2
use gsi_nstcouplermod, only: nst_gsi,nstinfo
use gsi_nstcouplermod, only: gsi_nstcoupler_deter
Expand Down Expand Up @@ -2012,17 +2012,17 @@ subroutine read_prepbufr(nread,ndata,nodata,infile,obstype,lunout,twindin,sis,&

! Over-ride QM=9 and hard-wire errors for land obs and hofx_sfc_file option
! Can be deleted once prepbufr processing updated.
if ( global_2m_land ) then
if ( global_2m_land .and. ignore_2mQM ) then
if (tob .and. qm==9 ) then
pqm(k)=2 ! otherwise, type 183 will be discarded.
qm=2
tqm(k)=2
if (kx==187) obserr(3,k)=2.0_r_double
if (kx==181) obserr(3,k)=2.0_r_double
if (kx==183) obserr(3,k)=2.0_r_double

@jiaruidong2017 jiaruidong2017 Apr 18, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
if (kx==183) obserr(3,k)=2.0_r_double

Do you think it is necessary to discard the obs type 183 and keep consistent with new obs error table? If yes, please make change for the qob case below.

@ClaraDraper-NOAA ClaraDraper-NOAA Apr 18, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I removed 183 from the global_2m_land option higher up.

endif
if (qob .and. qm == 9 ) then
qm = 2
qm=2
qqm(k) = 2
! qob err specified as fraction of qsat, multiplied by 10.
if (kx==187) obserr(2,k)=1.0_r_double
if (kx==181) obserr(2,k)=1.0_r_double
Expand Down