Skip to content

update GSI_BINARY_SOURCE_DIR for Hercules and Orion (#851)#852

Merged
RussTreadon-NOAA merged 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/msu_path
Mar 25, 2025
Merged

update GSI_BINARY_SOURCE_DIR for Hercules and Orion (#851)#852
RussTreadon-NOAA merged 1 commit into
NOAA-EMC:developfrom
RussTreadon-NOAA:feature/msu_path

Conversation

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor

@RussTreadon-NOAA RussTreadon-NOAA commented Mar 24, 2025

Description

Update the GSI_BINARY_SOURCE_DIR path in the Hercules and Orion modulefiles. This change is required by changes merged into g-w develop via g-w PR #3488.

Resolves #851

Type of change

  • Maintenance (fix to maintain existing functionality)

How Has This Been Tested?

Install RussTreadon-NOAA/GSI:feature/msu_path on Orion. Run ctests. All tests pass.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • New and existing tests pass with my changes

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

This PR will be placed in draft mode until the ctests are complete. Hercules and Orion are both experiencing increased run time for jobs. It may take a while to get successful GSI ctests on Orion or Hercules.

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as draft March 24, 2025 15:19
Copy link
Copy Markdown

@KateFriedman-NOAA KateFriedman-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated paths are good, thanks @RussTreadon-NOAA !

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Hercules ctests

Install feature/msu_path at e89718c along with develop at b25de8c on Hercules. Run ctests with the following results

Test project /work/noaa/da/rtreadon/git/gsi/msu_path/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  545.67 sec
2/6 Test #6: global_enkf ......................   Passed  785.27 sec
3/6 Test #2: rtma .............................   Passed  2285.31 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  3192.96 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  3258.13 sec
6/6 Test #1: global_4denvar ...................   Passed  4261.73 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 4261.74 sec

@RussTreadon-NOAA RussTreadon-NOAA marked this pull request as ready for review March 24, 2025 17:07
@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

GSI ctests ran much faster on Hercules than I expected. As expected the ctests Passed. This PR is ready for review, approval, and merger into GSI develop.

Copy link
Copy Markdown
Collaborator

@DavidHuber-NOAA DavidHuber-NOAA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @RussTreadon-NOAA!

@RussTreadon-NOAA
Copy link
Copy Markdown
Contributor Author

Thank you @KateFriedman-NOAA and @DavidHuber-NOAA for your reviews & approvals. Merging now.

@RussTreadon-NOAA RussTreadon-NOAA merged commit c7817c3 into NOAA-EMC:develop Mar 25, 2025
@RussTreadon-NOAA RussTreadon-NOAA deleted the feature/msu_path branch March 25, 2025 11:35
xyzemc pushed a commit to xyzemc/GSI_develop-v16-tms that referenced this pull request Feb 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update GSI_BINARY_SOURCE_DIR on MSU

3 participants