Adding I/O interfaces in GSI for Analysis of Significant Wave Height (HOWV) and near-surface Wind Gust (GUST) for WRF-ARW based 3DRTMA by GangZhao-NOAA · Pull Request #835 · NOAA-EMC/GSI

GangZhao-NOAA · 2025-02-07T18:20:43Z

Description

Motivation:

The analysis of significant wave height (HOWV) and 10-m wind gust (GUST) are listed as standard product in the operational (2D)RTMA/URMA product suites. To keep providing these two products in next generation RTMA/URMA (ie, 3DRTMA) system, the capability to directly analyze wave height and wind gust must be added into GSI 3DVar analysis.

Method:

The kernel part of the analysis code (such as stphowv.f90, setuphowv.f90, inthowv.f90, gsi_howvOper.f90 and m_howvNode.f90 for HOWV, and similar code for GUST) for wave height and wind gust had already been introduced into GSI through the implementation of 2DRTMA. So most of the code work for analysis of HOWV and GUST in 3DVar, are mainly focused on the I/O interfaces for the firstguess provided by various models (i.e. reading background of HOWV/GUST from firstguess file and writing the updated HOWV/GUST back to the final analysis file).
The I/O interfaces for FV3-LAM model based firstguess had been done in previous work (see issue Adding I/O for Analysis of Significant Wave Height for 3DRTMA #601 and issue Adding I/O for direct analysis of near-surface wind gust for RRFS-based 3DRTMA #726). Since RRFS-3DRTMAv1 has been switched to be based on HRRR model, so in this work, some efforts are made to add the I/O interfaces in GSI for WRF-ARW model based firstguess.

here is a Google document drafted as a brief note on the code changes.

Related Issues:

This Pull Request is to resolve issue Adding I/O interfaces in GSI for Analysis of Significant Wave Height (HOWV) and near-surface Wind Gust (GUST) for WRF-ARW based 3DRTMA #834

Resolves #834

Type of change

Please delete options that are not relevant.

New feature (non-breaking change which adds functionality)

How Has This Been Tested?

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
New and existing tests pass with my changes
Any dependent changes have been merged and published
Regression tests on WCOSS2 (Cactus) and Hera (Rocky-8) : my updated GSI commit #47b3115) vs control/original GSI code (commit #92165a4)
Here is the reports of the regression tests on WCOSS2 (Dogwood):

[gang.zhao@dlogin09:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -N
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/ProdGSI_dev/gsi_dev/build
  Test #1: global_4denvar
  Test #2: rtma
  Test #3: rrfs_3denvar_rdasens
  Test #4: hafs_4denvar_glbens
  Test #5: hafs_3denvar_hybens
  Test #6: global_enkf

Total Tests: 6
[gang.zhao@dlogin09:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -j 6
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/ProdGSI_dev/gsi_dev/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  1155.27 sec
2/6 Test #5: hafs_3denvar_hybens ..............   Passed  1586.49 sec
3/6 Test #4: hafs_4denvar_glbens ..............   Passed  1650.16 sec
4/6 Test #6: global_enkf ......................   Passed  1957.18 sec
5/6 Test #2: rtma .............................   Passed  3319.15 sec
6/6 Test #1: global_4denvar ...................   Passed  3546.50 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 3546.52 sec

Here is the reports of the regression tests on Hera:

(work-env2) [Gang.Zhao@hfe01:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -N
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
  Test #1: global_4denvar
  Test #2: rtma
  Test #3: rrfs_3denvar_rdasens
  Test #4: hafs_4denvar_glbens
  Test #5: hafs_3denvar_hybens
  Test #6: global_enkf

Total Tests: 6
(work-env2) [Gang.Zhao@hfe01:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -j 6
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 4: hafs_4denvar_glbens
    Start 1: global_4denvar
    Start 6: global_enkf
    Start 5: hafs_3denvar_hybens
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
1/6 Test #3: rrfs_3denvar_rdasens .............***Failed  2218.19 sec
2/6 Test #5: hafs_3denvar_hybens ..............   Passed  3687.92 sec
3/6 Test #2: rtma .............................   Passed  3828.48 sec
4/6 Test #4: hafs_4denvar_glbens ..............   Passed  4112.07 sec
5/6 Test #1: global_4denvar ...................   Passed  4118.91 sec
6/6 Test #6: global_enkf ......................   Passed  4119.37 sec

83% tests passed, 1 tests failed out of 6

Total Test time (real) = 4119.38 sec

The following tests FAILED:
          3 - rrfs_3denvar_rdasens (Failed)
Errors while running CTest
Output from these tests are in: /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build/Testing/Temporary/LastTest.log
Use "--rerun-failed --output-on-failure" to re-run the failed cases verbosely.
(work-env2) [Gang.Zhao@hfe01:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -R rrfs_3denvar_rdasens
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 3: rrfs_3denvar_rdasens
1/1 Test #3: rrfs_3denvar_rdasens .............   Passed  619.88 sec

100% tests passed, 0 tests failed out of 1

Total Test time (real) = 619.90 sec

ARW-ARW model forecast as firstguess.

firstguess file, then the execution of code is aborted, instead of just printing out the error message.

…avhgtwndgst_wrfarw

TingLei-NOAA · 2025-02-07T22:51:57Z

@GangZhao-NOAA Thanks. Your inline comments are good and I just wondered if there are already existing options for user to do the inflation. If there is no, that is ok. That comment will help users/developer understand the situation.

TingLei-NOAA

Thanks for continual enhancements of GSI

GangZhao-NOAA · 2025-02-08T03:00:14Z

@GangZhao-NOAA Thanks. Your inline comments are good and I just wondered if there are already existing options for user to do the inflation. If there is no, that is ok. That comment will help users/developer understand the situation.

@TingLei-NOAA Hi Ting, I realized that I should not use the word "inflat" here, since "covariance inflation" is somehow a specific term used in ensemble DA. I will change it to "increase" in my next PR. Since the process to increase the static error for HOWV and GUST are done outside of GSI code, not in GSI, so I'd better remove these comments in my next PR. Thank you again!

RussTreadon-NOAA

Did not test code. Most comments are minor.

Question: Do any of the existing GSI ctests exercise the functionality added by this PR? If not, (a) how do we know the changes work as intended? and (b) what's the strategy to ensure future PRs do not break the functionality added by this PR?

…avhgtwndgst_wrfarw

GangZhao-NOAA · 2025-02-14T16:33:44Z

Did not test code. Most comments are minor.

Question: Do any of the existing GSI ctests exercise the functionality added by this PR? If not, (a) how do we know the changes work as intended? and (b) what's the strategy to ensure future PRs do not break the functionality added by this PR?

@RussTreadon-NOAA
Hi Russ,

Did not test code. Most comments are minor.

This code was tested with a real case data (2024-12-12_00z)

Question: Do any of the existing GSI ctests exercise the functionality added by this PR?

As you pointed out, NONE of the existing GSI ctests exercises the functionality added by this PR.

If not, (a) how do we know the changes work as intended?

This code was tested with a real case data (2024-12-12_00z) with the added functionality (analyzing wave height and wind gust in hybrid 3DEnVar with HRRR-based first guess). And it passed all the 6 existing ctests (regression test) in current GSI package.

(b) what's the strategy to ensure future PRs do not break the functionality added by this PR?

Thank you for pointing out this question! I discussed with Manuel (@ManuelPondeca-NOAA). We should add a new ctest item for the new functionalities added for 3DRTMA. We are busy with current HRRR-3DRTMA workflow project, so we cannot provide such kind of ctest for now. We will do it in the near future.

minor changes suggested by code reviewers. With version control on github along with well documented issues, added changelog entries to source code is no longer needed.

GangZhao-NOAA · 2025-02-14T17:23:46Z

@guoqing-noaa @TingLei-NOAA @ShunLiu-NOAA @RussTreadon-NOAA
Hi Guoqing, Ting, Shun and Russ,

Following your questions/suggestions/comments, I modified the code and re-submitted the PR #835 for review. Most of the updated part are in the comments, so there should be no essential differences, comparing to the previous commit. If you have time, could you please make another round code review on these newly-updated code?

I am running all the 6 existing ctests of GSI on Hera now, and will run ctests on WCOSS2 very soon this afternoon. Then I will update the new reports from the ctests here.

Thank you very much for your help!

-Gang

RussTreadon-NOAA

Thank you @GangZhao-NOAA for updating the code. Changes look good.

GangZhao-NOAA · 2025-02-14T21:53:49Z

While this PR is under review, the GSI main branch (develop) was updated to commit #8e54642. So I merged that latest update into my code, and then following the suggestions & comments from reviewers, made some modifications to the code. Now this PR #835 is to merge my latest commit #94bed49 (in branch "feature/rtma3d_wavhgtwndgst_wrfarw") to EMC-GSI. Due to these new changes to the code, I re-ran the ctests on Hera and WCOSS2 (Cactus):

Regression tests on WCOSS2 (Cactus) and Hera: my latest GSI commit #94bed49 vs last EMC-GSI commit #8e54642
Here is the reports of the ctest (regression tests) on Hera:

(work-env2) [Gang.Zhao@hfe04:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -N
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
  Test #1: global_4denvar
  Test #2: rtma
  Test #3: rrfs_3denvar_rdasens
  Test #4: hafs_4denvar_glbens
  Test #5: hafs_3denvar_hybens
  Test #6: global_enkf

Total Tests: 6
(work-env2) [Gang.Zhao@hfe04:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -j 6
Test project /scratch1/NCEPDEV/da/Gang.Zhao/ProdGSI_dev/gsi_dev/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  681.04 sec
2/6 Test #2: rtma .............................   Passed  2233.63 sec
3/6 Test #6: global_enkf ......................   Passed  2467.64 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  2486.48 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  2607.95 sec
6/6 Test #1: global_4denvar ...................   Passed  3900.66 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 3900.68 sec

Here is the reports of the ctest (regression tests) running on WCOSS2 (Cactus):

[gang.zhao@clogin01:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -N
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/ProdGSI_Dev/gsi_dev/build
  Test #1: global_4denvar
  Test #2: rtma
  Test #3: rrfs_3denvar_rdasens
  Test #4: hafs_4denvar_glbens
  Test #5: hafs_3denvar_hybens
  Test #6: global_enkf

Total Tests: 6
[gang.zhao@clogin01:build] (feature/rtma3d_wavhgtwndgst_wrfarw)$ ctest -j 6
Test project /lfs/h2/emc/da/save/gang.zhao/WorkDir/ProdGSI_Dev/gsi_dev/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  919.52 sec
2/6 Test #5: hafs_3denvar_hybens ..............   Passed  1356.76 sec
3/6 Test #2: rtma .............................   Passed  1641.96 sec
4/6 Test #4: hafs_4denvar_glbens ..............   Passed  1648.40 sec
5/6 Test #6: global_enkf ......................   Passed  1678.64 sec
6/6 Test #1: global_4denvar ...................   Passed  2286.87 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 2286.96 sec

RussTreadon-NOAA

Ctests pass on WCOSS2 and Hera.

Approve.

ShunLiu-NOAA · 2025-02-14T23:09:48Z

Ctests pass on WCOSS2 and Hera.

Approve.

Russ, Thank you for running ctest on WCOSS2 and Hera.

ShunLiu-NOAA · 2025-02-14T23:12:22Z

@TingLei-NOAA Could you review the new changes of this PR?

EdwardColon-NOAA

The issues related to code documentation and potentially excessive print calls have previously been resolved. Approve.

RussTreadon-NOAA · 2025-02-15T10:23:14Z

Ctests pass on WCOSS2 and Hera.
Approve.

Russ, Thank you for running ctest on WCOSS2 and Hera.

Credit goes to @GangZhao-NOAA for rerunning ctests on WCOSS2 and Hera. He also ran the first round of ctests. Thank you @GangZhao-NOAA for running the tests again. It was good to confirm that the code still behaves as expected after you integrated reviewers' input.

RussTreadon-NOAA · 2025-02-15T14:18:58Z

For the sake of completeness run ctests on Orion and Hercules. Results are posted below

Orion

Test project /work2/noaa/da/rtreadon/git/gsi/pr835/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #6: global_enkf ......................   Passed  1027.76 sec
2/6 Test #3: rrfs_3denvar_rdasens .............   Passed  1147.22 sec
3/6 Test #2: rtma .............................   Passed  1928.00 sec
4/6 Test #5: hafs_3denvar_hybens ..............   Passed  3022.20 sec
5/6 Test #4: hafs_4denvar_glbens ..............   Passed  3200.51 sec
6/6 Test #1: global_4denvar ...................   Passed  3721.97 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 3721.98 sec

Hercules

Test project /work/noaa/da/rtreadon/git/gsi/pr835/build
    Start 1: global_4denvar
    Start 2: rtma
    Start 3: rrfs_3denvar_rdasens
    Start 4: hafs_4denvar_glbens
    Start 5: hafs_3denvar_hybens
    Start 6: global_enkf
1/6 Test #3: rrfs_3denvar_rdasens .............   Passed  1865.70 sec
2/6 Test #6: global_enkf ......................   Passed  1925.50 sec
3/6 Test #5: hafs_3denvar_hybens ..............   Passed  2292.33 sec
4/6 Test #4: hafs_4denvar_glbens ..............   Passed  2842.59 sec
5/6 Test #2: rtma .............................   Passed  2885.18 sec
6/6 Test #1: global_4denvar ...................   Passed  3061.19 sec

100% tests passed, 0 tests failed out of 6

Total Test time (real) = 3061.20 sec

All ctests pass on both MSU machines.

GangZhao-NOAA · 2025-02-16T18:10:24Z

@RussTreadon-NOAA
Hi Russ,
Thank you so much for running the ctests on MSU machines and making the tests completeness! I am so grateful!
-Gang

…OAA-EMC#835)

GangZhao-NOAA added 4 commits January 30, 2025 06:28

Adding code to analyze wave height and wind gust for 3DRTMA when using

9e2a3ff

ARW-ARW model forecast as firstguess.

if howv (or gust) is set in anavinfo, but its data is not found in

796b173

firstguess file, then the execution of code is aborted, instead of just printing out the error message.

Merge remote-tracking branch 'upstream/develop' into feature/rtma3d_w…

d87be10

…avhgtwndgst_wrfarw

A trivial fix to a typo in comment.

47b3115

RussTreadon-NOAA requested review from AnnetteGibbs-NOAA, EdwardColon-NOAA, ManuelPondeca-NOAA, MatthewMorris-NOAA, TingLei-NOAA and guoqing-noaa February 7, 2025 18:35

RussTreadon-NOAA assigned GangZhao-NOAA and ShunLiu-NOAA Feb 7, 2025

guoqing-noaa approved these changes Feb 7, 2025

View reviewed changes

TingLei-NOAA reviewed Feb 7, 2025

View reviewed changes

Comment thread src/gsi/rapidrefresh_cldsurf_mod.f90 Outdated

TingLei-NOAA approved these changes Feb 7, 2025

View reviewed changes

ShunLiu-NOAA reviewed Feb 12, 2025

View reviewed changes

Comment thread src/gsi/cplr_wrwrfmassa.f90 Outdated

Comment thread src/gsi/cplr_wrwrfmassa.f90 Outdated

RussTreadon-NOAA reviewed Feb 12, 2025

View reviewed changes

Merge remote-tracking branch 'upstream/develop' into feature/rtma3d_w…

5ce20c4

…avhgtwndgst_wrfarw

GangZhao-NOAA commented Feb 14, 2025

View reviewed changes

Comment thread src/gsi/cplr_wrwrfmassa.f90 Outdated

GangZhao-NOAA commented Feb 14, 2025

View reviewed changes

Comment thread src/gsi/rapidrefresh_cldsurf_mod.f90 Outdated

GangZhao-NOAA commented Feb 14, 2025

View reviewed changes

Comment thread src/gsi/setuphowv.f90 Outdated

Clear off the new changelog entries introduced by PR#835, and a few

94bed49

minor changes suggested by code reviewers. With version control on github along with well documented issues, added changelog entries to source code is no longer needed.

GangZhao-NOAA requested review from RussTreadon-NOAA, ShunLiu-NOAA, TingLei-NOAA and guoqing-noaa February 14, 2025 17:23

RussTreadon-NOAA reviewed Feb 14, 2025

View reviewed changes

RussTreadon-NOAA self-requested a review February 14, 2025 23:06

RussTreadon-NOAA approved these changes Feb 14, 2025

View reviewed changes

EdwardColon-NOAA approved these changes Feb 14, 2025

View reviewed changes

guoqing-noaa approved these changes Feb 18, 2025

View reviewed changes

TingLei-NOAA approved these changes Feb 18, 2025

View reviewed changes

AnnetteGibbs-NOAA approved these changes Feb 19, 2025

View reviewed changes

MatthewMorris-NOAA approved these changes Feb 19, 2025

View reviewed changes

RussTreadon-NOAA merged commit 0ef8d87 into NOAA-EMC:develop Feb 20, 2025

RussTreadon-NOAA mentioned this pull request Feb 24, 2025

update GPSRO obs error and add additional data (new) #839

Merged

2 tasks

GangZhao-NOAA mentioned this pull request Mar 14, 2025

Add the capability to analyze wave height and 10-m wind gust into HRRR-3DRTMA package NOAA-EMC/NOAA_3drtma#32

Closed

xyzemc pushed a commit to xyzemc/GSI_develop-v16-tms that referenced this pull request Feb 27, 2026

Add I/O interfaces for HOWV and GUST analysis in WRF-ARW based RTMA (N…

138ac8e

…OAA-EMC#835)

Conversation

GangZhao-NOAA commented Feb 7, 2025 • edited by RussTreadon-NOAA Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

TingLei-NOAA commented Feb 7, 2025

Uh oh!

TingLei-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

GangZhao-NOAA commented Feb 8, 2025

Uh oh!

Uh oh!

Uh oh!

RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GangZhao-NOAA commented Feb 14, 2025

Uh oh!

GangZhao-NOAA commented Feb 14, 2025

Uh oh!

RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

GangZhao-NOAA commented Feb 14, 2025

Uh oh!

RussTreadon-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

ShunLiu-NOAA commented Feb 14, 2025

Uh oh!

ShunLiu-NOAA commented Feb 14, 2025

Uh oh!

EdwardColon-NOAA left a comment

Choose a reason for hiding this comment

Uh oh!

RussTreadon-NOAA commented Feb 15, 2025

Uh oh!

RussTreadon-NOAA commented Feb 15, 2025

Uh oh!

GangZhao-NOAA commented Feb 16, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

GangZhao-NOAA commented Feb 7, 2025 •

edited by RussTreadon-NOAA

Loading