Rrfs v1.0.0 of the release with non-functional changes in modules and openmp directives#826
Closed
TingLei-daprediction wants to merge 5 commits into
Closed
Conversation
Contributor
|
@TingLei-daprediction , GSI issues require an issue. Which issue(s) are associated with the draft PR? |
Contributor
Author
|
Russ
I will open an issue for this draft pr and the previous one as soon as
possible . Thanks
Ting
…On Thu, Jan 30, 2025 at 8:29 AM RussTreadon-NOAA ***@***.***> wrote:
@TingLei-daprediction <https://github.com/TingLei-daprediction> , GSI
issues require an issue. Which issue(s) are associated with the draft PR?
—
Reply to this email directly, view it on GitHub
<#826 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADSYWF7ZAQOTNECEJK5FGCT2NISLVAVCNFSM6AAAAABWATZSF6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRUGUZDANRUGA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Contributor
|
FYI: gitub CI fails for |
Contributor
Author
|
This draft would be revoked for being now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This draft PR shows non-functional changes in compiling options and openmp directives to allow the PR #811 to pass the current ctests ( this PR also need similar non-functional changes, a corresponding draft PR would be submitted soon).
These draft PR are for evaluation/discussion of RRFS GSI developer to decide the efficient way to incorporate the optimization function in the above PR 811.