update fix submodule hash to include gfs.v16.3.9 updates#621
Conversation
… global_convinfo.txt and global_ozinfo.txt (#620)
…1858) GFS v16.3.9 was implemented 20230911 12Z. The following changes were implemented into operations: - turns off ingest of NOAA-21 radiances into the GSI, - PlanetIQ GPSRO and NOAA-20 OMPS (Ozone Mapping and Profiler Suite) Ozone retrievals will be actively assimilated, - OMPS observation errors will be adjusted. g-w PR #1852 brought these changes into g-w branch [`dev/gfs.v16`](https://github.com/NOAA-EMC/global-workflow/tree/dev/gfs.v16). This PR brings the same changes into g-w `develop`. Fixes #1856 Fixes #1857 Related to, but not dependent on, GSI [#621](NOAA-EMC/GSI#621)
|
Ctests have been run on Orion with results posted and discussed in issue #620. No tests failed due to generating different analysis results. This result was at first puzzling. The As a test, modify the global_3dvar test to use the fix files associated with gsi version being run: updat gsi.x using updat fix, contrl gsi.x using contrl fix. With this change, the ozone penalties differ and, therefore, the analyses differ. This is expected. The Orion ctests confirm the appropriate behavior. Since by default the ctest scripts use the updat fix opt to not run ctests on Hera or WCOSS2. The no-impact result observed on Orion will be likewise found on these platforms. |
|
@RussTreadon-NOAA Thank you for the detailed documentations in this PR and in issue #620 . The changes to the 2 fix files look good to me. |
HaixiaLiu-NOAA
left a comment
HaixiaLiu-NOAA
left a comment
There was a problem hiding this comment.
changes look good. Approving
XuanliLi-NOAA
left a comment
XuanliLi-NOAA
left a comment
There was a problem hiding this comment.
convinfo file looks to me.
|
Thank you @HaixiaLiu-NOAA and @XuanliLi-NOAA for your reviews and approvals. I'll work with the Handling Review team to get this PR merged into |
**Description** This PR updates the `fix` submodule to bring in GFS v16.3.9 updates to `global_convinfo.txt` and `global_ozinfo.txt`. Issue NOAA-EMC#620 provides additional information on the GFS v16.3.9 updates. Please **note** the following - The change to `global_ozinfo.txt` alters analysis results if ompsnp observation from NOAA-20, NOAA-21, or NPP are processed by gsi.x or `enkf.x`. - The change to `global_convinfo.txt` alters analysis results if PlanetIQ GPSRO (type 267) is processed by `gsi.x` or `enkf.x`. Fixes NOAA-EMC#620 **Type of change** - [x] Breaking change (fix or feature that would cause existing functionality to not work as expected) See the **Note** above for potential impact on analysis results. **How Has This Been Tested?** ctests have been run on Hera, Orion, and WCOSS2 (Cactus) with results posted in issue NOAA-EMC#620. **Checklist** - [x] My code follows the style guidelines of this project - [x] I have performed a self-review of my own code
4 participants
Description
This PR updates the
fixsubmodule to bring in GFS v16.3.9 updates toglobal_convinfo.txtandglobal_ozinfo.txt. Issue #620 provides additional information on the GFS v16.3.9 updates.Please note the following
global_ozinfo.txtalters analysis results if ompsnp observation from NOAA-20, NOAA-21, or NPP are processed by gsi.x orenkf.x.global_convinfo.txtalters analysis results if PlanetIQ GPSRO (type 267) is processed bygsi.xorenkf.x.Fixes #620
Type of change
See the Note above for potential impact on analysis results.
How Has This Been Tested?
ctests have been run on Hera, Orion, and WCOSS2 (Cactus) with results posted in issue #620.
Checklist