Turn on NOAA-20 OMPS and PlanetIQ in operations#613
Conversation
|
@RussTreadon-NOAA I am not sure why the scripts change is in this PR. I thought this was already merged. |
ADCollard
requested review from
HaixiaLiu-NOAA,
RussTreadon-NOAA and
XuanliLi-NOAA
| sstviirs viirs-m npp viirs-m_npp 0.0 4 0 | ||
| sstviirs viirs-m j1 viirs-m_j1 0.0 4 0 | ||
| ahibufr ahi himawari9 ahi_himawari9 0.0 1 0 | ||
| atmsbufr atms n21 atms_n21 0.0 1 1 |
There was a problem hiding this comment.
The atms_n21 and cris-fsr_n21 lines were removed from exglobal_atmos_analysis.sh via PR #611. Why are we seeing them removed again?
A check of ADCollard:release/gfsda.v16 shows
the branch is 1 commit behind NOAA-EMC:release/gfsda.v16.
We should update ADCollard:release/gfsda.v16 with the current head of NOAA-EMC/release/gfsda.v16. If we do so the change to exglobal_atmos_analysis.sh in this PR should disappear.
…into release/gfsda.v16 Syncing main repository with ADCollard fork
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
As expected, the only change is the update to the fix submodule hash.
I cloned ADCollard:release/gfsda.v16 and NOAA-EMC:release/gfsda.v16. The only differences are in the following files
fix/global_convinfo.txtfix/global_ozinfo.txt
ADCollard:release/gfsda.v16 global_convinfo.txt places gps 267 in assimilate mode. The global_ozinfo.txt (a) places ompsnp_n20 in assimilate mode and (b) changes omps errors.
These appear to be the correct changes. Approve.
Merger of this PR into NOAA-EMC:release/gfsda.v16 is awaiting confirmation from @XuanliLi-NOAA and @HaixiaLiu-NOAA that the fix file changes in this PR are correct.
|
@RussTreadon-NOAA Thanks, that seemed to work. |
|
@ADCollard , I'll create tag |
|
No, please re-create gfsda.v16.3.8
Thanks!
Andrew.
…On Fri, Aug 18, 2023 at 1:09 PM RussTreadon-NOAA ***@***.***> wrote:
@ADCollard <https://github.com/ADCollard> , I'll create tag gfsda.v16.3.9
once this PR is merged into NOAA-EMC:release/gfsda.v16. Is 16.3.9 the
correct version?
—
Reply to this email directly, view it on GitHub
<#613 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AJTUMJDY3K4J4CU4NOQLTTTXV6OUDANCNFSM6AAAAAA3VXREG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Oops, glad I asked. I thought we had two sequential implementations. Not so. We're lumping them together. That's easier for NCO. |
|
Yes, I was very surprised when Steven said yes to this! |
|
Some surprises are good. I'll merge this PR into |
|
Create tag gfsda.v16.3.8 as a copy of release/gfsda.v16 at fe08709 |
|
Thankyou @RussTreadon-NOAA ! |
HaixiaLiu-NOAA
left a comment
HaixiaLiu-NOAA
left a comment
There was a problem hiding this comment.
I can now confirm that the global_ozinfo.txt contains correct obs errors for OMPSNP and iuse as well. Approve now.
4 participants
Fix file changes to turn on PlanetIQ GPSRO and NOAA-20 OMPS data in operations.
New feature (non-breaking change which adds functionality)
Tested in operational global workflow.
Checklist
My code follows the style guidelines of this project
I have performed a self-review of my own code
I have commented my code, particularly in hard-to-understand areas
New and existing tests pass with my changes
Any dependent changes have been merged and published