Skip to content

GitHub Issue NOAA-EMC/GSI#538 Add options to tune weights of mixed ensemble for FV3-LAM EnVar #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShunLiu-NOAA merged 1 commit into from
Mar 17, 2023
Merged

GitHub Issue NOAA-EMC/GSI#538 Add options to tune weights of mixed ensemble for FV3-LAM EnVar #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/gsi/cplr_get_fv3_regional_ensperts.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ subroutine get_fv3_regional_ensperts_run(this,en_perts,nelen,ps_bar)
use constants, only: zero,one,half,zero_single,rd_over_cp,one_tenth
use mpimod, only: mpi_comm_world,ierror,mype,npe
use hybrid_ensemble_parameters, only: n_ens,grd_ens,parallelization_over_ensmembers
use hybrid_ensemble_parameters, only: l_both_fv3sar_gfs_ens, n_ens_gfs,n_ens_fv3sar
use hybrid_ensemble_parameters, only: l_both_fv3sar_gfs_ens,n_ens_gfs,n_ens_fv3sar,weight_ens_fv3sar
use hybrid_ensemble_parameters, only: ntlevs_ens,ensemble_path
use control_vectors, only: cvars2d,cvars3d,nc2d,nc3d
use gsi_bundlemod, only: gsi_bundlecreate
Expand Down Expand Up @@ -674,7 +674,7 @@ subroutine get_fv3_regional_ensperts_run(this,en_perts,nelen,ps_bar)
!
!
! CONVERT ENSEMBLE MEMBERS TO ENSEMBLE PERTURBATIONS
sig_norm=sqrt(one/max(one,n_ens_fv3sar-one))
sig_norm=sqrt(weight_ens_fv3sar/max(one,n_ens_fv3sar-one))

do n=imem_start,n_ens
do i=1,nelen
Expand Down
4 changes: 2 additions & 2 deletions src/gsi/get_gefs_for_regional.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ subroutine get_gefs_for_regional
fv3_regional
use hybrid_ensemble_parameters, only: region_lat_ens,region_lon_ens
use hybrid_ensemble_parameters, only: en_perts,ps_bar,nelen
use hybrid_ensemble_parameters, only: n_ens_gfs,grd_ens,grd_a1,grd_e1,p_e2a,uv_hyb_ens,dual_res
use hybrid_ensemble_parameters, only: n_ens_gfs,weight_ens_gfs,grd_ens,grd_a1,grd_e1,p_e2a,uv_hyb_ens,dual_res
use hybrid_ensemble_parameters, only: full_ensemble,q_hyb_ens,l_ens_in_diff_time,write_ens_sprd
use hybrid_ensemble_parameters, only: ntlevs_ens,ensemble_path,jcap_ens
use control_vectors, only: cvars2d,cvars3d,nc2d,nc3d
Expand Down Expand Up @@ -1311,7 +1311,7 @@ subroutine get_gefs_for_regional
! 2*J_b = x^T * (beta1*B + beta2*P_ens)^(-1) * x
! where P_ens is the ensemble covariance which is the sum of outer products of the
! ensemble perturbations (unnormalized) divided by n_ens-1 (or n_ens, depending on who you read).
sig_norm=sqrt(one/max(one,n_ens_temp-one))
sig_norm=sqrt(weight_ens_gfs/max(one,n_ens_temp-one))

! if(n_ens_temp==n_ens.and.n==n_ens+1) sig_norm=one
! if(n==1 .or. n==2 .or. n==50) then
Expand Down
8 changes: 5 additions & 3 deletions src/gsi/gsimod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,7 @@ module gsimod
i_ensloccov4tim,i_ensloccov4var,i_ensloccov4scl,l_timloc_opt,&
vdl_scale,vloc_varlist,&
global_spectral_filter_sd,assign_vdl_nml,parallelization_over_ensmembers
use hybrid_ensemble_parameters,only : l_both_fv3sar_gfs_ens,n_ens_gfs,n_ens_fv3sar
use hybrid_ensemble_parameters,only : l_both_fv3sar_gfs_ens,n_ens_gfs,n_ens_fv3sar,weight_ens_gfs,weight_ens_fv3sar
use rapidrefresh_cldsurf_mod, only: init_rapidrefresh_cldsurf, &
dfi_radar_latent_heat_time_period,metar_impact_radius,&
metar_impact_radius_lowcloud,l_gsd_terrain_match_surftobs, &
Expand Down Expand Up @@ -1408,7 +1408,8 @@ module gsimod
! s_ens_h = v1L1 v2L1 v3L1 v1L2 v2L2
! Then localization lengths will be assigned as above.
!
namelist/hybrid_ensemble/l_hyb_ens,uv_hyb_ens,q_hyb_ens,aniso_a_en,generate_ens,n_ens,l_both_fv3sar_gfs_ens,n_ens_gfs,n_ens_fv3sar,nlon_ens,nlat_ens,jcap_ens,&
namelist/hybrid_ensemble/l_hyb_ens,uv_hyb_ens,q_hyb_ens,aniso_a_en,generate_ens,n_ens,&
l_both_fv3sar_gfs_ens,n_ens_gfs,n_ens_fv3sar,weight_ens_gfs,weight_ens_fv3sar,nlon_ens,nlat_ens,jcap_ens,&
pseudo_hybens,merge_two_grid_ensperts,regional_ensemble_option,fv3sar_bg_opt,fv3sar_ensemble_opt,full_ensemble,pwgtflg,&
jcap_ens_test,beta_s0,beta_e0,s_ens_h,s_ens_v,readin_localization,eqspace_ensgrid,readin_beta,&
grid_ratio_ens, &
Expand Down Expand Up @@ -1821,7 +1822,8 @@ subroutine gsimain_initialize
else
write(6,*)'n_ens_gfs and n_ens_fv3sar won"t be used if not regional_ensemble_option==5'
endif

weight_ens_gfs=one
Copy link
Copy Markdown
Contributor

@TingLei-NOAA TingLei-NOAA Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here, the namelist parameters like l_both_fv3sar_gfs_ens had been readin as well as weight_ens_gfs and weight_ens_fv3sar, right? then those assignments of the later two parameters (weight_ens??) will override the readin values for them. So, they will always be one.
Do I misunderstand something here?

Copy link
Copy Markdown
Collaborator Author

@shoyokota shoyokota Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the case of l_both_fv3sar_gfs_ens=.false., only either global or regional ensemble is used, so weight_ens_gfs and weight_ens_fv3sar should be one (only either is used). To force that, I added this part. (If ensemble B should be tuned in this case, please don't set weight_ens_gfs or weight_ens_fv3sar but set beta_e0.) In the case of l_both_fv3sar_gfs_ens=.true., weight_ens_gfs and weight_ens_fv3sar are not overwritten and the parameters in the namelist are used.

Copy link
Copy Markdown
Contributor

@TingLei-NOAA TingLei-NOAA Mar 1, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoyokota Thanks for your explanation . That does make sense.
This question is resolved

Copy link
Copy Markdown
Contributor

@ShunLiu-NOAA ShunLiu-NOAA Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shoyokota Could you please run a regression test and document the test result here.

Copy link
Copy Markdown
Collaborator Author

@shoyokota shoyokota Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShunLiu-NOAA I tried regression tests on Orion, but global 3dvar/4denvar/4dvar tests were failed because accesses to some files belonging to group "rstprod" are not permitted. I requested access to the NOAA RDHPCS Program, but it has not been accepted yet after two weeks. Even after it is accepted, I can run tests only on Orion. Could I ask someone to run the regression tests on my behalf?

Copy link
Copy Markdown
Contributor

@ShunLiu-NOAA ShunLiu-NOAA Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TingLei-NOAA Could you please run a regression test on HERA or WCOSS2?

Copy link
Copy Markdown
Contributor

@TingLei-NOAA TingLei-NOAA Mar 9, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ShunLiu-NOAA Sure, I will give an update here when I have finished the regression tests.

weight_ens_fv3sar=one
endif
if(ltlint) then
if(vqc .or. njqc .or. nvqc)then
Expand Down
4 changes: 4 additions & 0 deletions src/gsi/hybrid_ensemble_parameters.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -287,6 +287,7 @@ module hybrid_ensemble_parameters
public :: generate_ens,n_ens,nlon_ens,nlat_ens,jcap_ens,jcap_ens_test,l_hyb_ens,&
s_ens_h,oz_univ_static,vvlocal
public :: n_ens_gfs,n_ens_fv3sar
public :: weight_ens_gfs,weight_ens_fv3sar
public :: uv_hyb_ens,q_hyb_ens,s_ens_v,beta_s0,beta_e0,aniso_a_en,s_ens_hv,s_ens_vv
public :: readin_beta,beta_s,beta_e
public :: readin_localization
Expand Down Expand Up @@ -361,6 +362,7 @@ module hybrid_ensemble_parameters
integer(i_kind) i_en_perts_io
integer(i_kind) n_ens,nlon_ens,nlat_ens,jcap_ens,jcap_ens_test
integer(i_kind) n_ens_gfs,n_ens_fv3sar
real(r_kind) weight_ens_gfs,weight_ens_fv3sar
real(r_kind) beta_s0,beta_e0,grid_ratio_ens
integer(i_kind),parameter::max_naensloc=20
integer(i_kind),parameter::max_nvars=100
Expand Down Expand Up @@ -497,6 +499,8 @@ subroutine init_hybrid_ensemble_parameters
l_both_fv3sar_gfs_ens=.false.
n_ens_gfs=0
n_ens_fv3sar=0
weight_ens_gfs=one
weight_ens_fv3sar=one
vdl_scale = 0
vloc_varlist = 'aaa'
global_spectral_filter_sd=.false.
Expand Down