Skip to content

Release/gfsda.v16.3.0 warnings #464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
emilyhcliu merged 2 commits into from
Aug 28, 2022
Merged

Release/gfsda.v16.3.0 warnings #464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
616d5ab
Fixed variables not initialized correctly in conventional data
emilyhcliu Aug 26, 2022
a5101ee
Fix un-initialized variables
emilyhcliu Aug 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions src/gsi/stub_wrf_binary_interface.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,18 +29,26 @@ end subroutine convert_binary_mass_dummy

subroutine convert_binary_nmm_dummy(this,update_pint,ctph0,stph0,tlm0)
use kinds, only: r_kind
use constants, only: zero
implicit none
class(get_wrf_binary_interface_class), intent(inout) :: this
logical ,intent(inout) :: update_pint
real(r_kind),intent( out) :: ctph0,stph0,tlm0
ctph0 = zero
stph0 = zero
tlm0 = zero
Comment on lines +37 to +39
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a stub. Meaning, this code exists solely for compilation to succeed in making the handshake.
This routine will not be called at runtime, and if it is, then something is wrong elsewhere.
The values zero are fine here and possibly serve for suppressing compilation warnings.

Copy link
Copy Markdown
Contributor Author

@emilyhcliu emilyhcliu Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are no run-time errors from this stub routine. They were compilation warnings. NCO wants these warnings to be fixed. Thanks for your review.

end subroutine convert_binary_nmm_dummy

subroutine convert_nems_nmmb_dummy(this,update_pint,ctph0,stph0,tlm0)
use kinds, only: r_kind
use constants, only: zero
implicit none
class(get_wrf_binary_interface_class), intent(inout) :: this
logical ,intent(inout) :: update_pint
real(r_kind),intent( out) :: ctph0,stph0,tlm0
ctph0 = zero
stph0 = zero
tlm0 = zero
Comment on lines +49 to +51
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same comment as above.

end subroutine convert_nems_nmmb_dummy

end module get_wrf_binary_interface_mod
5 changes: 4 additions & 1 deletion src/gsi/stub_wrf_netcdf_interface.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,12 +30,15 @@ end subroutine convert_netcdf_mass_dummy

subroutine convert_netcdf_nmm_dummy(this,update_pint,ctph0,stph0,tlm0,guess)
use kinds, only: r_single,i_kind,r_kind
use constants, only: zero
implicit none
class(convert_netcdf_class) ,intent(inout) :: this
logical ,intent(in ) :: guess
logical ,intent(inout) :: update_pint
real(r_kind),intent( out) :: ctph0,stph0,tlm0

ctph0 = zero
stph0 = zero
tlm0 = zero
Comment on lines +39 to +41
Copy link
Copy Markdown
Contributor

@aerorahul aerorahul Aug 26, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here.

end subroutine convert_netcdf_nmm_dummy

subroutine update_netcdf_mass_dummy(this)
Expand Down
2 changes: 1 addition & 1 deletion util/Conventional_Monitor/nwprod/conmon_shared/sorc/conmon_grads_lev.fd/maingrads_lev.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ subroutine grads_lev(fileo,ifileo,nobs,nreal,nlev,plev,iscater,igrads, &

integer ifileo
character(ifileo) :: fileo
integer :: nobs,nreal,nlev,igrads,isubtype
integer :: nobs,nreal,nlev,igrads,isubtype,iscater
real(4),dimension(nlev) :: plev
character(10) :: levcard
real*4 :: hint
Expand Down
5 changes: 3 additions & 2 deletions ...ventional_Monitor/nwprod/conmon_shared/sorc/conmon_grads_sfctime.fd/maingrads_sfctime.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,10 +20,11 @@ subroutine grads_sfctime(fileo,ifileo,nobs,nreal,&
nlev,plev,iscater,igrads,isubtype,subtype,list,run)

use generic_list
character(ifileo) :: fileo
integer :: ifileo,nobs,nreal,nlev
character(ifileo) :: fileo
real(4),dimension(nlev) :: plev
integer :: iscater,igrdas,isubtype
! integer :: iscater,igrdas,isubtype
integer :: iscater,igrads,isubtype
character(3) :: subtype
type(list_node_t),pointer :: list
character(3) :: run
Expand Down
2 changes: 1 addition & 1 deletion util/Conventional_Monitor/nwprod/conmon_shared/sorc/conmon_grads_sig.fd/maingrads_sig.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ subroutine grads_sig(fileo,ifileo,nobs,nreal,nlev,plev,iscater,igrads,isubtype,

integer ifileo
character(ifileo) :: fileo
integer :: nobs,nreal,nlev,igrads,isubtype
integer :: nobs,nreal,nlev,igrads,isubtype,iscater
real(4),dimension(nlev) :: plev
character(3) :: subtype
type(list_node_t), pointer :: list
Expand Down