GitHub Issue NOAA-EMC/GSI#24. Add LeoGeo AMVs in GSI.#31
Conversation
|
Hi Mike
I looked at the wiki page on github and I cannot find instructions how to
review the ticket, should I go to vlab? Thanks
Su
…On Tue, Aug 4, 2020 at 5:50 AM MichaelLueken-NOAA ***@***.***> wrote:
@MichaelLueken-NOAA <https://github.com/MichaelLueken-NOAA> requested
your review on: #31 <#31> Add LeoGeo
AMVs in GSI (without COSMIC code).
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5S7HSMJKZXAV4FQARNCGLR67KVLANCNFSM4OVG3PYQ>
.
|
|
Hi Su, We no longer use VLab, only GitHub. To review a pull request, click on Files changed. The changes are now shown. If you see something that you have questions about, click the blue + icon and add a comment. For more details, please see https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/about-pull-request-reviews Mike |
XiujuanSu-NOAA
left a comment
XiujuanSu-NOAA
left a comment
There was a problem hiding this comment.
I am ok with most lines, only one at read_satwnd.f90: you can combine 406 and 407 lines into one.
|
I checked global_convinfo.txt file, the changes are fine. However should the changes also apply to other convinfo files? Su |
|
Su, |
|
Ok, no problem.
Su
…On Tue, Aug 25, 2020 at 3:03 PM iliana Genkova ***@***.***> wrote:
Su,
we decided not to make changes to the historic convinfo files, because
LeoGeo winds do not exist before Sep 2019. We only changed the
global_convinfo.txt because these winds will be in monitoring mode for a
while. When we are ready to start assimilating them, we will consider
changing the other convinfo files. Thanks!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#31 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AP5S7HQDXKPTLL5V62KKT63SCQDIPANCNFSM4OVG3PYQ>
.
|
GitHub Issue NOAA-EMC/GSI#24. Add LeoGeo AMVs to GSI (with Mike L.'s help)
MichaelLueken
left a comment
MichaelLueken
left a comment
There was a problem hiding this comment.
Hi Iliana,
I have completed my review of your changes. The regression tests passed without issue. Similarly, there were no issues encountered while compiling and running your changes in debug mode. There are several lines (lines 891 - 902) in read_satwnd.f90 that are commented out. Please remove these lines unless they will be used in the near future. Once you have either updated or commented on lines 891 - 902, then I can send this work to the review committee.
Thanks,
Mike
| !do j=1,6 | ||
| !if( qify <=r105 .and. qifn <r105 .and. ee <r105) exit | ||
| !if(qcdat(2,j) <= r10000 .and. qcdat(3,j) <r10000 ) then | ||
| ! if(qcdat(2,j) == one .and. qifn >r105) then | ||
| ! qifn=qcdat(3,j) | ||
| ! else if(qcdat(2,j) == three .and. qify >r105) then | ||
| ! qify=qcdat(3,j) | ||
| ! else if( qcdat(2,j) == four .and. ee >r105) then | ||
| ! ee=qcdat(3,j) | ||
| ! endif | ||
| !endif | ||
| !enddo |
There was a problem hiding this comment.
If these commented out lines aren't needed and won't be used in the future, please remove them.
|
Hi Mike, These lines will be used in the near future. NESDIS is working towards unifying the BUFR formats of all their winds and by the end of the year I'd know the final configuration. I could then clean up the code from this and other comments which might become obsolete. Thanks! |
MichaelLueken
changed the title
|
The due date for the review committee has passed with no feedback, so final approval was given and the update was merged to the NOAA-EMC/GSI master. |
GitHub Issue NOAA-EMC#24. Add LeoGeo AMVs in GSI.
3 participants
AMV_Genkova_parallel_ncio_LG - branch adding LeoGeo AMVs to GSI
Please see the GitHub Issue #24 for more details.