Skip to content

GitHub Issue NOAA-EMC/GSI#17. Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.#18

Merged
MichaelLueken merged 1 commit into
NOAA-EMC:masterfrom
comgsi:comGSI-2020002
Jun 17, 2020
Merged

Conversation

@guoqing-noaa
Copy link
Copy Markdown
Contributor

  1. added FV3GFS_NCIO_Fortran_FLAGS for GNU compilers

  2. Moved gsdcloud to src/, make appropriate changes in CMakeLists.txt and a few bug fixes

  3. pietc.f90 and pvqc_tables.f90

    use kinds, only: dp,dpc
--> use kinds, only: r_kind, dp, dpc

This change is to avoid compiling error

error #6580: Name in only-list does not exist or is not accessible. [DP]

Don't know the exact reason, but either (1) removing all #ifdef block in kinds.F90 or (2) use r_kind first can solve this problem.

  1. updated util/EnKF/arw/src/enspreproc_regional.fd/CMakeLists.txt

  2. bug fixes for GNU compilers and regional EnKF.

  3. updated ush/build.comgsi for community users

change build.comgsi
move GSD/gsdcloud to src/
@hu5970
Copy link
Copy Markdown
Collaborator

hu5970 commented Jun 15, 2020

Should we change directory name from GSD to NoVarCloudAnal for clarification.

@guoqing-noaa
Copy link
Copy Markdown
Contributor Author

Should we change directory name from GSD to NoVarCloudAnal for clarification.

I would say better to leave it as is. I had thought to change GSD to GSL. But keeping it as is will involve less changes and many community users are already familiar with this GSD naming convection. May change it in the future if warranted. Thanks!

@MichaelLueken MichaelLueken requested a review from hu5970 June 15, 2020 17:01
@MichaelLueken MichaelLueken changed the title bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src/ GitHub Issue NOAA-EMC/GSI#17. Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src. Jun 17, 2020
@MichaelLueken MichaelLueken merged commit fcec2a9 into NOAA-EMC:master Jun 17, 2020
shoyokota referenced this pull request in shoyokota/GSI Jul 15, 2022
xyzemc pushed a commit to xyzemc/GSI_develop-v16-tms that referenced this pull request Feb 27, 2026
GitHub Issue NOAA-EMC#17.  Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src/

4 participants