GitHub Issue NOAA-EMC/GSI#17. Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.#18
Merged
Conversation
change build.comgsi move GSD/gsdcloud to src/
Collaborator
|
Should we change directory name from GSD to NoVarCloudAnal for clarification. |
Contributor
Author
I would say better to leave it as is. I had thought to change GSD to GSL. But keeping it as is will involve less changes and many community users are already familiar with this GSD naming convection. May change it in the future if warranted. Thanks! |
willmayfield
approved these changes
Jun 15, 2020
xyzemc
pushed a commit
to xyzemc/GSI_develop-v16-tms
that referenced
this pull request
Feb 27, 2026
GitHub Issue NOAA-EMC#17. Bug fixes for regional EnKF, GNU compilers; change build.comgsi; move gsdcloud to src.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
added FV3GFS_NCIO_Fortran_FLAGS for GNU compilers
Moved gsdcloud to src/, make appropriate changes in CMakeLists.txt and a few bug fixes
pietc.f90 and pvqc_tables.f90
This change is to avoid compiling error
error #6580: Name in only-list does not exist or is not accessible. [DP]Don't know the exact reason, but either (1) removing all #ifdef block in kinds.F90 or (2) use r_kind first can solve this problem.
updated util/EnKF/arw/src/enspreproc_regional.fd/CMakeLists.txt
bug fixes for GNU compilers and regional EnKF.
updated ush/build.comgsi for community users