Updates for Rocky 8.#32
Merged
aerorahul merged 2 commits intoMar 22, 2024
Merged
Conversation
RussTreadon-NOAA
previously approved these changes
Mar 20, 2024
Contributor
RussTreadon-NOAA
left a comment
RussTreadon-NOAA
left a comment
There was a problem hiding this comment.
Looks good to me. The same change was made in GSI PR #715.
Approve.
DavidHuber-NOAA
approved these changes
Mar 21, 2024
Collaborator
DavidHuber-NOAA
left a comment
DavidHuber-NOAA
left a comment
There was a problem hiding this comment.
The Intel changes look good, but the GNU compilers should also be updated. That can be handled in a separate PR if needed. Approve.
Collaborator
|
@HenryWinterbottom-NOAA Note, if you change the GNU module file, also delete line 6: The openmpi module is now in the standard stack and does not require an external use statement. |
HenryRWinterbottom
dismissed stale reviews from RussTreadon-NOAA and aerorahul
via
01091c7
HenryRWinterbottom
force-pushed
the
feature/gwdev_issue_2329
branch
from
c52f065 to
01091c7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates for RDHPCS Hera Rocky-8 upgrade.