Update code to use 'constantsR4_mod' module#59
Merged
Conversation
driver/fvGFS/atmosphere.F90 driver/fvGFS/fv_nggps_diag.F90 model/fv_dynamics.F90 model/fv_nesting.F90 model/fv_update_phys.F90 model/nh_core.F90 model/nh_utils.F90 tools/coarse_grained_diagnostics.F90 tools/external_ic.F90 tools/fv_diagnostics.F90 tools/fv_nudge.F90 tools/fv_restart.F90 tools/test_cases.F90
| real(r4_kind) qmin(jm), qmax(jm) | ||
| real(r4_kind) pmax, pmin | ||
| class(*) fac ! multiplication factor | ||
| real(r8_kind) qmin8(jm), qmax8(jm) |
Collaborator
There was a problem hiding this comment.
Should we make these local arrays allocatable? (I am not sure how large jm is).
| qmax(j) = pmax | ||
| qmin(j) = pmin | ||
| enddo | ||
| qmax(j) = pmax |
Collaborator
There was a problem hiding this comment.
Minor details: the statements under the select type constructs and do loops do not seem be indented consistently.
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
The code changes look good. Please correct the indentation in external_ic.F90 and fv_nudge.F90, Thanks
MinsukJi-NOAA
approved these changes
Oct 20, 2021
junwang-noaa
approved these changes
Oct 21, 2021
BinLiu-NOAA
pushed a commit
to hafs-community/GFDL_atmos_cubed_sphere
that referenced
this pull request
Dec 13, 2022
* Update code to use 'constantsR4_mod' module (NOAA-EMC#59) * update tools/fv_nudge.F90 * modify the following files to use 'constantsR4_mod' module: driver/fvGFS/atmosphere.F90 driver/fvGFS/fv_nggps_diag.F90 model/fv_dynamics.F90 model/fv_nesting.F90 model/fv_update_phys.F90 model/nh_core.F90 model/nh_utils.F90 tools/coarse_grained_diagnostics.F90 tools/external_ic.F90 tools/fv_diagnostics.F90 tools/fv_nudge.F90 tools/fv_restart.F90 tools/test_cases.F90 * revise external_ic.F90 and fv_nudge.F90 to use allocatable arrays
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update code to use 'constantsR4_mod' module.