add GFSv16 dzmin change and changes for Dev/jcsda#44
Merged
Conversation
…da, dycore PR NOAA-EMC#35 Co-authored-by: Dan Holdaway <dan.holdaway@nasa.govr>
Collaborator
Author
|
Dan, I combined your dycore#35 in this PR. Please check. |
Collaborator
Author
|
RT test showed dzmin change has no impact on current baseline, as Lucas expected. |
XiaqiongZhou-NOAA
approved these changes
Nov 12, 2020
junwang-noaa
changed the title
danholdaway
approved these changes
Nov 12, 2020
climbfuji
approved these changes
Nov 17, 2020
climbfuji
left a comment
climbfuji
left a comment
There was a problem hiding this comment.
Not named as a reviewer, but it works for me when running the regression tests on hera.{intel,gnu} and cheyenne.{intel,gnu}.
bensonr
approved these changes
Nov 17, 2020
DusanJovic-NOAA
approved these changes
Nov 17, 2020
LarissaReames
pushed a commit
to LarissaReames/GFDL_atmos_cubed_sphere
that referenced
this pull request
Mar 15, 2021
* add GFSv16 dzmin change * Add code changes in external_ic.F90 and fv_grid_tools.F90 for dev/jcsda, dycore PR NOAA-EMC#35 Co-authored-by: Jun Wang <junwang-noaa@users.noreply.github.com> Co-authored-by: Dan Holdaway <dan.holdaway@nasa.govr>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Associated PR:
dycore PR #44
fv3atm PR #196
ufs-weather-model PR #274