GFS.v16: update model/nh_utils.F90 with dz_min change#41
Merged
junwang-noaa merged 1 commit intoOct 2, 2020
Merged
Conversation
This was referenced Oct 2, 2020
XiaqiongZhou-NOAA
approved these changes
Oct 2, 2020
|
@junwang-noaa are you planning to bring this back to dev/emc ? Are there any notes or an issue describing the problem? It sounds like it could be relevant for the GSL physics team, but I can't tell from the code changes alone. Thanks! |
Collaborator
|
Dom,
GFS.v16 crashed a few times in early September when a strong typhoon passed
through a small island over Japan. In the past month we have been working
with GFDL to diagnose the causes. Different approaches have been tested to
stabilize the model. It was found that a change made to model/nh_utils.F90
is the most effective and least intrusive. Its impact on forecast is
small. The adjustments only occur rarely over a small portion of the grids.
Fanglin
…On Fri, Oct 2, 2020 at 12:57 PM Dom Heinzeller ***@***.***> wrote:
@junwang-noaa <https://github.com/junwang-noaa> are you planning to bring
this back to dev/emc ? Are there any notes or an issue describing the
problem? It sounds like it could be relevant for the GSL physics team, but
I can't tell from the code changes alone. Thanks!
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AKY5N2KK462JKBFIQMLBBMLSIYBARANCNFSM4SB264DQ>
.
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
|
Collaborator
Author
|
Dom, yes we will bring back the code change to develop. Also the variable
that was changed should be put in namelist to allow people to test in their
own applications. I will open an issue.
On Fri, Oct 2, 2020 at 1:06 PM Fanglin Yang <notifications@github.com>
wrote:
… Dom,
GFS.v16 crashed a few times in early September when a strong typhoon passed
through a small island over Japan. In the past month we have been working
with GFDL to diagnose the causes. Different approaches have been tested to
stabilize the model. It was found that a change made to model/nh_utils.F90
is the most effective and least intrusive. Its impact on forecast is
small. The adjustments only occur rarely over a small portion of the grids.
Fanglin
On Fri, Oct 2, 2020 at 12:57 PM Dom Heinzeller ***@***.***>
wrote:
> @junwang-noaa <https://github.com/junwang-noaa> are you planning to
bring
> this back to dev/emc ? Are there any notes or an issue describing the
> problem? It sounds like it could be relevant for the GSL physics team,
but
> I can't tell from the code changes alone. Thanks!
>
> —
> You are receiving this because your review was requested.
> Reply to this email directly, view it on GitHub
> <
#41 (comment)
>,
> or unsubscribe
> <
https://github.com/notifications/unsubscribe-auth/AKY5N2KK462JKBFIQMLBBMLSIYBARANCNFSM4SB264DQ
>
> .
>
--
*Fanglin Yang, Ph.D.*
*Chief, Model Physics Group*
*Modeling and Data Assimilation Branch*
*NOAA/NWS/NCEP Environmental Modeling Center*
*https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/
<https://www.emc.ncep.noaa.gov/gmb/wx24fy/fyang/>*
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#41 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AI7D6TISWR4PJ7SKULDDKTLSIYB7ZANCNFSM4SB264DQ>
.
|
|
Thanks, @yangfanglin and @junwang-noaa. This is useful to know. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To resolve the model instability issue:
-The dz_min is changed from 2 to 6, and the order of computation is updated to run the code efficiently.