This commit #refs 66173 (merge gmtb/develop into NOAA-EMC/dev/emc)#3
Closed
climbfuji wants to merge 1 commit into
Closed
Conversation
commit 94ab0e1 Author: Jun.Wang <Jun.Wang@noaa.gov> Date: Mon Aug 26 21:03:55 2019 +0000 add option to output omega commit b700cae Author: climbfuji <dom.heinzeller@icloud.com> Date: Fri Aug 30 11:58:00 2019 -0600 model/fv_dynamics.F90: replicating previous change to gmtb/develop branch of FV3, always allocate dtdt_m for IPD version commit 3df1171 Author: Laurie Carson <carson@ucar.edu> Date: Fri Aug 16 10:46:56 2019 -0600 Add codeowners for NCAR fork
This was referenced Sep 9, 2019
Collaborator
junwang-noaa
left a comment
junwang-noaa
left a comment
There was a problem hiding this comment.
Dom,
I think we had some email exchange on the code changes when the pull request was made. Generally we suggest not to allocate an additional 3D field as a fix. Do you still like to make the pull request? If yes, can we have a meting with GFDL dycore experts to discuss how to move forward with this pull request? Thanks.
Author
|
@junwang-noaa this PR is old and should be closed based on the conversation we had. I think we agreed to discuss this with GFDL and implement a version in accordance with them. I will close the PR. Thanks for revisiting all the old PRs. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix an issue with passing an unallocated array dtdt_m fro fv_dynamics to the Lagrangian_to_Eularian subroutine, which expects dtdt_m as an array with fixed dimensions. This is invalid code and causes problems in DEBUG mode. One way to fix this is proposed here, but there are better ways that avoid allocating dtdt_m every time.
commit b700cae
Author: climbfuji dom.heinzeller@icloud.com
Date: Fri Aug 30 11:58:00 2019 -0600